Package: release.debian.org Severity: normal User: release.debian.org@packages.debian.org Usertags: unblock Please unblock package foxtrotgps This fixes the fallout from imagemagick disabling EPS output (#987504) and something that was missed when porting to recent gpsd APIs. [ Reason ] The foxtrotgps documentation build by default converted .png files to EPS files for inclusion in the DVI and PS formatted documentation but the Debian package doesn't contain DVI/PS formatted documentation. Since imagemagick now blocks conversion to EPS, the upstream fix simply disables building EPS files unless building DVI/PS documentation. The gpsd developers deprecated using the GPS fix status in favour of using the GPS fix mode for detecting when a GPS position is available. The patch simply adds support for detecting 2D/3D fix modes. The GPS patch is minimal, fixes an important bug and both patches are already upstream, so I elected to package the latest upstream commit. [ Impact ] The package will FTBFS and will not be able to show the current GPS fix location with the current gpsd version. [ Tests ] I tested the build fix and the gpsd patch submitter tested the gpsd fix. [ Risks ] This is a leaf package and the changes are small, the risks are low. [ Checklist ] [x] all changes are documented in the d/changelog [x] I reviewed all changes and I approve them [x] attach debdiff against the package in testing [ Other info ] Thanks for all your work on the bullseye release. unblock foxtrotgps/1.2.2+bzr330-1 -- bye, pabs https://wiki.debian.org/PaulWise
diff -Nru foxtrotgps-1.2.2+bzr328/changelog/ChangeLog foxtrotgps-1.2.2+bzr330/changelog/ChangeLog --- foxtrotgps-1.2.2+bzr328/changelog/ChangeLog 2021-01-31 16:18:24.000000000 +0800 +++ foxtrotgps-1.2.2+bzr330/changelog/ChangeLog 2021-07-14 07:44:15.000000000 +0800 @@ -1,4 +1,37 @@ ------------------------------------------------------------ +revno: 330 +committer: Paul Wise <pabs3@bonedaddy.net> +branch nick: bzr +timestamp: Mon 2021-04-26 12:33:42 +0800 +message: + Only create the EPS formatted images for the DVI/PS formatted + documentation + + The EPS files are not needed for other documentation formats, + some distributions are now disabling EPS support in ImageMagick + and the DVI/PS documentation formats are rarely used. +modified: + doc/Makefile.am +------------------------------------------------------------ +revno: 329 +author: diego roversi <diegor71> +committer: Paul Wise <pabs3@bonedaddy.net> +branch nick: bzr +timestamp: Sun 2021-03-07 14:05:44 +0800 +message: + Also accept 2D/3D fix modes as indicator of a valid GPS fix + + The libgps developers recommend to use the fix mode rather than + the status, + which many GNSS receivers do not supply or have incompatible + implementations. + + Fixes: https://bugs.launchpad.net/bugs/1917998 + See-also: + https://gitlab.com/gpsd/gpsd/-/commit/c3b0fb6394964ca57cecfa0a65d6b3cde2dd1f6f +modified: + src/gps_functions.c +------------------------------------------------------------ revno: 328 author: Maciej S. Szmigiero committer: Paul Wise <pabs3@bonedaddy.net> diff -Nru foxtrotgps-1.2.2+bzr328/debian/changelog foxtrotgps-1.2.2+bzr330/debian/changelog --- foxtrotgps-1.2.2+bzr328/debian/changelog 2021-01-31 16:47:52.000000000 +0800 +++ foxtrotgps-1.2.2+bzr330/debian/changelog 2021-07-14 07:58:30.000000000 +0800 @@ -1,3 +1,11 @@ +foxtrotgps (1.2.2+bzr330-1) unstable; urgency=medium + + * New upstream snapshot. + - Fixes FTBFS with new imagemagick (Closes: #991056) + - Fixes use of deprecated gpsd API (see LP#1917998) + + -- Paul Wise <pabs@debian.org> Wed, 14 Jul 2021 07:58:30 +0800 + foxtrotgps (1.2.2+bzr328-1) unstable; urgency=medium [ Paul Wise ] diff -Nru foxtrotgps-1.2.2+bzr328/doc/Makefile.am foxtrotgps-1.2.2+bzr330/doc/Makefile.am --- foxtrotgps-1.2.2+bzr328/doc/Makefile.am 2021-01-09 08:39:19.171000000 +0800 +++ foxtrotgps-1.2.2+bzr330/doc/Makefile.am 2021-04-26 12:33:42.000000000 +0800 @@ -6,7 +6,8 @@ info_TEXINFOS = foxtrotgps.texi -foxtrotgps_TEXINFOS = $(images) $(images_eps) +foxtrotgps_TEXINFOS = $(images) +DVIS = $(images_eps) foxtrotgps.dvi images = \ foxtrotgps-logo.png \ diff -Nru foxtrotgps-1.2.2+bzr328/src/gps_functions.c foxtrotgps-1.2.2+bzr330/src/gps_functions.c --- foxtrotgps-1.2.2+bzr328/src/gps_functions.c 2021-01-09 08:39:19.171000000 +0800 +++ foxtrotgps-1.2.2+bzr330/src/gps_functions.c 2021-04-26 12:33:42.000000000 +0800 @@ -763,7 +763,7 @@ gpsdata->fix.time = (time_t) 0; } #if GPSD_API_MAJOR_VERSION >= 10 - gpsdata->valid = (libgps_gpsdata.fix.status != STATUS_NO_FIX); + gpsdata->valid = (libgps_gpsdata.fix.status != STATUS_NO_FIX || libgps_gpsdata.fix.mode >= MODE_2D); #else gpsdata->valid = (libgps_gpsdata.status != STATUS_NO_FIX); #endif
Attachment:
signature.asc
Description: This is a digitally signed message part