[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#991062: marked as done (unblock: apache2/2.4.48-3.1)

Your message dated Tue, 13 Jul 2021 18:59:46 +0200
with message-id <YO3Ggva+DX3yfEXX@ramacher.at>
and subject line Re: Bug#991062: unblock: apache2/2.4.48-3.1
has caused the Debian Bug report #991062,
regarding unblock: apache2/2.4.48-3.1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
991062: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=991062
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Hi!
Please unblock package apache2.  After a bunch of random changes from
experimental got into testing, there were regressions.  Forbidding such
changes is pretty much the point of the freeze after all...

One of the regressions (#990580) causes cron mails on every logrotate run. 
Thorsten Glaser has, with permission of the maintainer, made a NMU
containing an one-line fix.


[ Reason ]
The change that caused the regression shouldn't have been included into
testing so late in the freeze; let's fix the nastiest bit.

[ Impact ]
A very popular package with massive deployments would send a mail once per
day per machine, severely annoying admins.

[ Tests ]
No automated tests; to test manually wait a night with the default
configuration to see if you'll receive a mail; can logrotate -v -f and
see if there's output.

[ Risks ]
It's a simple one-line fix.

[ Checklist ]
  [✓] all changes are documented in the d/changelog
  [✓] I reviewed all changes and I approve them
  [✓] attach debdiff against the package in testing


unblock apache2/2.4.48-3.1

diff -Nru apache2-2.4.48/debian/apache2.logrotate apache2-2.4.48/debian/apache2.logrotate
--- apache2-2.4.48/debian/apache2.logrotate	2021-06-20 13:55:24.000000000 +0200
+++ apache2-2.4.48/debian/apache2.logrotate	2021-07-10 23:31:24.000000000 +0200
@@ -14,7 +14,7 @@
     endscript
     postrotate
 	if pgrep -f ^/usr/sbin/apache2 > /dev/null; then
-	    invoke-rc.d apache2 reload
+	    invoke-rc.d apache2 reload 2>&1 | logger -t apache2.logrotate
 	fi
     endscript
 }
diff -Nru apache2-2.4.48/debian/changelog apache2-2.4.48/debian/changelog
--- apache2-2.4.48/debian/changelog	2021-06-20 16:39:33.000000000 +0200
+++ apache2-2.4.48/debian/changelog	2021-07-10 23:31:28.000000000 +0200
@@ -1,3 +1,11 @@
+apache2 (2.4.48-3.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Direct init script reload output from logrotate to syslog, to
+    avoid mail-spamming the local admin (Closes: #990580)
+
+ -- Thorsten Glaser <tg@mirbsd.de>  Sat, 10 Jul 2021 23:31:28 +0200
+
 apache2 (2.4.48-3) unstable; urgency=medium
 
   * Fix debian/changelog

--- End Message ---
--- Begin Message --- 
On 2021-07-13 16:11:33 +0200, Adam Borowski wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Hi!
> Please unblock package apache2.  After a bunch of random changes from
> experimental got into testing, there were regressions.  Forbidding such
> changes is pretty much the point of the freeze after all...
> 
> One of the regressions (#990580) causes cron mails on every logrotate run. 
> Thorsten Glaser has, with permission of the maintainer, made a NMU
> containing an one-line fix.
> 
> 
> [ Reason ]
> The change that caused the regression shouldn't have been included into
> testing so late in the freeze; let's fix the nastiest bit.
> 
> [ Impact ]
> A very popular package with massive deployments would send a mail once per
> day per machine, severely annoying admins.
> 
> [ Tests ]
> No automated tests; to test manually wait a night with the default
> configuration to see if you'll receive a mail; can logrotate -v -f and
> see if there's output.
> 
> [ Risks ]
> It's a simple one-line fix.
> 
> [ Checklist ]
>   [✓] all changes are documented in the d/changelog
>   [✓] I reviewed all changes and I approve them
>   [✓] attach debdiff against the package in testing
> 
> 
> unblock apache2/2.4.48-3.1

There's #990968 already. Closing.

Cheers


> diff -Nru apache2-2.4.48/debian/apache2.logrotate apache2-2.4.48/debian/apache2.logrotate
> --- apache2-2.4.48/debian/apache2.logrotate	2021-06-20 13:55:24.000000000 +0200
> +++ apache2-2.4.48/debian/apache2.logrotate	2021-07-10 23:31:24.000000000 +0200
> @@ -14,7 +14,7 @@
>      endscript
>      postrotate
>  	if pgrep -f ^/usr/sbin/apache2 > /dev/null; then
> -	    invoke-rc.d apache2 reload
> +	    invoke-rc.d apache2 reload 2>&1 | logger -t apache2.logrotate
>  	fi
>      endscript
>  }
> diff -Nru apache2-2.4.48/debian/changelog apache2-2.4.48/debian/changelog
> --- apache2-2.4.48/debian/changelog	2021-06-20 16:39:33.000000000 +0200
> +++ apache2-2.4.48/debian/changelog	2021-07-10 23:31:28.000000000 +0200
> @@ -1,3 +1,11 @@
> +apache2 (2.4.48-3.1) unstable; urgency=medium
> +
> +  * Non-maintainer upload.
> +  * Direct init script reload output from logrotate to syslog, to
> +    avoid mail-spamming the local admin (Closes: #990580)
> +
> + -- Thorsten Glaser <tg@mirbsd.de>  Sat, 10 Jul 2021 23:31:28 +0200
> +
>  apache2 (2.4.48-3) unstable; urgency=medium
>  
>    * Fix debian/changelog


-- 
Sebastian Ramacher

Attachment: signature.asc
Description: PGP signature


--- End Message ---
Reply to: