[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#991071: unblock: websockify/0.9.0+dfsg1-3



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package websockify


[ Reason ]
The only change is this:

override_dh_python3:
-	dh_python3 --shebang=/usr/bin/python3
+	dh_python3 --shebang=/usr/bin/python3 --no-ext-rename

which avoids renaming rebind.so with the usual multiarch tripplet.

[ Impact ]
If not unblocked, the package is kind of partially broken.

[ Tests ]
I checked the resulting .deb, and the file is correctly called
rebind.so.

[ Risks ]
There's already a rebind.o without the tripplet, so we already
aren't multi-arch friendly, but IMO, this isn't fixeable with
the way upstream did stuff. Probably attempting to fix it the
correct way (in a multi-arch friendly way) would break things
even further... So I believe it's best the way I uploaded to
unstable (at least for the Bullseye release). If the release
team thinks otherwise, then I need help on this package.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

unblock websockify/0.9.0+dfsg1-3
diff -Nru websockify-0.9.0+dfsg1/debian/changelog websockify-0.9.0+dfsg1/debian/changelog
--- websockify-0.9.0+dfsg1/debian/changelog	2020-05-08 12:12:01.000000000 +0200
+++ websockify-0.9.0+dfsg1/debian/changelog	2021-07-12 09:18:22.000000000 +0200
@@ -1,3 +1,11 @@
+websockify (0.9.0+dfsg1-3) unstable; urgency=medium
+
+  [ Jochen Sprickerhof ]
+  * Fix rebind.so not found (Closes: #990359), thanks to Mike Gabriel for the
+    bug report, and Jochen Sprickerhof for the fix.
+
+ -- Thomas Goirand <zigo@debian.org>  Mon, 12 Jul 2021 09:18:22 +0200
+
 websockify (0.9.0+dfsg1-2) unstable; urgency=medium
 
   * Uploading to unstable.
diff -Nru websockify-0.9.0+dfsg1/debian/clean websockify-0.9.0+dfsg1/debian/clean
--- websockify-0.9.0+dfsg1/debian/clean	1970-01-01 01:00:00.000000000 +0100
+++ websockify-0.9.0+dfsg1/debian/clean	2021-07-12 09:18:22.000000000 +0200
@@ -0,0 +1,2 @@
+rebind.o
+rebind.so
diff -Nru websockify-0.9.0+dfsg1/debian/rules websockify-0.9.0+dfsg1/debian/rules
--- websockify-0.9.0+dfsg1/debian/rules	2020-05-08 12:12:01.000000000 +0200
+++ websockify-0.9.0+dfsg1/debian/rules	2021-07-12 09:18:22.000000000 +0200
@@ -34,4 +34,4 @@
 	rm -rf $(CURDIR)/debian/python3-websockify/usr/share/man
 
 override_dh_python3:
-	dh_python3 --shebang=/usr/bin/python3
+	dh_python3 --shebang=/usr/bin/python3 --no-ext-rename

Reply to: