[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#991018: unblock: qreator/16.06.1-7



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package qreator.

[ Reason ]
Qreator is currently completely broken in testing (fails to startup, see
bug #986697). The fix is in 16.06.1-6, but that release also included
a few unrelated changes which I've reverted in 16.06.1-7.

[ Impact ]
Qreator fails to start up with an exception in testing, as per
https://bugs.debian.org/986697

[ Tests ]
Install qreator and verify that it launches

[ Risks ]
No risk -- it's currently completely broken in testing, and the fix is
in 16.06.1-6.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]
None

unblock qreator/16.06.1-7

-- System Information:
Debian Release: bullseye/sid
  APT prefers groovy-updates
  APT policy: (500, 'groovy-updates'), (500, 'groovy-security'), (500, 'groovy'), (400, 'groovy-proposed'), (100, 'groovy-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.12.1-hyper1 (SMP w/8 CPU threads)
Kernel taint flags: TAINT_CPU_OUT_OF_SPEC, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_SG.utf8, LC_CTYPE=en_SG.UTF-8 (charmap=UTF-8), LANGUAGE=en_SG:en
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff --git a/debian/changelog b/debian/changelog
index c582cd8..644cc99 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,24 @@
+qreator (16.06.1-7) unstable; urgency=medium
+
+  * [6451544] Revert "Reexport patches using gbp-pq"
+    This reverts commit 8dee7af8ba45f56b493f5b3d82876307283aae69.
+  * [143cdf2] Revert "Port to debhelper compat 13"
+    This reverts commit 9241568369785cab18fb1ac322d1945f1fa1946e.
+  * [c9a74fa] Revert "Update Standards-Version to 4.5.0"
+    This reverts commit f34db2f3ab9087a93dbdce9fb12c8abae340a16a.
+
+ -- Chow Loong Jin <hyperair@debian.org>  Tue, 13 Jul 2021 01:25:19 +0800
+
+qreator (16.06.1-6) unstable; urgency=medium
+
+  * [8dee7af] Reexport patches using gbp-pq
+  * [e0f42ae] Fix crash on startup due to usage of ElementTree.getiterator()
+    (Closes: #986697)
+  * [9241568] Port to debhelper compat 13
+  * [f34db2f] Update Standards-Version to 4.5.0
+
+ -- Chow Loong Jin <hyperair@debian.org>  Sun, 11 Apr 2021 15:56:22 +0800
+
 qreator (16.06.1-5) unstable; urgency=medium
 
   * [4eea653] Load current location from geoclue-2.0 asynchronously.
diff --git a/debian/patches/Port-ElementTree.getiterator-usage-to-ElementTree.iter.patch b/debian/patches/Port-ElementTree.getiterator-usage-to-ElementTree.iter.patch
new file mode 100644
index 0000000..934a0ee
--- /dev/null
+++ b/debian/patches/Port-ElementTree.getiterator-usage-to-ElementTree.iter.patch
@@ -0,0 +1,34 @@
+From: Chow Loong Jin <hyperair@debian.org>
+Date: Sun, 11 Apr 2021 15:54:21 +0800
+Subject: Port ElementTree.getiterator() usage to ElementTree.iter()
+
+.getiterator() has been deprecated since python3.2 and has been removed from
+python3.9
+
+Bug-Debian: https://bugs.debian.org/986697
+---
+ qreator_lib/Builder.py | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/qreator_lib/Builder.py b/qreator_lib/Builder.py
+index 996f9ff..23fb2f8 100644
+--- a/qreator_lib/Builder.py
++++ b/qreator_lib/Builder.py
+@@ -83,7 +83,7 @@ class Builder(Gtk.Builder):
+         tree = ElementTree()
+         tree.parse(filename)
+ 
+-        ele_widgets = tree.getiterator("object")
++        ele_widgets = tree.iter("object")
+         for ele_widget in ele_widgets:
+             name = ele_widget.attrib['id']
+             widget = self.get_object(name)
+@@ -105,7 +105,7 @@ class Builder(Gtk.Builder):
+             if connections:
+                 self.connections.extend(connections)
+ 
+-        ele_signals = tree.getiterator("signal")
++        ele_signals = tree.iter("signal")
+         for ele_signal in ele_signals:
+             self.glade_handler_dict.update(
+             {ele_signal.attrib["handler"]: None})
diff --git a/debian/patches/series b/debian/patches/series
index c1fa770..5beadc7 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -5,3 +5,4 @@ Port-to-libnm.patch
 Fix-IndexError-when-a-wifi-network-has-100-strength.patch
 Fix-python-pil-imports.patch
 python3-port.patch
+Port-ElementTree.getiterator-usage-to-ElementTree.iter.patch

Attachment: signature.asc
Description: PGP signature


Reply to: