Bug#990621: unblock: python-duckpy/3.1.0-2
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: nilesh@debian.org, debian-med-packaging@lists.alioth.debian.org
Please unblock package python-duckpy
[ Reason ]
python-duckpy is an unusable package w/o having a Depends on python3-h2
More details with salsa CI links in the corresponding RC bug: #990620 which the latest upload closes
[ Impact ]
The package will be unusable for bullseye users w/o explicitly
installing python3-h2 on their own
[ Tests ]
Non-superficial autopkgtests have been added in the upload, which helped
to uncover the bug in the first place. Both superficial and
non-superficial autopkgtests are green now.
I also did a bit of manual testing -- looks good!
[ Risks ]
This is a leaf package, no risks
[ Checklist ]
[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in testing
unblock python-duckpy/3.1.0-2
-- System Information:
Debian Release: bullseye/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 5.7.0-2-amd64 (SMP w/8 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru python-duckpy-3.1.0/debian/changelog python-duckpy-3.1.0/debian/changelog
--- python-duckpy-3.1.0/debian/changelog 2020-09-29 16:16:00.000000000 +0530
+++ python-duckpy-3.1.0/debian/changelog 2021-07-03 01:37:34.000000000 +0530
@@ -1,3 +1,12 @@
+python-duckpy (3.1.0-2) unstable; urgency=medium
+
+ * Team Upload.
+ * Add autopkgtests
+ * d/examples: Add d/tests/test_duckpy_basic.py as example
+ * d/control: Add Depends on python3-h2 (Closes: #990620)
+
+ -- Nilesh Patra <nilesh@debian.org> Sat, 03 Jul 2021 01:37:34 +0530
+
python-duckpy (3.1.0-1) unstable; urgency=medium
* Team upload.
diff -Nru python-duckpy-3.1.0/debian/control python-duckpy-3.1.0/debian/control
--- python-duckpy-3.1.0/debian/control 2020-09-29 16:16:00.000000000 +0530
+++ python-duckpy-3.1.0/debian/control 2021-07-03 00:55:00.000000000 +0530
@@ -24,7 +24,8 @@
Section: python
Depends: ${misc:Depends},
${python3:Depends},
- python3-bs4
+ python3-bs4,
+ python3-h2
Recommends: ${python3:Recommends}
Suggests: ${python3:Suggests}
Description: simple Python library for searching on DuckDuckGo
diff -Nru python-duckpy-3.1.0/debian/examples python-duckpy-3.1.0/debian/examples
--- python-duckpy-3.1.0/debian/examples 1970-01-01 05:30:00.000000000 +0530
+++ python-duckpy-3.1.0/debian/examples 2021-07-03 00:55:00.000000000 +0530
@@ -0,0 +1 @@
+debian/tests/test_duckpy_basic.py
diff -Nru python-duckpy-3.1.0/debian/tests/control python-duckpy-3.1.0/debian/tests/control
--- python-duckpy-3.1.0/debian/tests/control 1970-01-01 05:30:00.000000000 +0530
+++ python-duckpy-3.1.0/debian/tests/control 2021-07-03 00:54:17.000000000 +0530
@@ -0,0 +1,3 @@
+Tests: run-unit-test
+Depends: @, python3-pytest
+Restrictions: allow-stderr, needs-internet
diff -Nru python-duckpy-3.1.0/debian/tests/run-unit-test python-duckpy-3.1.0/debian/tests/run-unit-test
--- python-duckpy-3.1.0/debian/tests/run-unit-test 1970-01-01 05:30:00.000000000 +0530
+++ python-duckpy-3.1.0/debian/tests/run-unit-test 2021-07-03 00:55:00.000000000 +0530
@@ -0,0 +1,21 @@
+#!/bin/bash
+set -e
+
+pkg='duckpy'
+CUR_DIR=`pwd`
+
+if [ "$AUTOPKGTEST_TMP" = "" ] ; then
+ AUTOPKGTEST_TMP=`mktemp -d /tmp/${pkg}-test.XXXXXX`
+ trap "rm -rf $AUTOPKGTEST_TMP" 0 INT QUIT ABRT PIPE TERM
+fi
+
+cp /usr/share/doc/python3-${pkg}/examples/test_duckpy_basic.py "$AUTOPKGTEST_TMP"
+
+cd $AUTOPKGTEST_TMP
+
+for py in $(py3versions -s 2> /dev/null)
+do
+ echo "Testing with $py in $(pwd):"
+ $py -m pytest -v
+done
+echo "PASS"
diff -Nru python-duckpy-3.1.0/debian/tests/test_duckpy_basic.py python-duckpy-3.1.0/debian/tests/test_duckpy_basic.py
--- python-duckpy-3.1.0/debian/tests/test_duckpy_basic.py 1970-01-01 05:30:00.000000000 +0530
+++ python-duckpy-3.1.0/debian/tests/test_duckpy_basic.py 2021-07-03 00:54:17.000000000 +0530
@@ -0,0 +1,34 @@
+import asyncio
+from duckpy import AsyncClient
+from duckpy import Client
+
+def test_functional():
+ client = Client()
+ results = client.search("Python Wikipedia")
+ # Assert first result title is not empty
+ assert results[0]['title'] != ""
+
+ # Assert first result URL is not empty
+ assert results[0]['url'] != ""
+
+ # Prints first result description
+ assert results[0]['description'] != ""
+
+
+async def get_asyncio_results():
+ client = AsyncClient()
+ results = await client.search("Debian")
+
+ # Assert first result title is not empty
+ assert results[0]['title'] != ""
+
+ # Assert first result URL is not empty
+ assert results[0]['url'] != ""
+
+ # Assert first result description is not empty
+ assert results[0]['description'] != ""
+
+
+def test_asyncio_results():
+ loop = asyncio.get_event_loop()
+ loop.run_until_complete(get_asyncio_results())
Reply to: