Bug#990511: unblock: kodi/2:19.1+dfsg2-2
Hi Sebastian,
One more (technical) thing to mention: the best way to centralize ToLower and ToUpper (omitting collations for now, for that there is a libicu PR for v20 targeting Android) is to declare an overloaded 'StringUtils::ToLower(char c, bool useCLocale)' function and make all Kodi use it. However, there are two instances of StringUtils.h and the second one is part of Kodi API SDK. Fixing Kodi API SDK will be immediately rejected by upstream for v19 because it triggers an API bump and rebuild of all addons (including minimum 12 addons of 49 in Debian during the full freeze!).
Since the workaround does not break movie search / collation / addons, let's follow the upstream path and have it merged. For v20 development cycle, we can either refactor lower/upper/collation things or use libicu to perform similar comparisons.
If you have a better approach to solve this issue, please let me know on https://github.com/xbmc/xbmc/issue/19883
Cheers!--
Vasyl Gello
Certified SolidWorks Expert
Mob.:+380 (98) 465 66 77
E-Mail: vasek.gello@gmail.com
Skype: vasek.gello
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다
Reply to: