[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#988341: unblock: nis/4.3



retitle 988341 unblock: nis/4.4
tags 988341 - moreinfo
thanks

debdiff included


On Tue, May 11, 2021 at 08:42:46PM +0200, Sebastian Ramacher wrote:
On 2021-05-11 10:52:13 +0200, Francesco P. Lovergine wrote:
I found also a pending doc-only change still seating in my repo:

diff --git a/debian/nis.debian.howto b/debian/nis.debian.howto
index e90e549..2641b86 100644
--- a/debian/nis.debian.howto
+++ b/debian/nis.debian.howto
@@ -66,6 +66,13 @@ The NIS how-to on Debian

  2.1 FOR LIBC6:

+     Ensure to have libnss-nis package installed. It is currently
+     only recommended by both libc and ypbind-mt, because it is not an
+     essential component for the system. Even, for your own reasons you
+     could be interested in binding a NIS domain to access the NIS maps via
+     yptools, but not activating it as an account information provider for
+     the system.
+            Check your /etc/nsswitch.conf file and make sure that the
entries for
      passwd, group, shadow and netgroup look like this:

I could add this note to the source-only upload, possibly. Is it ok?

Yes, that's okay and in line with the freeze policy.

Cheers


On Tue, May 11, 2021 at 10:34:32AM +0200, Sebastian Ramacher wrote:
> Control: tags -1 confirmed moreinfo
>
> On 2021-05-10 20:43:26 +0200, Francesco P. Lovergine wrote:
> > Package: release.debian.org
> > Severity: normal
> > User: release.debian.org@packages.debian.org
> > Usertags: unblock
> >
> > Please unblock package nis
> >
> > [ Reason ]
> >
> > Fixes serious bug #988227 (bashism in postinst).
> >
> > [ Impact ]
> >
> > Upgrade not smoothly done from stable.
> >
> > [ Tests ]
> >
> > No autopkg test. Manually tested with dash.
> >
> > [ Risks ]
> >
> > None.
> >
> > [ Checklist ]
> >    [x] all changes are documented in the d/changelog
> >    [x] I reviewed all changes and I approve them
> >    [x] attach debdiff against the package in testing
> >
> > [ Other info ]
> >
> > Native migration package only.
> >
> > unblock nis/4.3
>
> Not built on buildd: arch all binaries uploaded by frankie, a new source-only upload is needed to allow migration
>
> Please perform a source-only upload and remove the moreinfo tag once
> that's done.
>
> Cheers
>
> >
> > --
> > Francesco P. Lovergine
>
> > diff -Nru nis-4.2/debian/changelog nis-4.3/debian/changelog
> > --- nis-4.2/debian/changelog	2021-01-31 10:22:32.000000000 +0100
> > +++ nis-4.3/debian/changelog	2021-05-08 17:19:24.000000000 +0200
> > @@ -1,3 +1,10 @@
> > +nis (4.3) unstable; urgency=medium
> > +
> > +  * Fixed a sort-of bashism in postinst.
> > +    (closes: #988227)
> > +
> > + -- Francesco Paolo Lovergine <frankie@debian.org>  Sat, 08 May 2021 17:19:24 +0200
> > +
> >  nis (4.2) unstable; urgency=medium
> >
> >    * Missed removing of /etc/init.d/nis at upgrade time added.
> > diff -Nru nis-4.2/debian/postinst nis-4.3/debian/postinst
> > --- nis-4.2/debian/postinst	2021-01-31 10:22:32.000000000 +0100
> > +++ nis-4.3/debian/postinst	2021-05-08 17:19:24.000000000 +0200
> > @@ -73,10 +73,13 @@
> >  case "$1" in
> >      configure)
> >          PREV_VER="$2"
> > -		if [ ! -z "$PREV_VER" -a $(dpkg --compare-versions "$PREV_VER" lt '4~'; echo $?) -eq 0 ]
> > -        then
> > -            upgrade_old
> > -        fi
> > +		if [ ! -z "$PREV_VER" ]
> > +		then
> > +			if dpkg --compare-versions "$PREV_VER" lt '4~'
> > +        	then
> > +            	upgrade_old
> > +        	fi
> > +		fi
> >  	  	rm -f /etc/init.d/nis
> >          ;;
> >      *)
>
>
> --
> Sebastian Ramacher



--
Francesco P. Lovergine


--
Sebastian Ramacher



--
Francesco P. Lovergine
diff -Nru nis-4.2/debian/changelog nis-4.4/debian/changelog
--- nis-4.2/debian/changelog	2021-01-31 09:22:32.000000000 +0000
+++ nis-4.4/debian/changelog	2021-05-12 07:00:39.000000000 +0000
@@ -1,3 +1,16 @@
+nis (4.4) unstable; urgency=medium
+
+  * Added a brief note about the recommended libnss-nis package in NIS howto doc.
+
+ -- Francesco Paolo Lovergine <frankie@debian.org>  Wed, 12 May 2021 09:00:39 +0200
+
+nis (4.3) unstable; urgency=medium
+
+  * Fixed a sort-of bashism in postinst.
+    (closes: #988227)
+
+ -- Francesco Paolo Lovergine <frankie@debian.org>  Sat, 08 May 2021 17:19:24 +0200
+
 nis (4.2) unstable; urgency=medium
 
   * Missed removing of /etc/init.d/nis at upgrade time added.
diff -Nru nis-4.2/debian/nis.debian.howto nis-4.4/debian/nis.debian.howto
--- nis-4.2/debian/nis.debian.howto	2021-01-31 09:22:32.000000000 +0000
+++ nis-4.4/debian/nis.debian.howto	2021-05-12 07:00:39.000000000 +0000
@@ -66,6 +66,13 @@
 
   2.1 FOR LIBC6:
 
+     Ensure to have libnss-nis package installed. It is currently
+     only recommended by both libc and ypbind-mt, because it is not an
+     essential component for the system. Even, for your own reasons you
+     could be interested in binding a NIS domain to access the NIS maps via
+     yptools, but not activating it as an account information provider for
+     the system.
+      
       Check your /etc/nsswitch.conf file and make sure that the entries for
       passwd, group, shadow and netgroup look like this:
 
diff -Nru nis-4.2/debian/postinst nis-4.4/debian/postinst
--- nis-4.2/debian/postinst	2021-01-31 09:22:32.000000000 +0000
+++ nis-4.4/debian/postinst	2021-05-12 07:00:39.000000000 +0000
@@ -73,10 +73,13 @@
 case "$1" in
     configure)
         PREV_VER="$2"
-		if [ ! -z "$PREV_VER" -a $(dpkg --compare-versions "$PREV_VER" lt '4~'; echo $?) -eq 0 ]
-        then
-            upgrade_old
-        fi
+		if [ ! -z "$PREV_VER" ]
+		then
+			if dpkg --compare-versions "$PREV_VER" lt '4~'
+        	then
+            	upgrade_old
+        	fi
+		fi
 	  	rm -f /etc/init.d/nis
         ;;
     *)

Reply to: