Bug#988228: unblock: golang-testify/1.6.1-2
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: nilesh@debian.org
Please unblock package golang-testify
[ Reason ]
The build fails on armhf architecture, due to a failing build time test.
This has been fixed in 1.6.1-2
It also fixes the corresponding RC bug: #988101
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=988101
[ Impact ]
The package will fail to build from source on armhf
[ Tests ]
It has non-trivial autopkgtests that cover the testing to the changes.
Autopkgtests pass for golang-testify
It also looks good when I tested it locally
[ Risks ]
No risks, trivial change to make it buildable across armhf.
[ Checklist ]
[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in testing
unblock golang-testify/1.6.1-2
-- System Information:
Debian Release: bullseye/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 5.7.0-2-amd64 (SMP w/8 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru golang-testify-1.6.1/debian/changelog golang-testify-1.6.1/debian/changelog
--- golang-testify-1.6.1/debian/changelog 2020-09-28 04:00:48.000000000 +0000
+++ golang-testify-1.6.1/debian/changelog 2021-05-08 04:25:09.000000000 +0000
@@ -1,3 +1,11 @@
+golang-testify (1.6.1-2) unstable; urgency=medium
+
+ * Team Upload.
+ * d/p/do-not-use-race.patch: Drop -race flag with
+ golang in TestFailfastSuiteFailFastOn (Closes: #988101)
+
+ -- Nilesh Patra <nilesh@debian.org> Sat, 08 May 2021 12:25:09 +0800
+
golang-testify (1.6.1-1) unstable; urgency=medium
* Team upload.
diff -Nru golang-testify-1.6.1/debian/patches/do-not-use-race.patch golang-testify-1.6.1/debian/patches/do-not-use-race.patch
--- golang-testify-1.6.1/debian/patches/do-not-use-race.patch 1970-01-01 00:00:00.000000000 +0000
+++ golang-testify-1.6.1/debian/patches/do-not-use-race.patch 2021-05-08 04:25:09.000000000 +0000
@@ -0,0 +1,19 @@
+Description: The "-race" flag for golang is available only for amd64, arm64, ppc64el. Since this is being used only in a test, it can be dropped
+Author: Nilesh Patra <nilesh@debian.org>
+Bug-Debian: https://bugs.debian.org/988101
+Last-Update: 2021-05-08
+--- a/suite/suite_test.go
++++ b/suite/suite_test.go
+@@ -552,10 +552,10 @@
+ }
+ func TestFailfastSuiteFailFastOn(t *testing.T) {
+ // To test this with failfast on (and isolated from other intended test failures in our test suite) we launch it in its own process
+- cmd := exec.Command("go", "test", "-v", "-race", "-run", "TestFailfastSuite", "-failfast")
++ cmd := exec.Command("go", "test", "-v", "-run", "TestFailfastSuite", "-failfast")
+ var out bytes.Buffer
+ cmd.Stdout = &out
+- t.Log("Running go test -v -race -run TestFailfastSuite -failfast")
++ t.Log("Running go test -v -run TestFailfastSuite -failfast")
+ err := cmd.Run()
+ t.Log(out.String())
+ if err != nil {
diff -Nru golang-testify-1.6.1/debian/patches/series golang-testify-1.6.1/debian/patches/series
--- golang-testify-1.6.1/debian/patches/series 1970-01-01 00:00:00.000000000 +0000
+++ golang-testify-1.6.1/debian/patches/series 2021-05-08 04:25:09.000000000 +0000
@@ -0,0 +1 @@
+do-not-use-race.patch
Reply to: