[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#988185: unblock (pre-approval): gnome-settings-daemon/3.38.2-1



Control: tags -1 confirmed

On 07/05/2021 10:38, Simon McVittie wrote:
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: debian-gtk-gnome@lists.debian.org

I'd like permission to upload a new upstream stable release of
gnome-settings-daemon. We already have most of its changes applied via
debian/patches.

[ Reason ]
* Better compatibility with future kernels
* Replace patch series with upstream release
* Translation update

[ Impact ]
The only code change fixes a bug: the g-s-d currently in bullseye would
report meaningless rfkill events (Bluetooth/WWAN/WLAN/etc. killswitch)
on certain kernel versions due to incorrectly treating /dev/rfkill as a
bytestream. It should have been treating the device as packet-oriented,
one struct per read(), so that the kernel could add extra fields to the
end of the struct and have g-s-d ignore them. Some kernels actually did
expand the struct, but this was reverted because it broke user-space
(both in g-s-d and elsewhere).

Bringing in the new upstream release also drops our patches, making
future updates easier if they are needed, and makes it more obvious what
we're actually shipping.

[ Tests ]
Manual testing only. I use GNOME regularly.

I haven't attempted to find a kernel that would provoke the rfkill bug.

[ Risks ]
This is a key package, but the changes are simple.

[ Checklist ]
   [x] all changes are documented in the d/changelog
   [x] I reviewed all changes and I approve them
   [x] attach diff against the package in testing

[ Other info ]
Because most of the upstream changes were previously in debian/patches,
a debdiff would be misleadingly large. The attached diff is patched tree
in bullseye vs. proposed patched tree, with the content of the removed
patches excluded. I normally upload using dgit, so what I upload and
what's in git are the same.

unblock gnome-settings-daemon/3.38.2-1

Please go ahead.

Emilio


Reply to: