[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#987730: marked as done (unblock: multipath-tools/0.8.5-1)

Your message dated Sat, 1 May 2021 21:28:14 +0200
with message-id <0721f2ab-7ea9-808d-09ba-c71643e24421@debian.org>
and subject line Re: Bug#987730: unblock: multipath-tools/0.8.5-1
has caused the Debian Bug report #987730,
regarding unblock: multipath-tools/0.8.5-1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
987730: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=987730
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package multipath-tools

[ Reason ]
It was discovered that one of the scripts, kpartx/kpartx_id, which
declares posix compatibility has a single line bashism

[ Impact ]
The script fails apart, under the condition where the bashism is used

[ Risks ]
Trivial, one-liner

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

unblock multipath-tools/0.8.5-1

Please give me a Yes, and then I'll do the upload to Debian Unstable.

diff -Nru multipath-tools-0.8.5/debian/changelog multipath-tools-0.8.5/debian/changelog
--- multipath-tools-0.8.5/debian/changelog	2020-12-24 05:23:53.000000000 +0530
+++ multipath-tools-0.8.5/debian/changelog	2021-04-28 22:40:55.000000000 +0530
@@ -1,3 +1,10 @@
+multipath-tools (0.8.5-2) unstable; urgency=medium
+
+  * [373f5c5] Fix bashism in script kpartx/kpartx_id.
+    Thanks to Julien Cristau (Closes: #987669)
+
+ -- Ritesh Raj Sarraf <rrs@debian.org>  Wed, 28 Apr 2021 22:40:55 +0530
+
 multipath-tools (0.8.5-1) unstable; urgency=medium
 
   [ Ritesh Raj Sarraf ]
diff -Nru multipath-tools-0.8.5/debian/patches/0010-Fix-bashism-in-kpartx_id-script.patch multipath-tools-0.8.5/debian/patches/0010-Fix-bashism-in-kpartx_id-script.patch
--- multipath-tools-0.8.5/debian/patches/0010-Fix-bashism-in-kpartx_id-script.patch	1970-01-01 05:30:00.000000000 +0530
+++ multipath-tools-0.8.5/debian/patches/0010-Fix-bashism-in-kpartx_id-script.patch	2021-04-28 22:40:55.000000000 +0530
@@ -0,0 +1,23 @@
+From: Ritesh Raj Sarraf <rrs@debian.org>
+Date: Wed, 28 Apr 2021 22:06:50 +0530
+Subject: Fix bashism in kpartx_id script
+
+Thanks: Julien Cristau
+Closes: #987669
+---
+ kpartx/kpartx_id | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/kpartx/kpartx_id b/kpartx/kpartx_id
+index c45db2f..2b0b1de 100755
+--- a/kpartx/kpartx_id
++++ b/kpartx/kpartx_id
+@@ -93,7 +93,7 @@ if [ -n "$dmdeps" ] ; then
+ else
+     echo "DM_TYPE=raid"
+ fi
+-if [[ $dmserial ]]; then
++if [ -n $dmserial ]; then
+     echo "DM_SERIAL=$dmserial"
+ fi
+ 
diff -Nru multipath-tools-0.8.5/debian/patches/series multipath-tools-0.8.5/debian/patches/series
--- multipath-tools-0.8.5/debian/patches/series	2020-12-24 05:23:53.000000000 +0530
+++ multipath-tools-0.8.5/debian/patches/series	2021-04-28 22:40:55.000000000 +0530
@@ -7,3 +7,4 @@
 0008-Bug-916521-FTCBFS-uses-the-wrong-pkg-config.patch
 0009-kpartx-rules-use-Debian-specific-partx-path.patch
 0010-multipath.rules-do-not-assume-usrmerged-paths.patch
+0010-Fix-bashism-in-kpartx_id-script.patch

--- End Message ---
--- Begin Message --- 
Hi

On 28-04-2021 19:20, Ritesh Raj Sarraf wrote:
> Please unblock package multipath-tools

unblocked

Paul

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


--- End Message ---
Reply to: