Bug#985206: unblock: puppet-module-puppetlabs-rabbitmq/8.5.0-6
Control: tags -1 + moreinfo
On 2021-03-14 12:46:28, Thomas Goirand wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
>
> Please unblock package puppet-module-puppetlabs-rabbitmq
>
> The version while the version 8.5.0-5 works for Bullseye, it introduced a
> regression where it wouldn't work for Buster. Due to the nature of the
> package, it is desirable to have it to work for both Buster and Bullseye,
> especially to make RabbitMQ cluster upgrade from Buster to Bullseye easier.
>
> What happened is that the Rabbitmq-server version detection was broken
> because of a change in the output of "rabbitmqctl -q status". So my first
> approach was to add code like this:
>
> version = output.match(%r{\{rabbit,"RabbitMQ","([\d\.]+)"\}})
> @rabbitmq_version = version[1] if version
> + if @rabbitmq_version == nil
> + version = output.match /RabbitMQ version: ([\d\.]+)/
> + @rabbitmq_version = version[1] if version
> + end
>
> this worked in Bullseye, but broke version detection in Buster. Then I
> decided to simply change the original regular expression instead:
>
> - version = output.match(%r{\{rabbit,"RabbitMQ","([\d\.]+)"\}})
> + version = output.match(%r{(?:\{rabbit,"RabbitMQ","|RabbitMQ version: )([\d\.]+)})
> @rabbitmq_version = version[1] if version
>
> This is what works, and what I would like to see in the Bullseye package,
> that I uploaded in version 8.5.0-6.
>
> Note that the debdiff (which I am not attaching because everything is well
> explained above) also contains a patch refresh (un-fuzz line numbers), due to
> the change of the original patch, but no other change. Let me know if you
> still require a debdiff despite the (IMO) complete explanation above.
Yes, please send the debdiff.
Cheers
>
> So, please unblock puppet-module-puppetlabs-rabbitmq/8.5.0-6 to get the
> correct version detection in.
>
> Cheers,
>
> Thomas Goirand (zigo)
>
--
Sebastian Ramacher
Reply to: