Bug#984595: marked as done (buster-pu: package samba/2:4.9.5+dfsg-5)
Your message dated Sat, 13 Mar 2021 17:12:31 +0000
with message-id <70e3af961623ecd9008e4dd08f6b51d49dee6c1c.camel@adam-barratt.org.uk>
and subject line Re: Bug#984595: buster-pu: package samba/2:4.9.5+dfsg-5
has caused the Debian Bug report #984595,
regarding buster-pu: package samba/2:4.9.5+dfsg-5
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)
--
984595: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=984595
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian.org@packages.debian.org
Usertags: pu
X-Debbugs-Cc: mattia@debian.org, math.parent@gmail.com
Dear colleagues,
Please accept the proposed update of samba in buster / buster-security
after the fix closing #984486 gets merged by Mathieu and uploaded to
stable queue.
[ Reason ]
I encountered the missing header include within libsmbclient-dev
trying to do a no-change rebuild of ffmpeg 4.3.2 for buster-backports.
The problem has been reported to Samba upstream by Gentoo maintainers
two years ago there: https://bugs.gentoo.org/666548 and the only contribution
I made in re this bug is adapting the patch for Debian's samba source tree:
https://salsa.debian.org/samba-team/samba/-/merge_requests/51
[ Impact ]
ffmpeg >= 4.3.1-8 will FTBFS due to re-added libsmbclient build-dependency
[ Tests ]
Build passes, built package from my unofficial Kodi from Debian repo is
tested by me & other (several dozen) users.
[ Risks ]
The risk is low because:
* It is a header-only change
* It has been accepted by upstream 2 years ago
* I confirmed ffmpeg builds fine with modified samba package
* Quite many unofficial repo users
[ Checklist ]
[x] *all* changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in (old)stable
[x] the issue is verified as fixed in unstable
[ Changes ]
One patch added, debian/patches/fix-timeval.patch that includes
<time.h> into source3/include/libsmbclient.h
[ Other info ]
Debdiff will be added after MR gets merged.
--- End Message ---
--- Begin Message ---
On Fri, 2021-03-05 at 18:53 +0100, Sebastian Ramacher wrote:
> On 2021-03-05 16:51:44 +0000, Vasyl Gello wrote:
> > Hi Sebastian!
> >
> > > FWIW, the relevant version for buster-backports is ffmpeg
> > > 7:4.3.2-0+deb11u1 which does not require libsmbclient-dev. So the
> > > bug in
> > > samba does not prevent backports of ffmpeg
> >
> > Strange, I have noticed that 7:4.3.2-0+deb11u1 sits in
> > debian/bullseye branch of ffmpeg, but not in debian/master.
> > What is more strange, 'gbp pull --all' does not populate new
> > branches so there is no way to distinguish from CLI
> > if the new Git branch was cut.
> >
> > Anyway, I think it is nice to have a fixed samba in buster. Or you
> > are not planning to enable smbclient within ffmpeg
> > for bullseye at all?
>
> It's too late to introduce new binary packages in bullseye. The
> changes
> in debian/master are already for bookworm. That's why I have branched
> of
> debian/bullseye before the experimental uploads. smbclient in ffmpeg
> won't happen for bullseye.
That sounds like there's no practical issue with the package in buster,
and therefore no need for an update.
Regards,
Adam
--- End Message ---
Reply to: