[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#985136: marked as done (unblock: gnome-passwordsafe/5.0-2)

Your message dated Sat, 13 Mar 2021 14:31:59 +0000
with message-id <E1lL5J9-0006oV-KD@respighi.debian.org>
and subject line unblock gnome-passwordsafe
has caused the Debian Bug report #985136,
regarding unblock: gnome-passwordsafe/5.0-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
985136: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=985136
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package gnome-passwordsafe

[ Reason ]
Fix a bug that prevents the icon of the application from being displayed
when the software is running in a Wayland session.

[ Impact ]
Wayland won't show the icon of gnome-passwordsafe while it is running
(in the taskbar).

[ Tests ]
This issue is fixed with a one line patch provided by upstream.
Manual tests of the newer version show the bug is fixed.

[ Risks ]
Code change is trivial and very limited. I consider the risk to be low.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

unblock gnome-passwordsafe/5.0-2

diff -Nru gnome-passwordsafe-5.0/debian/changelog gnome-passwordsafe-5.0/debian/changelog
--- gnome-passwordsafe-5.0/debian/changelog	2021-02-07 21:03:23.000000000 +0000
+++ gnome-passwordsafe-5.0/debian/changelog	2021-03-10 16:46:52.000000000 +0000
@@ -1,3 +1,10 @@
+gnome-passwordsafe (5.0-2) unstable; urgency=medium
+
+  * d/patches: add 001_fix-app-name
+    Display the app icon correctly in Wayland environments
+
+ -- Henry-Nicolas Tourneur <debian@nilux.be>  Wed, 10 Mar 2021 16:46:52 +0000
+
 gnome-passwordsafe (5.0-1) unstable; urgency=medium
 
   * New upstream version 5.0
diff -Nru gnome-passwordsafe-5.0/debian/patches/001_fix-app-name.patch gnome-passwordsafe-5.0/debian/patches/001_fix-app-name.patch
--- gnome-passwordsafe-5.0/debian/patches/001_fix-app-name.patch	1970-01-01 00:00:00.000000000 +0000
+++ gnome-passwordsafe-5.0/debian/patches/001_fix-app-name.patch	2021-03-10 16:46:52.000000000 +0000
@@ -0,0 +1,19 @@
+Author: David Heidelberg <david@ixit.cz>
+Forwarded: https://gitlab.gnome.org/World/PasswordSafe/-/merge_requests/487
+Description: set prgname to application_id
+ This fixes issue with the icon inside Wayland environment.
+ Wayland expect that prgname matches application_id, otherwise refuse to
+ show the icon.
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/passwordsafe/application.py
++++ b/passwordsafe/application.py
+@@ -43,7 +43,7 @@ class Application(Gtk.Application):
+     def do_startup(self):  # pylint: disable=arguments-differ
+         Gtk.Application.do_startup(self)
+         GLib.set_application_name('Password Safe')
+-        GLib.set_prgname("Password Safe")
++        GLib.set_prgname(self.application_id)
+ 
+         Handy.init()
+         self.connect("open", self.file_open_handler)
diff -Nru gnome-passwordsafe-5.0/debian/patches/series gnome-passwordsafe-5.0/debian/patches/series
--- gnome-passwordsafe-5.0/debian/patches/series	2021-02-07 21:03:23.000000000 +0000
+++ gnome-passwordsafe-5.0/debian/patches/series	2021-03-10 16:40:16.000000000 +0000
@@ -1 +1,2 @@
+001_fix-app-name.patch
 000_fix-mime-path.patch

--- End Message ---
--- Begin Message --- 
Unblocked gnome-passwordsafe.

--- End Message ---
Reply to: