[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#984635: marked as done (unblock: tqdm/4.57.0-2)

Your message dated Tue, 9 Mar 2021 21:19:15 +0100
with message-id <3d72f61b-7fe6-edc1-7c05-602f040c1a37@debian.org>
and subject line Re: unblock: tqdm/4.57.0-2
has caused the Debian Bug report #984635,
regarding unblock: tqdm/4.57.0-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
984635: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=984635
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package tqdm

[ Reason ]
the last upload of tqdm fixes a RC bug

the effects of that bug are only visible in reverse dependencies, and they were
caused by disabling setuptools_scm during build (as that interferes with our
build process).  That result in a package that would ship a egginfo with version
equals to 0.0.0.

Packages requiring a specific version would fail because that versoin would be
higher that 0.0.0.

the fix was using one of the common practices (documented via a link) of
retrieving the module version from a source file in setup.py, and update the
existing patch for disabling setuptools_scm to include this change.

[ Impact ]
(What is the impact for the user if the unblock isn't granted?)

[ Tests ]
i waited to open this request until all rdeps autopkgtests have completed

[ Risks ]
trivial fix

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing


unblock tqdm/4.57.0-2

-- System Information:
Debian Release: 10.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.6.0-1-amd64 (SMP w/8 CPU threads)
Kernel taint flags: TAINT_WARN
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

diff --git a/debian/changelog b/debian/changelog
index ea9325b..0904f85 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+tqdm (4.57.0-2) unstable; urgency=medium
+
+  * debian/patches/dont-use-setuptools-scm.patch
+    - since we disabled setuptools_scm, we need to explicly retrieve and set
+      tqdm version, so that egginfo has the right version too; Closes: #983007
+
+ -- Sandro Tosi <morph@debian.org>  Fri, 05 Mar 2021 03:57:27 -0500
+
 tqdm (4.57.0-1) unstable; urgency=medium
 
   * New upstream release
diff --git a/debian/patches/dont-use-setuptools-scm.patch b/debian/patches/dont-use-setuptools-scm.patch
index 88aad5f..d34c346 100644
--- a/debian/patches/dont-use-setuptools-scm.patch
+++ b/debian/patches/dont-use-setuptools-scm.patch
@@ -1,11 +1,24 @@
 --- a/setup.py
 +++ b/setup.py
-@@ -13,4 +13,4 @@ if sys.argv[1].lower().strip() == 'make'
+@@ -5,6 +5,12 @@ from os import path
+ 
+ from setuptools import setup
+ 
++
++# https://packaging.python.org/guides/single-sourcing-package-version/
++version = {}
++with open('tqdm/_dist_ver.py') as fp:
++    exec(fp.read(), version)
++
+ src_dir = path.abspath(path.dirname(__file__))
+ if sys.argv[1].lower().strip() == 'make':  # exec Makefile commands
+     import pymake
+@@ -13,4 +19,4 @@ if sys.argv[1].lower().strip() == 'make'
      # Stop to avoid setup.py raising non-standard command error
      sys.exit(0)
  
 -setup(use_scm_version=True)
-+setup()
++setup(version=version['__version__'])
 --- a/setup.cfg
 +++ b/setup.cfg
 @@ -74,7 +74,7 @@ classifiers =

--- End Message ---
--- Begin Message --- 
Hi,

On Fri, 05 Mar 2021 23:42:46 -0500 Sandro Tosi <morph@debian.org> wrote:
> Please unblock package tqdm

unblocked.

Paul

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


--- End Message ---
Reply to: