[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#983628: marked as done (unblock: geeqie/1:1.6-7)

Your message dated Thu, 4 Mar 2021 11:47:15 +0100
with message-id <223c3f45-87a4-b43b-2cbf-f0ee43c8d5a0@debian.org>
and subject line Re: Bug#983628: unblock: geeqie/1:1.6-7
has caused the Debian Bug report #983628,
regarding unblock: geeqie/1:1.6-7
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
983628: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=983628
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package geeqie

This new version fixes a recently discovered regression, in remote
handling in geeqie. It closes #983546 - a regression in the way you
could show an image in an already running geeqie, instead of starting a
new instance of the program. (Without the fix and running remote
geeqie instance it always starts new instances of the program).

Leaf package, small fix, not many alternatives to this particular usage
according to the bug reporter.

(The patch also removes a trailing whitespace in d/changelog, which
itself isn't mentioned in the changelog.)

unblock geeqie/1:1.6-7


-- Andreas Rönnquist
gusnan@debian.org

diff -Nru geeqie-1.6/debian/changelog geeqie-1.6/debian/changelog
--- geeqie-1.6/debian/changelog	2021-01-16 15:05:21.000000000 +0100
+++ geeqie-1.6/debian/changelog	2021-02-27 13:36:57.000000000 +0100
@@ -1,3 +1,10 @@
+geeqie (1:1.6-7) unstable; urgency=medium
+
+  * Add patch fixing regression --remote option failing
+    (Closes: #983546)
+
+ -- Andreas Rönnquist <gusnan@debian.org>  Sat, 27 Feb 2021 13:36:57 +0100
+
 geeqie (1:1.6-6) unstable; urgency=medium
 
   * Add patch to fix which image rotatation-keys affect
@@ -13,7 +20,7 @@
 
 geeqie (1:1.6-4) unstable; urgency=medium
 
-  * Add patch to fix segfault on X with clutter 
+  * Add patch to fix segfault on X with clutter
     (Closes: #979463, #979561, #971403)
 
  -- Andreas Rönnquist <gusnan@debian.org>  Sat, 09 Jan 2021 13:47:51 +0100
diff -Nru geeqie-1.6/debian/patches/0006-Fix-860-871-remote-and-slideshow-on-startup.patch geeqie-1.6/debian/patches/0006-Fix-860-871-remote-and-slideshow-on-startup.patch
--- geeqie-1.6/debian/patches/0006-Fix-860-871-remote-and-slideshow-on-startup.patch	1970-01-01 01:00:00.000000000 +0100
+++ geeqie-1.6/debian/patches/0006-Fix-860-871-remote-and-slideshow-on-startup.patch	2021-02-27 13:30:35.000000000 +0100
@@ -0,0 +1,32 @@
+From: Colin Clark <colin.clark@cclark.uk>
+Date: Sat, 27 Feb 2021 09:12:40 +0000
+Subject: Fix #860, #871: --remote and --slideshow on startup
+
+https://github.com/BestImageViewer/geeqie/issues/860
+https://github.com/BestImageViewer/geeqie/issues/871
+
+Remote slideshow delay is ignored
+
+--remote --File=IMAGE fails: not displaying image, not using running
+instance, not forking
+---
+ src/main.c | 6 ------
+ 1 file changed, 6 deletions(-)
+
+diff --git a/src/main.c b/src/main.c
+index 1356f9a..54c10ea 100644
+--- a/src/main.c
++++ b/src/main.c
+@@ -453,12 +453,6 @@ static void parse_command_line(gint argc, gchar *argv[])
+ 				}
+ 			remote_list = g_list_prepend(remote_list, "--new-window");
+ 			}
+-		else if (!remote_server_exists(app_lock))
+-			{
+-			/* Geeqie started for first time but with --remote option
+-			 */
+-			remote_do = FALSE;
+-			}
+ 		g_free(app_lock);
+ 		}
+ 
diff -Nru geeqie-1.6/debian/patches/series geeqie-1.6/debian/patches/series
--- geeqie-1.6/debian/patches/series	2021-01-16 15:04:01.000000000 +0100
+++ geeqie-1.6/debian/patches/series	2021-02-27 13:30:35.000000000 +0100
@@ -3,3 +3,4 @@
 0003-Fix-832-Geeqie-remembers-desktop.patch
 0004-Fix-829-segfault-with-clutter-gtk.patch
 0005-Fix-822-The-image-rotation-keys-and-affect-the-wrong.patch
+0006-Fix-860-871-remote-and-slideshow-on-startup.patch

--- End Message ---
--- Begin Message --- 
Hi Andreas,

On 27-02-2021 14:49, Andreas Ronnquist wrote:
> Please unblock package geeqie

Assuming that no issues pop up, the package will migrate before the hard
freeze, so nothing actionable for us here.

Closing.

Paul

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


--- End Message ---
Reply to: