[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1002051: bullseye-pu: package heartbeat/1:3.0.6-11+deb11u1



Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian.org@packages.debian.org
Usertags: pu

[ Reason ]
heartbeat deamon starts correctly after installation, but not
after reboot because of missing /run/heartbeat directories.
The change reintroduces a tempfiles configuration for creating
the required directories on boot.

[ Impact ]
heartbeat fails to start correctly until the required directories
in /run are created.

[ Tests ]
Manually tested by checking the service starts correctly after
a reboot.

[ Risks ]
The change is simple and has already been released to unstable
in #993575 and tested by users.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

[ Changes ]
Change removes creating /run directories in postinst, since
this masks the problem until reboot. Instead a tempfiles
configuration is included for creating the required directories.

[ Other info ]
The bug only affects systemd installations since the init script
recreates the required directories on every start.


diff -Nru heartbeat-3.0.6/debian/changelog heartbeat-3.0.6/debian/changelog
--- heartbeat-3.0.6/debian/changelog	2021-01-20 21:59:42.000000000 +0100
+++ heartbeat-3.0.6/debian/changelog	2021-12-20 23:51:42.000000000 +0100
@@ -1,3 +1,9 @@
+heartbeat (1:3.0.6-11+deb11u1) bullseye; urgency=medium
+
+  * Use tmpfiles.d to create /run/heartbeat (Closes: #1002037)
+
+ -- Valentin Vidic <vvidic@debian.org>  Mon, 20 Dec 2021 23:51:42 +0100
+
 heartbeat (1:3.0.6-11) unstable; urgency=medium
 
   [ Debian Janitor ]
diff -Nru heartbeat-3.0.6/debian/heartbeat.postinst heartbeat-3.0.6/debian/heartbeat.postinst
--- heartbeat-3.0.6/debian/heartbeat.postinst	2018-12-09 14:58:48.000000000 +0100
+++ heartbeat-3.0.6/debian/heartbeat.postinst	2021-12-20 23:50:08.000000000 +0100
@@ -33,7 +33,6 @@
 	fi
 
 	for i in /var/lib/heartbeat/ccm /var/lib/heartbeat/crm \
-			/run/heartbeat/ccm /run/heartbeat/crm \
 			/var/lib/heartbeat/pengine; do
 		mkdir -p $i
 		chmod 750 $i
@@ -41,10 +40,6 @@
 		chgrp haclient $i
 	done
 
-	# prepare agent state dir
-	mkdir -p /run/resource-agents
-	chmod 755 /run/resource-agents
-
 	chgrp haclient /usr/bin/cl_status
 	chmod 2555 /usr/bin/cl_status
 
diff -Nru heartbeat-3.0.6/debian/rules heartbeat-3.0.6/debian/rules
--- heartbeat-3.0.6/debian/rules	2020-08-22 23:04:27.000000000 +0200
+++ heartbeat-3.0.6/debian/rules	2021-12-20 23:50:08.000000000 +0100
@@ -103,7 +103,7 @@
 
 	# move sysv init script and systemd service file to expected locations for dh_install
 	! test -e ./debian/tmp/usr/lib/tmpfiles.d/heartbeat.conf || \
-	mv ./debian/tmp/usr/lib/tmpfiles.d/heartbeat.conf ./debian/heartbeat.tmpfile
+	mv ./debian/tmp/usr/lib/tmpfiles.d/heartbeat.conf ./debian/heartbeat.tmpfiles
 	! test -e ./debian/tmp/lib/systemd/system/heartbeat.service || \
 	mv ./debian/tmp/lib/systemd/system/heartbeat.service ./debian/heartbeat.service
 	! test -e ./debian/tmp/etc/init.d/heartbeat || \
@@ -129,6 +129,7 @@
 	dh_installexamples -a
 	dh_installinit -a -n -u 'defaults 20 32'
 	dh_installsystemd -a
+	dh_installtmpfiles -a
 	dh_installman -a
 	dh_installchangelogs -a `pwd`/doc/ChangeLog
 	dh_installlogcheck -a


Reply to: