Bug#1000454: bullseye-pu: package gdal/3.2.2+dfsg-2+deb11u1

["Adam D. Barratt" <adam@adam-barratt.org.uk>]

Control: tags -1 + confirmed

On Fri, 2021-12-03 at 17:28 +0100, Sebastiaan Couwenberg wrote:
> Control: tags -1 - moreinfo
> 
> On 12/3/21 17:16, Adam D. Barratt wrote:
[...]
> > diff -Nru gdal-3.2.2+dfsg/debian/patches/0001-Add-a-cppcheck_2004-
> > CI-target-and-fix-related-issues.patch gdal-
> > 3.2.2+dfsg/debian/patches/0001-Add-a-cppcheck_2004-CI-target-and-
> > fix-related-issues.patch
> > --- gdal-3.2.2+dfsg/debian/patches/0001-Add-a-cppcheck_2004-CI-
> > target-and-fix-related-issues.patch      1970-01-01
> > 01:00:00.000000000 +0100
> > +++ gdal-3.2.2+dfsg/debian/patches/0001-Add-a-cppcheck_2004-CI-
> > target-and-fix-related-issues.patch      2021-11-23
> > 10:11:54.000000000 +0100
> > @@ -0,0 +1,170 @@
> > +Description: Add a cppcheck_2004 CI target, and fix related issues
> > +Author: Even Rouault <even.rouault@spatialys.com>
> > +Origin: 
> > https://github.com/OSGeo/gdal/commit/6ff924dfc704776cbdeff1e0e23da6452cf06933
> > +Bug: https://github.com/OSGeo/gdal/pull/3516
> > +
> > +--- a/ogr/ogrsf_frmts/lvbag/ogrlvbaglayer.cpp
> > ++++ b/ogr/ogrsf_frmts/lvbag/ogrlvbaglayer.cpp
> > 
> > This is a little confusing. The upstream commit in question touches
> > 24
> > files, but this patch only changes one. Is that intentional? If so,
> > the
> > patch header could do with some more information, because it
> > doesn't
> > appear that the patch actually includes the change mentioned in the
> > description.
> 
> The description comes from the commit message.
> 

I fully understand that, but given my observation, and your
confirmation, that:

> The patch only includes the cppcheck fixes for the LVBAG driver.
> 

continuing to use that description with no further comment on the fact
that you've only included a small portion of the upstream patch - and
specifically *not* included any part that actually corresponds to the
description - is at best confusing for a reviewer, and quite possibly
for yourself or another maintainer in the future.

Please go ahead, in any case.

Regards,

Adam