Package: release.debian.org Severity: normal Tags: bullseye User: release.debian.org@packages.debian.org Usertags: pu X-Debbugs-Cc: pollo@debian.org [ Reason ] #990148: We are patching the upstream code to use Debian's version of jquery, but it wasn't done properly. Instead of trying to load the file directly from /usr/share/javascript, it should be symlinked in the package's /static directory, like the other JS libs. #990152: We're not symlinking the right bootstrap files. Supysonic wants .min.css files and we're symlinking the non-minimized files. This is not a regression, since it's the first stable release for this package. [ Impact ] These bugs badly break the web interface and severely reduce the usability of the package. [ Tests ] I run this package on a server that's on Bullseye. I've tested the update on this server and it does fix the issues. [ Risks ] The changes are trivial and should bear very low risks. [ Checklist ] [x] *all* changes are documented in the d/changelog [x] I reviewed all changes and I approve them [x] attach debdiff against the package in stable [x] the issue is verified as fixed in unstable [ Changes ] #990148: * symlinking jquery to /usr/share/supysonic/supysonic/ * using that version in supysonic/supysonic/templates/layout.html #990152: * symlinking bootstrap-theme.min.css and bootstrap.min.css instead of the non minimized versions. -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ Louis-Philippe Véronneau ⢿⡄⠘⠷⠚⠋ pollo@debian.org / veronneau.org ⠈⠳⣄
diff -Nru supysonic-0.6.2+ds/debian/changelog supysonic-0.6.2+ds/debian/changelog
--- supysonic-0.6.2+ds/debian/changelog 2021-04-21 11:33:30.000000000 -0400
+++ supysonic-0.6.2+ds/debian/changelog 2021-11-21 23:45:53.000000000 -0500
@@ -1,3 +1,11 @@
+supysonic (0.6.2+ds-3+deb11u1) bullseye; urgency=medium
+
+ * d/patches, d/links: Symlink jquery instead of loading it directly.
+ Closes: #990148.
+ * d/links: Use the minimized bootstrap CSS files. Closes: #990152.
+
+ -- Louis-Philippe Véronneau <pollo@debian.org> Sun, 21 Nov 2021 23:45:53 -0500
+
supysonic (0.6.2+ds-3) unstable; urgency=medium
* d/tests/control: use sqlite3 instead of sqlite.
diff -Nru supysonic-0.6.2+ds/debian/patches/0004_Embedded_JS_Libs.patch supysonic-0.6.2+ds/debian/patches/0004_Embedded_JS_Libs.patch
--- supysonic-0.6.2+ds/debian/patches/0004_Embedded_JS_Libs.patch 2020-09-27 20:22:48.000000000 -0400
+++ supysonic-0.6.2+ds/debian/patches/0004_Embedded_JS_Libs.patch 2021-11-21 23:45:53.000000000 -0500
@@ -8,7 +8,7 @@
<!-- jQuery (necessary for Bootstrap's JavaScript plugins) -->
- <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.12.4/jquery.min.js";></script>
-+ <script src="/usr/share/javascript/jquery/jquery.min.js"></script>
++ <script src="{{ url_for('static', filename='js/jquery.min.js') }}"></script>
<!-- Include all compiled plugins (below), or include individual files as needed -->
<script src="{{ url_for('static', filename='js/bootstrap.min.js') }}"></script>
<!-- Activate tooltips -->
diff -Nru supysonic-0.6.2+ds/debian/supysonic.links supysonic-0.6.2+ds/debian/supysonic.links
--- supysonic-0.6.2+ds/debian/supysonic.links 2020-09-27 20:22:48.000000000 -0400
+++ supysonic-0.6.2+ds/debian/supysonic.links 2021-11-21 23:45:53.000000000 -0500
@@ -1,10 +1,11 @@
/usr/share/supysonic/supysonic-cli /usr/bin/supysonic-cli
/usr/share/supysonic/supysonic-daemon /usr/bin/supysonic-daemon
-/usr/share/javascript/bootstrap/css/bootstrap.css /usr/share/supysonic/supysonic/static/css/bootstrap.css
+/usr/share/javascript/bootstrap/css/bootstrap.min.css /usr/share/supysonic/supysonic/static/css/bootstrap.min.css
/usr/share/javascript/bootstrap/css/bootstrap.css.map /usr/share/supysonic/supysonic/static/css/bootstrap.css.map
-/usr/share/javascript/bootstrap/css/bootstrap-theme.css /usr/share/supysonic/supysonic/static/css/bootstrap-theme.css
+/usr/share/javascript/bootstrap/css/bootstrap-theme.min.css /usr/share/supysonic/supysonic/static/css/bootstrap-theme.min.css
/usr/share/javascript/bootstrap/css/bootstrap-theme.css.map /usr/share/supysonic/supysonic/static/css/bootstrap-theme.css.map
/usr/share/javascript/bootstrap/js/bootstrap.min.js /usr/share/supysonic/supysonic/static/js/bootstrap.min.js
+/usr/share/javascript/jquery/jquery.min.js /usr/share/supysonic/supysonic/static/js/jquery.min.js
/usr/share/fonts-glyphicons/glyphicons-halflings-regular.eot /usr/share/supysonic/supysonic/static/fonts/glyphicons-halflings-regular.eot
/usr/share/fonts-glyphicons/glyphicons-halflings-regular.svg /usr/share/supysonic/supysonic/static/fonts/glyphicons-halflings-regular.svg
/usr/share/fonts-glyphicons/glyphicons-halflings-regular.ttf /usr/share/supysonic/supysonic/static/fonts/glyphicons-halflings-regular.ttf
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature