[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#996728: bullseye-pu: package mrtg/2.17.7-2+deb11u1



Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian.org@packages.debian.org
Usertags: pu

[ Reason ]
This update is not for a regression. I am the new maintainer of the mrtg. When
checking for spelling errors, I found two spelling errors in variables names in
the source code. These errors generated the bugs #995950 and #996090.

[ Impact ]
These spelling errors will break the program in some circumstances.

[ Tests ]
No tests were needed. It is a simple fix to follow the right names already in
source code. The upstream already approved and committed these fixes.

[ Risks ]
No risks, a trivial fix only.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

[ Changes ]
Single fixes in variables names in source code.

[ Other info ]
No more info. Thanks.
diff -Nru mrtg-2.17.7/debian/changelog mrtg-2.17.7/debian/changelog
--- mrtg-2.17.7/debian/changelog	2021-01-01 01:23:44.000000000 -0300
+++ mrtg-2.17.7/debian/changelog	2021-10-17 15:50:42.000000000 -0300
@@ -1,3 +1,12 @@
+mrtg (2.17.7-2+deb11u1) bullseye; urgency=medium
+
+  * debian/patches/: created two patches to fix spelling errors in source code.
+    These spelling errors will break the program in some circumstances.
+      - deb11-01-fix-variable-name-cfgmaker.patch (Closes: #995950)
+      - deb11-02-fix-variable-name-MRTG_lib.patch (Closes: #996090)
+
+ -- Joao Eriberto Mota Filho <eriberto@debian.org>  Sun, 17 Oct 2021 15:50:42 -0300
+
 mrtg (2.17.7-2) unstable; urgency=medium
 
   [ Debian Janitor ]
diff -Nru mrtg-2.17.7/debian/patches/deb11-01-fix-variable-name-cfgmaker.patch mrtg-2.17.7/debian/patches/deb11-01-fix-variable-name-cfgmaker.patch
--- mrtg-2.17.7/debian/patches/deb11-01-fix-variable-name-cfgmaker.patch	1969-12-31 21:00:00.000000000 -0300
+++ mrtg-2.17.7/debian/patches/deb11-01-fix-variable-name-cfgmaker.patch	2021-10-17 15:50:42.000000000 -0300
@@ -0,0 +1,18 @@
+Description: fix an important spelling error in source code
+Author: Joao Eriberto Mota Filho <eriberto@debian.org>
+Bug-Debian: https://bugs.debian.org/995950
+Forwarded: https://github.com/oetiker/mrtg/pull/35
+Last-Update: 2021-10-17
+Index: mrtg-2.17.7/bin/cfgmaker
+===================================================================
+--- mrtg-2.17.7.orig/bin/cfgmaker
++++ mrtg-2.17.7/bin/cfgmaker
+@@ -956,7 +956,7 @@ sub DeviceInfo ($$$) {
+     my @variables = snmpwalk(v4onlyifnecessary($router, $ipv4only),$v3opt,'1.3.6.1.2.1.1'); # walk system
+     if (!(defined $variables[0])) {
+         # Do we need to fall back to IPv4?
+-        my ($commmunity, $host) = ($1, $2) if ($router =~ /^(.*)@([^@]+)$/);
++        my ($community, $host) = ($1, $2) if ($router =~ /^(.*)@([^@]+)$/);
+         if ( ( ! $ipv4only ) && ( $host !~ /^\[(.*)\]/) ) {
+             # Not using IPv4, not an IPv6 address, so a hostname
+             debug ('base',"No response using IPv6 for $router, trying again using IPv4");
diff -Nru mrtg-2.17.7/debian/patches/deb11-02-fix-variable-name-MRTG_lib.patch mrtg-2.17.7/debian/patches/deb11-02-fix-variable-name-MRTG_lib.patch
--- mrtg-2.17.7/debian/patches/deb11-02-fix-variable-name-MRTG_lib.patch	1969-12-31 21:00:00.000000000 -0300
+++ mrtg-2.17.7/debian/patches/deb11-02-fix-variable-name-MRTG_lib.patch	2021-10-17 15:50:42.000000000 -0300
@@ -0,0 +1,18 @@
+Description: fix an important mistake in variable name
+Author: Joao Eriberto Mota Filho <eriberto@debian.org>
+Bug-Debian: https://bugs.debian.org/996090
+Forwarded: https://github.com/oetiker/mrtg/pull/50
+Last-Update: 2021-10-17
+Index: mrtg-2.17.7/lib/mrtg2/MRTG_lib.pm
+===================================================================
+--- mrtg-2.17.7.orig/lib/mrtg2/MRTG_lib.pm
++++ mrtg-2.17.7/lib/mrtg2/MRTG_lib.pm
+@@ -1798,7 +1798,7 @@ sub populateconfcache ($$$$$) {
+      push @{$$confcache{___updated}}, $hostkey;
+ 
+     $SNMP_Session::suppress_warnings = $snmp_errlevel;    
+-    $Net_SNMP_util::supress_warnings = $net_snmp_errlevel;
++    $Net_SNMP_util::suppress_warnings = $net_snmp_errlevel;
+ }
+ 
+ sub log2rrd ($$$) {
diff -Nru mrtg-2.17.7/debian/patches/series mrtg-2.17.7/debian/patches/series
--- mrtg-2.17.7/debian/patches/series	2021-01-01 01:23:44.000000000 -0300
+++ mrtg-2.17.7/debian/patches/series	2021-10-17 15:50:42.000000000 -0300
@@ -6,3 +6,5 @@
 dont_create_varlockmrtg.patch
 cfgmaker_debian_workdir.patch
 iptables-accounting_linewrap.patch
+deb11-01-fix-variable-name-cfgmaker.patch
+deb11-02-fix-variable-name-MRTG_lib.patch

Reply to: