[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#994023: marked as done (buster-pu: package espeak-ng/1.49.2+dfsg-8+deb10u1)

Your message dated Sat, 09 Oct 2021 12:11:43 +0100
with message-id <896b7609401ceb0e1c537222e26587ea2351415d.camel@adam-barratt.org.uk>
and subject line Closing bugs for fixes included in the 10.11 point release
has caused the Debian Bug report #994023,
regarding buster-pu: package espeak-ng/1.49.2+dfsg-8+deb10u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
994023: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=994023
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian.org@packages.debian.org
Usertags: pu

Hello,

This is actually like #971944, but for espeak-ng (which is a newer
version of espeak that will eventually supersede it). Normally I
would have submitted them at the same time but it seems I missed doing
it.

[ Reason ]
Espeak-ng cannot drive the mbrola-fr4 speech synthesis voice if the
mbrola-fr1 package is not installed. This is because some of the mb-fr4
espeak rules refer to the fr1 voice while they should be referring to
the fr4 voice. This was fixed some time ago in the newer espeak-ng
package, but the fix was not backported yet to buster.

[ Impact ]
This was not a regression over previous distributions, but it's hard for
users to guess that espeak+mbrola-fr4 cannot work without the mbrola-fr1
package, I actually got hit by the issue in october 2020 and it took
me some time to realize the problem, even though I'm maintaining the
packages.

[ Tests ]
After installing speech-dispatcher, espeak-ng, and mbrola-fr4, but not
mbrola-fr1,

spd-say -O espeak-ng-mbrola-generic Bonjour

should be speaking "Bonjour"

I have just tested it in a buster chroot.

[ Risks ]
The change is trivial, as attached. It is already tested as working in
unstable and stable.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
They simply fix the fr1 reference into fr4.

Yes, the remaining reference to fr1_phtrans is on purpose, it is part of
the confusion between mbrola-fr1 and mbrola-fr4: fr1_phtrans is provided
by espeak-ng-data for both mbrola-fr1 and mbrola-fr4, it was actually
renamed to fr_phtrans in latest espeak-ng-data.

diff -Nru espeak-ng-1.49.2+dfsg/debian/changelog espeak-ng-1.49.2+dfsg/debian/changelog
--- espeak-ng-1.49.2+dfsg/debian/changelog	2018-11-14 00:01:43.000000000 +0100
+++ espeak-ng-1.49.2+dfsg/debian/changelog	2021-09-10 01:34:50.000000000 +0200
@@ -1,3 +1,10 @@
+espeak-ng (1.49.2+dfsg-8+deb10u1) buster; urgency=medium
+
+  * patches/mbrola-fr4: Fix using espeak with mbrola-fr4 when mbrola-fr1 is
+    not installed.
+
+ -- Samuel Thibault <sthibault@debian.org>  Fri, 10 Sep 2021 01:34:50 +0200
+
 espeak-ng (1.49.2+dfsg-8) unstable; urgency=medium
 
   * patches/fix-cancel: Do not open audio when audio speak mode is not
diff -Nru espeak-ng-1.49.2+dfsg/debian/patches/mbrola-fr4 espeak-ng-1.49.2+dfsg/debian/patches/mbrola-fr4
--- espeak-ng-1.49.2+dfsg/debian/patches/mbrola-fr4	1970-01-01 01:00:00.000000000 +0100
+++ espeak-ng-1.49.2+dfsg/debian/patches/mbrola-fr4	2021-09-10 01:34:34.000000000 +0200
@@ -0,0 +1,22 @@
+diff --git a/espeak-ng-data/voices/mb/mb-fr4 b/espeak-ng-data/voices/mb/mb-fr4
+index 8e3c392..6e459cc 100755
+--- a/espeak-ng-data/voices/mb/mb-fr4
++++ b/espeak-ng-data/voices/mb/mb-fr4
+@@ -5,5 +5,5 @@ gender female
+ dictrules 1
+ pitch 140 220
+ voicing 90
+-mbrola fr1 fr1_phtrans
++mbrola fr4 fr1_phtrans
+ 
+diff --git a/espeak-ng-data/voices/mb/mb-fr4-en b/espeak-ng-data/voices/mb/mb-fr4-en
+index 8126770..33817e5 100755
+--- a/espeak-ng-data/voices/mb/mb-fr4-en
++++ b/espeak-ng-data/voices/mb/mb-fr4-en
+@@ -5,5 +5,5 @@ gender female
+ dictrules 1
+ pitch 140 220
+ voicing 90
+-mbrola fr1 fr1_phtrans
++mbrola fr4 fr1_phtrans
+ 
diff -Nru espeak-ng-1.49.2+dfsg/debian/patches/series espeak-ng-1.49.2+dfsg/debian/patches/series
--- espeak-ng-1.49.2+dfsg/debian/patches/series	2018-11-13 01:17:49.000000000 +0100
+++ espeak-ng-1.49.2+dfsg/debian/patches/series	2021-09-10 01:34:34.000000000 +0200
@@ -6,3 +6,4 @@
 privacy
 lessgreat-punct
 nocancel
+mbrola-fr4

--- End Message ---
--- Begin Message --- 
Package: release.debian.org
Version: 10.11

Hi,

The updates relating to these bugs were included in this morning's
10.11 point release for buster.

Regards,

Adam

--- End Message ---
Reply to: