[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#992836: marked as done (bullseye-pu: package termshark/2.2.0-1+deb11u1)

Your message dated Sat, 09 Oct 2021 12:09:40 +0100
with message-id <81741a2f4e370c14a3bec08b7fe6e2b10c32267b.camel@adam-barratt.org.uk>
and subject line Closing p-u bugs for updates in 11.1
has caused the Debian Bug report #992836,
regarding bullseye-pu: package termshark/2.2.0-1+deb11u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
992836: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=992836
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian.org@packages.debian.org
Usertags: pu
X-Debbugs-Cc: ssgelm@debian.org

[ Reason ]
Themes were inadvertently not built into the termshark package, causing
the UI to fail to render. This was reported upstream at
https://github.com/gcla/termshark/issues/114, then reported to Debian in
#992831. This is a regression, and also makes the package generally
unusable.

[ Impact ]
If this update isn't approved the user will have to follow the
workaround provided by the author at
https://github.com/gcla/termshark/issues/114#issuecomment-904273172
While not a deal-breaker it requires a non-zero amount of effort by the
end user.

[ Tests ]
Due to the nature of the bug (display issue) it is hard to test using
automated tests (which, of course, is how it was missed). Realistically
the best way to test it is by running the termshark command after
installing the package.

[ Risks ]
The only change is to the build flags, so I feel the risk is low.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in stable
  [x] the issue is verified as fixed in unstable

[ Changes ]
The only change is including the "assets/themes" directory in the build
process.

[ Other info ]
This is fixed in 2.2.0-2 which has been uploaded to unstable.

diff -Nru termshark-2.2.0/debian/changelog termshark-2.2.0/debian/changelog
--- termshark-2.2.0/debian/changelog	2021-01-10 03:44:34.000000000 -0600
+++ termshark-2.2.0/debian/changelog	2021-08-23 22:55:12.000000000 -0500
@@ -1,3 +1,10 @@
+termshark (2.2.0-1+deb11u1) bullseye; urgency=medium
+
+  * Team upload
+  * Include themes in package (Closes: #992831)
+
+ -- Stephen Gelman <ssgelm@debian.org>  Mon, 23 Aug 2021 22:55:12 -0500
+
 termshark (2.2.0-1) unstable; urgency=medium
 
   * Team upload
diff -Nru termshark-2.2.0/debian/rules termshark-2.2.0/debian/rules
--- termshark-2.2.0/debian/rules	2021-01-10 03:44:34.000000000 -0600
+++ termshark-2.2.0/debian/rules	2021-08-23 22:54:41.000000000 -0500
@@ -1,6 +1,7 @@
 #!/usr/bin/make -f
 
 export DH_GOLANG_GO_GENERATE := 1
+export DH_GOLANG_INSTALL_EXTRA := assets/themes
 
 include /usr/share/dpkg/pkg-info.mk

--- End Message ---
--- Begin Message --- 
Package: release.debian.org
Version: 11.1

Hi,

The updates relating to these bugs were included in this morning's 11.1
point release for bullseye.

Regards,

Adam

--- End Message ---
Reply to: