Package: release.debian.org
User: release.debian.org@packages.debian.org
Usertags: pu
Tags: bullseye
X-Debbugs-Cc: byang@debian.org
Severity: normal
Dear Debian Release Team,
I am proposing a bullseye-pu upload to fix Debian bug
https://bugs.debian.org/994144 .
[ Reason ]
In current version of libavif-dev/0.8.4-2 (shipped in Debian 11), the
/usr/lib/<triplet>/pkgconfig/libavif.pc file has the following content:
========================
prefix=/usr
exec_prefix=${prefix}/bin
libdir=${prefix}/lib
includedir=${prefix}/include
Name: libavif
Description: Library for encoding and decoding .avif files
Version: 0.8.4
Libs: -L${libdir} -lavif
Cflags: -I${includedir}
========================
...where libdir should be ${prefix}/@CMAKE_INSTALL_LIBDIR@
(@CMAKE_INSTALL_LIBDIR@ will be replaced by arch triplet during compilation).
This will make packages that build-depend on libavif-dev to receive wrong -
L{libdir} parameter during compilation, and may incur FTBFS.
Libavif fixed this issue in v0.9.2 release. I am looking to backport this
certain patch
https://github.com/AOMediaCodec/libavif/commit/c6acdf6b7c69c9d23917cf814a3b17ce639a7266
into libavif in Debian 11.
[ Impact ]
Users that uses on libavif library through pkg-config in Debian 11 may fail to
build from source due to wrong compilation parameters.
[ Tests ]
Manually tested by myself.
[ Risks ]
Minimal. The patch is already present in latest upstream release (v0.9.2) as
well as libavif in Debian Testing / Debian Unstable.
[ Checklist ]
[X] *all* changes are documented in the d/changelog
[X] I reviewed all changes and I approve them
[X] attach debdiff against the package in (old)stable
[X] the issue is verified as fixed in unstable
[ Changes ]
Upstream fix can be found as
https://github.com/AOMediaCodec/libavif/commit/c6acdf6b7c69c9d23917cf814a3b17ce639a7266.patch
.
[ Other info ]
Full debdiff provided in attachment.
diff -Nru libavif-0.8.4/debian/changelog libavif-0.8.4/debian/changelog
--- libavif-0.8.4/debian/changelog 2020-12-07 13:52:51.000000000 -0500
+++ libavif-0.8.4/debian/changelog 2021-09-12 15:54:48.000000000 -0400
@@ -1,3 +1,11 @@
+libavif (0.8.4-2+deb11u1) bullseye; urgency=medium
+
+ * debian/patches/c6acdf6b7c69c9d23917cf814a3b17ce639a7266.patch:
+ Add upstream fix to correct libdir in libavif.pc pkgconfig file.
+ (Closes: #994144)
+
+ -- Boyuan Yang <byang@debian.org> Sun, 12 Sep 2021 15:54:48 -0400
+
libavif (0.8.4-2) unstable; urgency=medium
* Source-only upload.
diff -Nru libavif-0.8.4/debian/patches/c6acdf6b7c69c9d23917cf814a3b17ce639a7266.patch libavif-0.8.4/debian/patches/c6acdf6b7c69c9d23917cf814a3b17ce639a7266.patch
--- libavif-0.8.4/debian/patches/c6acdf6b7c69c9d23917cf814a3b17ce639a7266.patch 1969-12-31 19:00:00.000000000 -0500
+++ libavif-0.8.4/debian/patches/c6acdf6b7c69c9d23917cf814a3b17ce639a7266.patch 2021-09-12 15:39:30.000000000 -0400
@@ -0,0 +1,23 @@
+From c6acdf6b7c69c9d23917cf814a3b17ce639a7266 Mon Sep 17 00:00:00 2001
+From: Mike Frysinger <vapier@gentoo.org>
+Date: Thu, 4 Mar 2021 21:20:33 -0500
+Subject: [PATCH] libavif.pc: respect libdir setting
+
+Do not hardcode "lib" as that is often the wrong path with multilib.
+On an x86_64 system for example, it should actually be "lib64".
+---
+ libavif.pc.cmake | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/libavif.pc.cmake b/libavif.pc.cmake
+index 006539b1..4ef2c8a9 100644
+--- a/libavif.pc.cmake
++++ b/libavif.pc.cmake
+@@ -1,6 +1,6 @@
+ prefix=@CMAKE_INSTALL_PREFIX@
+ exec_prefix=${prefix}/bin
+-libdir=${prefix}/lib
++libdir=${prefix}/@CMAKE_INSTALL_LIBDIR@
+ includedir=${prefix}/include
+
+ Name: @PROJECT_NAME@
diff -Nru libavif-0.8.4/debian/patches/series libavif-0.8.4/debian/patches/series
--- libavif-0.8.4/debian/patches/series 2020-11-10 10:09:03.000000000 -0500
+++ libavif-0.8.4/debian/patches/series 2021-09-12 15:39:39.000000000 -0400
@@ -1 +1,2 @@
0001-Use-system-cJSON-library.patch
+c6acdf6b7c69c9d23917cf814a3b17ce639a7266.patch
Attachment:
signature.asc
Description: This is a digitally signed message part