[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#991481: marked as done (unblock: openntpd/1:6.2p3-4.2)

Your message dated Sat, 31 Jul 2021 15:30:13 +0000
with message-id <E1m9qwH-0007TD-H7@respighi.debian.org>
and subject line unblock openntpd
has caused the Debian Bug report #991481,
regarding unblock: openntpd/1:6.2p3-4.2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
991481: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=991481
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Dear release team, this is a request for pre-approval of an openntpd
upload.

[ Reason ]

Openntpd makes networking configuration fail when running its if-up
hook.

https://bugs.debian.org/987321

The upload would fix this issue by checking if openntpd is running
before restarting it. Openntpd depending on systemd network target, it
would be skipped on boot but correctly executed on ifdown/ifup.

[ Impact ]

High: this bug is effectively holding the boot sequence to the
networking service timeout (5 minutes) and preventing any interfaces
after the first one to be configured.

[ Tests ]

Autopkgtest is superficial.

I've manually tested the fix in both systemd and sysv setup. I've
validated that the patch fixes the booting issue and that openntpd
restart on interface reconfiguration (if already started).

[ Risks ]

Low: the changeset is quite small and self-contained. This is a non-key
leaf package. It has a popcorn of ~1350.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]

This is an NMU. On approval, I'll upload with DELAY/0.

unblock openntpd/1:6.2p3-4.2

-- 
Baptiste Beauplat - lyknode

diff -Nru openntpd-6.2p3/debian/changelog openntpd-6.2p3/debian/changelog
--- openntpd-6.2p3/debian/changelog	2020-10-26 18:10:47.000000000 +0100
+++ openntpd-6.2p3/debian/changelog	2021-07-25 14:37:54.000000000 +0200
@@ -1,3 +1,11 @@
+openntpd (1:6.2p3-4.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Ensure that openntpd is running before restarting it from the if-up.d
+    hook. (Closes: #987321)
+
+ -- Baptiste Beauplat <lyknode@debian.org>  Sun, 25 Jul 2021 14:37:54 +0200
+
 openntpd (1:6.2p3-4.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru openntpd-6.2p3/debian/config/openntpd openntpd-6.2p3/debian/config/openntpd
--- openntpd-6.2p3/debian/config/openntpd	2020-10-26 15:52:50.000000000 +0100
+++ openntpd-6.2p3/debian/config/openntpd	2021-07-25 11:33:18.000000000 +0200
@@ -7,4 +7,6 @@
 	exit 0
 fi
 
-invoke-rc.d openntpd force-reload || true
+if pidof -q ntpd; then
+    invoke-rc.d openntpd force-reload || true
+fi

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Unblocked.

--- End Message ---
Reply to: