[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#990065: marked as done (unblock: squid-deb-proxy/0.8.15+nmu1)

Your message dated Wed, 28 Jul 2021 22:23:24 +0200
with message-id <45be2f78-22f6-9ce0-63c7-cc4979e1cd9e@debian.org>
and subject line Re: Bug#990065: unblock: squid-deb-proxy/0.8.15+nmu1
has caused the Debian Bug report #990065,
regarding unblock: squid-deb-proxy/0.8.15+nmu1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
990065: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=990065
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package squid-deb-proxy

[ Reason ]
 squid-deb-proxy needs its apparmor profile to work.

[ Impact ]
 squid-deb-proxy does not work on bullseye
 (There's a alternative, so not grave for all users).

[ Tests ]
 Tested on KVM bullseye environment, it does not work well without
 this changes as the bug report says, and patched system works fine.

[ Risks ]
 None, IMHO.
  - It's leaf package
  - Its change does not affect its behavior, it's just for apparmor and
    does not affect other package, too.
  - Code is trivial one

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing


unblock squid-deb-proxy/0.8.15+nmu1

diff -Nru squid-deb-proxy-0.8.15/debian/apparmor-profiles/squid-deb-proxy squid-deb-proxy-0.8.15+nmu1/debian/apparmor-profiles/squid-deb-proxy
--- squid-deb-proxy-0.8.15/debian/apparmor-profiles/squid-deb-proxy	1970-01-01 09:00:00.000000000 +0900
+++ squid-deb-proxy-0.8.15+nmu1/debian/apparmor-profiles/squid-deb-proxy	2021-06-14 23:38:09.000000000 +0900
@@ -0,0 +1,6 @@
+# vim:syntax=apparmor
+
+    /etc/squid-deb-proxy/** r,
+    /var/log/squid-deb-proxy/* rw,
+    /run/squid-deb-proxy.pid rwk,
+    /var/cache/squid-deb-proxy/** rw,
diff -Nru squid-deb-proxy-0.8.15/debian/changelog squid-deb-proxy-0.8.15+nmu1/debian/changelog
--- squid-deb-proxy-0.8.15/debian/changelog	2020-01-19 03:00:55.000000000 +0900
+++ squid-deb-proxy-0.8.15+nmu1/debian/changelog	2021-06-14 23:41:11.000000000 +0900
@@ -1,3 +1,10 @@
+squid-deb-proxy (0.8.15+nmu1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Add apparmor profiles to work (Closes: #932501)
+
+ -- Hideki Yamane <henrich@debian.org>  Mon, 14 Jun 2021 23:41:11 +0900
+
 squid-deb-proxy (0.8.15) unstable; urgency=medium
 
   [ Graham Cantin ]
diff -Nru squid-deb-proxy-0.8.15/debian/squid-deb-proxy.dirs squid-deb-proxy-0.8.15+nmu1/debian/squid-deb-proxy.dirs
--- squid-deb-proxy-0.8.15/debian/squid-deb-proxy.dirs	2020-01-10 19:02:40.000000000 +0900
+++ squid-deb-proxy-0.8.15+nmu1/debian/squid-deb-proxy.dirs	2021-06-14 23:40:40.000000000 +0900
@@ -1,2 +1,3 @@
 etc/resolvconf/update-libc.d
+etc/apparmor.d/abstractions/squid-deb-proxy
 var/log/squid-deb-proxy
diff -Nru squid-deb-proxy-0.8.15/debian/squid-deb-proxy.install squid-deb-proxy-0.8.15+nmu1/debian/squid-deb-proxy.install
--- squid-deb-proxy-0.8.15/debian/squid-deb-proxy.install	2020-01-10 19:02:40.000000000 +0900
+++ squid-deb-proxy-0.8.15+nmu1/debian/squid-deb-proxy.install	2021-06-14 23:40:21.000000000 +0900
@@ -1,3 +1,4 @@
 ../update-libc.d etc/resolvconf/
 etc/squid-deb-proxy
 init-common.sh usr/share/squid-deb-proxy/
+../apparmor-profiles/* etc/apparmor.d/abstractions/squid-deb-proxy/

--- End Message ---
--- Begin Message --- 
Hi Hideki,

On 15-07-2021 12:23, Paul Gevers wrote:
> On 20-06-2021 16:02, Sebastian Ramacher wrote:
>>> --- squid-deb-proxy-0.8.15/debian/squid-deb-proxy.install	2020-01-10 19:02:40.000000000 +0900
>>> +++ squid-deb-proxy-0.8.15+nmu1/debian/squid-deb-proxy.install	2021-06-14 23:40:21.000000000 +0900
>>> @@ -1,3 +1,4 @@
>>>  ../update-libc.d etc/resolvconf/
>>>  etc/squid-deb-proxy
>>>  init-common.sh usr/share/squid-deb-proxy/
>>> +../apparmor-profiles/* etc/apparmor.d/abstractions/squid-deb-proxy/
>>
>> I'm not an apparmor expert, but is this enough? Shouldn't there also be
>> a profile for the binary that uses this abstraction?
> 
> @Hideki, can you please respond, this is a concern that you fix is not
> enough.

The original bug got re-opened and both that one and this bug didn't
receive any follow-up. As we're getting very close to the release, we
want a clear view of our unblock bugs that require actions/work from us,
hence closing this bug (please re-open or file a new one if there's
something to migrate).

Paul

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


--- End Message ---
Reply to: