[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#991470: marked as done (unblock: q2-sample-classifier/2020.11.1-3)

Your message dated Wed, 28 Jul 2021 14:56:51 +0200
with message-id <CAM8zJQs0SXkC4+waYf0FdVghBSbayu+EN37AkYPBEWoPBT69Xg@mail.gmail.com>
and subject line Re: Bug#991470: unblock: q2-sample-classifier/2020.11.1-2
has caused the Debian Bug report #991470,
regarding unblock: q2-sample-classifier/2020.11.1-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
991470: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=991470
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: nilesh@debian.org

Please unblock package q2-sample-classifier

[ Reason ]
This package misses a few needed dependencies, which renders it unusable

[ Impact ]
The package will be broken for the user, and they will have to fetch the
dependencies by themselves

[ Tests ]
Autopkgtests have been added in this release

[ Risks ]
No risks as such

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

unblock q2-sample-classifier/2020.11.1-2

diff -Nru q2-sample-classifier-2020.11.1/debian/changelog q2-sample-classifier-2020.11.1/debian/changelog
--- q2-sample-classifier-2020.11.1/debian/changelog	2020-12-06 21:40:46.000000000 +0530
+++ q2-sample-classifier-2020.11.1/debian/changelog	2021-07-25 10:36:56.000000000 +0530
@@ -1,3 +1,15 @@
+q2-sample-classifier (2020.11.1-2) unstable; urgency=medium
+
+  * Team Upload.
+  * d/control: Add depends on python3-distutils,
+    q2-types, q2-feature-table
+  * Add autopkgtests
+  * d/rules: Do not run build time tests with || true
+    rather just print the message that this will be dealt
+    with in autopkgtests
+
+ -- Nilesh Patra <nilesh@debian.org>  Sun, 25 Jul 2021 10:36:56 +0530
+
 q2-sample-classifier (2020.11.1-1) unstable; urgency=medium
 
   * Team upload.
diff -Nru q2-sample-classifier-2020.11.1/debian/control q2-sample-classifier-2020.11.1/debian/control
--- q2-sample-classifier-2020.11.1/debian/control	2020-12-06 21:40:46.000000000 +0530
+++ q2-sample-classifier-2020.11.1/debian/control	2021-07-25 10:33:16.000000000 +0530
@@ -22,6 +22,9 @@
          ${misc:Depends},
          ${python3:Depends},
          qiime (>= 2020.11.0),
+         python3-distutils,
+         q2-types,
+         q2-feature-table
 Description: QIIME 2 plugin for machine learning prediction of sample data
  QIIME 2 is a powerful, extensible, and decentralized microbiome analysis
  package with a focus on data and analysis transparency. QIIME 2 enables
diff -Nru q2-sample-classifier-2020.11.1/debian/rules q2-sample-classifier-2020.11.1/debian/rules
--- q2-sample-classifier-2020.11.1/debian/rules	2020-12-06 21:40:46.000000000 +0530
+++ q2-sample-classifier-2020.11.1/debian/rules	2021-07-25 10:29:27.000000000 +0530
@@ -13,11 +13,11 @@
 	rm -rf debian/q2-sample-classifier/usr/lib/python3.9/site-packages/q2_sample_classifier/__pycache__/
 	rm -rf debian/q2-sample-classifier/usr/lib/python3.9/site-packages/q2_sample_classifier/tests/__pycache__/
 
-# FIXME: modules cannot be registered at build time - ignoring build tests for now
+#FIXME:
 override_dh_auto_test:
-#ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
-	dh_auto_test || true
-#endif
+ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
+	echo "I: Delaying true testing to autopkgtests since QIIME2 module cannot be registered at build time"
+endif
 
 override_dh_auto_clean:
 	dh_auto_clean
diff -Nru q2-sample-classifier-2020.11.1/debian/tests/control q2-sample-classifier-2020.11.1/debian/tests/control
--- q2-sample-classifier-2020.11.1/debian/tests/control	1970-01-01 05:30:00.000000000 +0530
+++ q2-sample-classifier-2020.11.1/debian/tests/control	2021-07-18 17:29:15.000000000 +0530
@@ -0,0 +1,3 @@
+Tests: run-unit-test
+Depends: @, python3-pytest-cov
+Restrictions: allow-stderr, skip-not-installable
diff -Nru q2-sample-classifier-2020.11.1/debian/tests/run-unit-test q2-sample-classifier-2020.11.1/debian/tests/run-unit-test
--- q2-sample-classifier-2020.11.1/debian/tests/run-unit-test	1970-01-01 05:30:00.000000000 +0530
+++ q2-sample-classifier-2020.11.1/debian/tests/run-unit-test	2021-07-25 10:31:17.000000000 +0530
@@ -0,0 +1,20 @@
+#!/bin/bash
+set -e
+
+pkg=q2_sample_classifier
+
+if [ "${AUTOPKGTEST_TMP}" = "" ] ; then
+  AUTOPKGTEST_TMP=$(mktemp -d /tmp/${pkg}-test.XXXXXX)
+  trap "rm -rf ${AUTOPKGTEST_TMP}" 0 INT QUIT ABRT PIPE TERM
+fi
+
+cp -a /usr/lib/python3/dist-packages/${pkg}* "${AUTOPKGTEST_TMP}"
+
+cd "${AUTOPKGTEST_TMP}"
+if [ ! -f /usr/lib/python3/dist-packages/pytest_cov/__init__.py ] ; then
+	echo "Please install package python3-pytest-cov to run this script"
+	exit 1
+fi
+
+# Run build-time tests
+py.test-3 --cov=${pkg}

--- End Message ---
--- Begin Message --- 
Unblocked.

--- End Message ---
Reply to: