[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#991457: marked as done (unblock: graphicsmagick/1.4+really1.3.36+hg16481-2)

Your message dated Sun, 25 Jul 2021 08:52:41 +0000
with message-id <E1m7ZsH-00049r-H2@respighi.debian.org>
and subject line unblock graphicsmagick
has caused the Debian Bug report #991457,
regarding unblock: graphicsmagick/1.4+really1.3.36+hg16481-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
991457: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=991457
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Hi RMs,

I would like to ask for unblocking GraphicsMagick, with a simple but
important fix of freeing used memory[1].

[ Reason ]
Fixes a simple regression - writing labelled PDF files.

[ Impact ]
No more assertion on normal and common usage.

[ Tests ]
Good upstream test suite.

[ Risks ]
None.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

unblock graphicsmagick/1.4+really1.3.36+hg16481-2

Thanks for considering,
Laszlo/GCS
[1] http://hg.graphicsmagick.org/hg/GraphicsMagick/rev/22aaff86b4aa

diff -Nru graphicsmagick-1.4+really1.3.36+hg16481/debian/changelog graphicsmagick-1.4+really1.3.36+hg16481/debian/changelog
--- graphicsmagick-1.4+really1.3.36+hg16481/debian/changelog	2021-02-28 23:26:56.000000000 +0100
+++ graphicsmagick-1.4+really1.3.36+hg16481/debian/changelog	2021-07-24 11:42:42.000000000 +0200
@@ -1,3 +1,10 @@
+graphicsmagick (1.4+really1.3.36+hg16481-2) unstable; urgency=medium
+
+  * Backport fix for use appropriate memory deallocator for memory returned
+    by StringToList() (closes: #991380).
+
+ -- Laszlo Boszormenyi (GCS) <gcs@debian.org>  Sat, 24 Jul 2021 11:42:42 +0200
+
 graphicsmagick (1.4+really1.3.36+hg16481-1) unstable; urgency=high
 
   * Mercurial snapshot, fixing the following security issues:
diff -Nru graphicsmagick-1.4+really1.3.36+hg16481/debian/patches/series graphicsmagick-1.4+really1.3.36+hg16481/debian/patches/series
--- graphicsmagick-1.4+really1.3.36+hg16481/debian/patches/series	2020-06-03 17:49:58.000000000 +0200
+++ graphicsmagick-1.4+really1.3.36+hg16481/debian/patches/series	2021-07-24 11:42:42.000000000 +0200
@@ -1,2 +1,3 @@
 link-demos.diff
 semaphore_O0_ppc64el.patch
+use_appropriate_memory_deallocator.patch
diff -Nru graphicsmagick-1.4+really1.3.36+hg16481/debian/patches/use_appropriate_memory_deallocator.patch graphicsmagick-1.4+really1.3.36+hg16481/debian/patches/use_appropriate_memory_deallocator.patch
--- graphicsmagick-1.4+really1.3.36+hg16481/debian/patches/use_appropriate_memory_deallocator.patch	1970-01-01 01:00:00.000000000 +0100
+++ graphicsmagick-1.4+really1.3.36+hg16481/debian/patches/use_appropriate_memory_deallocator.patch	2021-07-24 11:42:42.000000000 +0200
@@ -0,0 +1,52 @@
+
+# HG changeset patch
+# User Bob Friesenhahn <bfriesen@GraphicsMagick.org>
+# Date 1626915582 18000
+# Node ID 22aaff86b4aa34c10b3fbfb104adaaeef8653a36
+# Parent  acf305f9ef3e85e6273d62e72d81cce03440eb3d
+WritePDFImage(): Use appropriate memory deallocator for memory returned by StringToList().
+
+diff -r acf305f9ef3e -r 22aaff86b4aa ChangeLog
+--- a/ChangeLog	Wed Jul 21 19:47:33 2021 -0500
++++ b/ChangeLog	Wed Jul 21 19:59:42 2021 -0500
+@@ -1,3 +1,9 @@
++2021-07-21  Bob Friesenhahn  <bfriesen@simple.dallas.tx.us>
++
++        * coders/pdf.c (WritePDFImage): Use appropriate memory deallocator
++        for memory returned by StringToList().  Fixes SourceForge issue
++        646 "Assertion failed using -label with PDF".
++
+ 2021-02-28  Bob Friesenhahn  <bfriesen@simple.dallas.tx.us>
+ 
+         * configure.ac: Add tests for Jasper jp2_decode(), jpc_decode(),
+diff -r acf305f9ef3e -r 22aaff86b4aa coders/pdf.c
+--- a/coders/pdf.c	Wed Jul 21 19:47:33 2021 -0500
++++ b/coders/pdf.c	Wed Jul 21 19:59:42 2021 -0500
+@@ -1046,9 +1046,9 @@
+               FormatString(buffer,"(%.1024s) Tj\n",labels[i]);
+               (void) WriteBlobString(image,buffer);
+               (void) WriteBlobString(image,"ET\n");
+-              MagickFreeResourceLimitedMemory(labels[i]);
++              MagickFreeMemory(labels[i]);
+             }
+-          MagickFreeResourceLimitedMemory(labels);
++          MagickFreeMemory(labels);
+         }
+       FormatString(buffer,"%g 0 0 %g %ld %ld cm\n",x_scale,y_scale,geometry.x,
+                    geometry.y);
+diff -r acf305f9ef3e -r 22aaff86b4aa www/Changelog.html
+--- a/www/Changelog.html	Wed Jul 21 19:47:33 2021 -0500
++++ b/www/Changelog.html	Wed Jul 21 19:59:42 2021 -0500
+@@ -35,6 +35,12 @@
+ <div class="document">
+ 
+ 
++<p>2021-07-21  Bob Friesenhahn  &lt;<a class="reference external" href="mailto:bfriesen&#37;&#52;&#48;simple&#46;dallas&#46;tx&#46;us";>bfriesen<span>&#64;</span>simple<span>&#46;</span>dallas<span>&#46;</span>tx<span>&#46;</span>us</a>&gt;</p>
++<blockquote>
++<p>* coders/pdf.c (WritePDFImage): Use appropriate memory deallocator
++for memory returned by StringToList().  Fixes SourceForge issue
++646 &quot;Assertion failed using -label with PDF&quot;.</p>
++</blockquote>
+ <p>2021-02-28  Bob Friesenhahn  &lt;<a class="reference external" href="mailto:bfriesen&#37;&#52;&#48;simple&#46;dallas&#46;tx&#46;us";>bfriesen<span>&#64;</span>simple<span>&#46;</span>dallas<span>&#46;</span>tx<span>&#46;</span>us</a>&gt;</p>
+ <blockquote>
+ <p>* configure.ac: Add tests for Jasper jp2_decode(), jpc_decode(),

--- End Message ---
--- Begin Message --- 
Unblocked.

--- End Message ---
Reply to: