[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#991447: unblock: flameshot/0.9.0+ds1-2 (pre-approval)



Control: tags -1 -moreinfo

在 2021-07-24星期六的 00:02 +0200,Sebastian Ramacher写道:
> Control: tags -1 moreinfo confirmed
> 
> On 2021-07-23 16:02:46 -0400, Boyuan Yang wrote:
> > Package: release.debian.org
> > User: release.debian.org@packages.debian.org
> > Usertags: unblock
> > X-Debbugs-Cc: byang@debian.org
> > Severity: normal
> > 
> > Please unblock package flameshot
> > 
> > I am looking forward to fixing several bugs that affect current
> > flameshot/0.9.0+ds1-1 in Debian Testing. These bugs include privacy breach
> > (automatic software update checking), crashing under some circumstances
> > and
> > incorrect icon under Xfce environment. All patches are tested with
> > acknowledgement from upstream.
> > 
> > [ Reason ]
> > * https://bugs.debian.org/991392
> > Currently flameshot would check for update by querying github api every 24
> > hours. This functionality was previously enabled by default. A patch was
> > added
> > to disable new version checking by default.
> > 
> > * https://bugs.debian.org/991320
> > Currently flameshot would crash when tray icon is disabled and new version
> > checking is enabled.
> > 
> > * https://bugs.debian.org/991216
> > Currently flameshot will show an incorrect icon (bulb icon instead of
> > flameshot's own icon) under Xfce environment.
> > 
> > [ Impact ]
> > If the new version is not in Debian 11:
> > 
> > * The software would query new version using internet every 24 hours by
> > default, which is an unwanted behavior for some users.
> > 
> > * The software would crash under the configuration described above. The
> > crash
> > would persist unless the user manually edit configuration file to disable
> > such
> > setting.
> > 
> > * The software would show an incorrect icon for all Xfce users.
> > 
> > [ Tests ]
> > I manually tested all 3 patches using a clean Debian Testing chroot to
> > confirm
> > that the bugs are all fixed.
> > 
> > [ Risks ]
> > The risk should be minimal since patches for crash and xfce are merged in
> > upstream trunk. The patch for disabling automatic update check has been
> > verified by lamby and me (see https://bugs.debian.org/991392 ;).
> > 
> > [ Checklist ]
> >   [X] all changes are documented in the d/changelog
> >   [X] I reviewed all changes and I approve them
> >   [X] attach debdiff against the package in testing
> > 
> > [ Other info ]
> > The new version flameshot/0.9.0+ds1-2 hasn't been uploaded onto Unstable
> > yet.
> > Please let me know if I may proceed.
> > 
> > Please find the full debdiff in the attachment.
> > 
> > 
> > 
> > unblock flameshot/0.9.0+ds1-2
> 
> Assuming that the upload happens soon, please go ahead. Once the version
> is available in unstable, please remove the moreinfo tag.
> 
> Cheers

The new version has been uploaded to unstable.


Thanks,
Boyuan


Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: