[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#991407: marked as done (unblock: pppoeconf/1.21+nmu2)



Your message dated Fri, 23 Jul 2021 22:06:08 +0000
with message-id <E1m73J2-0005wS-5O@respighi.debian.org>
and subject line unblock pppoeconf
has caused the Debian Bug report #991407,
regarding unblock: pppoeconf/1.21+nmu2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
991407: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=991407
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package pppoeconf

[ Reason ]
pppoe-discovery from the ppp package dropped the -A option in a recent
version. As the option had no function in old version, I dropped it from
the pppoeconf call to pppoe-discovery (#990978).

[ Impact ]
Without this change pppoeconf in bullseye is broken as it will not find
any modem.

[ Tests ]
I was able to reproduce the bug and also that it does not happen anymore
with the new version.

[ Risks ]
The patch only removes an old noop option in a shell script. I don't see
a risk.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

[ Other info ]
I've added a patch with two typo fixes for the man page which I found in
the BTS.

unblock pppoeconf/1.21+nmu2
diff -Nru pppoeconf-1.21+nmu1/debian/changelog pppoeconf-1.21+nmu2/debian/changelog
--- pppoeconf-1.21+nmu1/debian/changelog	2021-01-01 16:42:10.000000000 +0100
+++ pppoeconf-1.21+nmu2/debian/changelog	2021-07-22 20:51:01.000000000 +0200
@@ -1,3 +1,14 @@
+pppoeconf (1.21+nmu2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove -A option from pppoe-discovery (Closes: #990978).
+    It had no function anymore and was removed in new versions.
+    Thanks: Michael Prokop
+  * Apply two manpage corrections (Closes: #814354).
+    Thanks: Christoph Biedl
+
+ -- Jochen Sprickerhof <jspricke@debian.org>  Thu, 22 Jul 2021 20:51:01 +0200
+
 pppoeconf (1.21+nmu1) unstable; urgency=medium
 
   * Non maintainer upload by the Reproducible Builds team.
diff -Nru pppoeconf-1.21+nmu1/pppoeconf pppoeconf-1.21+nmu2/pppoeconf
--- pppoeconf-1.21+nmu1/pppoeconf	2013-12-27 03:07:24.000000000 +0100
+++ pppoeconf-1.21+nmu2/pppoeconf	2021-07-22 20:49:37.000000000 +0200
@@ -190,7 +190,7 @@
 
             touch $TMP/pppoe.scan
             ip link set $iface up
-            ($DISCOVERY_PROGRAM $mmm -A -I $iface > $TMP/$iface.pppoe ; rm $TMP/pppoe.scan) &
+            ($DISCOVERY_PROGRAM $mmm -I $iface > $TMP/$iface.pppoe ; rm $TMP/pppoe.scan) &
 
             ( time=0 ; while test -f $TMP/pppoe.scan ; do time=`expr $time + 6`; echo $time; sleep 1; done ) | $DIALOG --title "$title" --gauge "$text $mmode" 10 60 0
 
diff -Nru pppoeconf-1.21+nmu1/pppoeconf.8.sgml pppoeconf-1.21+nmu2/pppoeconf.8.sgml
--- pppoeconf-1.21+nmu1/pppoeconf.8.sgml	2013-12-27 03:07:24.000000000 +0100
+++ pppoeconf-1.21+nmu2/pppoeconf.8.sgml	2021-07-22 20:50:22.000000000 +0200
@@ -70,12 +70,12 @@
     <title>DESCRIPTION</title>
 
     <para>The <command>&dhpackage;</command> program is user-friendly dialog
-     based setup tool for <command>pppd</command> (and <command>pppoe</command>
-     if needed). It will look for existing ethernet cards and look for ADSL
+     based setup tool for <command>pppd</command> (and <command>pppoe</command> if
+     needed). It will look for existing ethernet cards and look for ADSL
      hardware connected to one of them. You can add an interface name
      <option>iface</option> to force &dhpackage; to use it. Then it will get
      some login info and do some minor modifications to make working
-     settings. Note that you can use ESC key to exit program when you wan.</para>
+     settings. Note that you can use ESC key to exit program when you want.</para>
 
   </refsect1>
   <refsect1>

--- End Message ---
--- Begin Message ---
Unblocked.

--- End Message ---

Reply to: