Bug#990559: Please unblock package mdevctl 0.81-1

[Christian Ehrhardt <christian.ehrhardt@canonical.com>]

On Sun, Jul 4, 2021 at 9:46 PM Sebastian Ramacher <sramacher@debian.org> wrote:
>
> Control: tags -1 moreinfo
>
> On 2021-07-02 07:37:22 +0200, Christian Ehrhardt wrote:
> > Package: release.debian.org
> > Severity: normal
> > User: release.debian.org@packages.debian.org
> > Usertags: unblock
> >
> > Hi,
> > please unblock mdevctl 0.81-1.
> >
> > It fixes a problem with an allowed combined usage two parameters.
> > v0.78 -> 0.81 sounds a lot, but that is due to the way upstream creates
> > versions which essentially is a counter of git commits.
> > Therefore the only real change is [1] which should be ok for the freeze time.
> >
> > There are two packaging-only changes which I had in git but not
> > uploaded yes (as they didn't qualify for an upload without any fix.
> > But both are no-impact changes (compat level while the package has not much
> > that is affected by it and the drop of the unused d/source/local-options.
> >
> > The builds all LGTM, see [2]. I have installed the new build and it works
> > as expected:
> >
> > Before
> > # mdevctl define -p 0.0.0033 --jsonfile mdev_nodedev.json
> > /usr/sbin/mdevctl: line 183:
> > /etc/mdevctl.d/0.0.0033/eea1c8dc-ce6d-42dd-bd26-02e3b707ff95: No such
> > file or directory
> > After
> > # mdevctl define -p 0.0.0033 --jsonfile mdev_nodedev.json
> > 83123a52-3147-44d1-9154-1175e266804e
> >
> > The package has no autopkgtests as they would be superficial and not much
> > worth or would need mdev splittable GPUs or such on the test systems which we
> > can not assume/expect to have. Therefore I need to ask you via this ubblock
> > request. I hope that this is sufficient to unblock, if you need anything
> > else please let me know.
> >
> > [1]: https://github.com/mdevctl/mdevctl/commit/e6cf620b4b04c6
> > [2]: https://buildd.debian.org/status/fetch.php?pkg=mdevctl&arch=all&ver=0.78-1&stamp=1606290427

Hi Sebastian,
I missed your question before today, so sorry for the delay in clarifying this.

> Please attach a debdiff between the version in testing and unstable.

Attached is the debdiff "mdevctl-to-0.81.debdiff" as requested.

> Regarding the packaging changes: it's too late to bump debhelper compat.
> See https://release.debian.org/bullseye/freeze_policy.html. Please
> revert that change (or show that the change does not cause any
> differences in the produced binary packages).

Furthermore in regard to compat I have extracted the full content and
control of 0.78 and 0.81 locally (with dpkd -x and -e out of the debs
in the archive).

You can see in the attached "effective-changes.diff" that the only
changes are only:
- version number
- wanted fix in lsmdev (link to mdevctl, so it is the same change in two places)
- wanted fix in mdevctl
- changelog binary

AFAICS there are no unexpected changes built into the binaries or the maintainer
scripts.

> Cheers
> --
> Sebastian Ramacher



-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

diff -Naur 0.78/content/usr/sbin/lsmdev 0.81/content/usr/sbin/lsmdev
--- 0.78/content/usr/sbin/lsmdev	2020-11-25 07:02:19.000000000 +0000
+++ 0.81/content/usr/sbin/lsmdev	2021-07-01 14:07:15.000000000 +0000
@@ -3,7 +3,7 @@
 persist_base=/etc/mdevctl.d
 mdev_base=/sys/bus/mdev/devices
 parent_base=/sys/class/mdev_bus
-version="0.78"
+version="0.81"
 
 # Alias 'lsmdev' to 'mdevctl list'
 if [ $(basename $0) == "lsmdev" ]; then
@@ -609,6 +609,7 @@
                 exit 1
             fi
 
+            mkdir -p "$persist_base/$parent"
             write_config "$persist_base/$parent/$uuid"
             if [ $? -ne 0 ]; then
                 exit 1
diff -Naur 0.78/content/usr/sbin/mdevctl 0.81/content/usr/sbin/mdevctl
--- 0.78/content/usr/sbin/mdevctl	2020-11-25 07:02:19.000000000 +0000
+++ 0.81/content/usr/sbin/mdevctl	2021-07-01 14:07:15.000000000 +0000
@@ -3,7 +3,7 @@
 persist_base=/etc/mdevctl.d
 mdev_base=/sys/bus/mdev/devices
 parent_base=/sys/class/mdev_bus
-version="0.78"
+version="0.81"
 
 # Alias 'lsmdev' to 'mdevctl list'
 if [ $(basename $0) == "lsmdev" ]; then
@@ -609,6 +609,7 @@
                 exit 1
             fi
 
+            mkdir -p "$persist_base/$parent"
             write_config "$persist_base/$parent/$uuid"
             if [ $? -ne 0 ]; then
                 exit 1
diff -Naur 0.78/content/usr/share/doc/mdevctl/changelog.Debian.gz 0.81/content/usr/share/doc/mdevctl/changelog.Debian.gz
--- 0.78/content/usr/share/doc/mdevctl/changelog.Debian.gz	2020-11-25 07:02:19.000000000 +0000
+++ 0.81/content/usr/share/doc/mdevctl/changelog.Debian.gz	2021-07-01 14:07:15.000000000 +0000
@@ -1,2 +1,3 @@
-���M��0���#q��I�4��b�
\X������ZǶl�e��LڴH�ri�D�L���W�
-w2xY��E�^Agck�o�[���]�Jw�hp�������J]�Tp��O����7f^�&���
X��5j�!%���v�HgSp�úk=�U"�;Q;�A��9�ցl��b$.T�~>�-=��& ��ǐ�gQm�c���V�ѪH�f�7A�Ds��&4D��<�rj���j)LN��
��CY�W���((�(9[���h��5}������&ʇ���/~�\�q6%��9%����F�!y��/�9R��WS�@Y_�e�<D�AX�-%*
�!Q�l�9��SL�*���.�><�s���Mg̹9�铿ѿ��0�����M�g�Zaig�8�̿��fSY
+�d*�1^�x5�к�l�q����������9�XVu9-�;y�ɩ�^�G��[��Z�I�7"!��`�k+�?h6,c?kɧ3^Vì���

\ No newline at end of file
+���Mo1���#qIK7]o�Iv��	$�P���ؓ��׶��R~=�tӊ�������<����"j��%+�$"_i|
�oЈ�W=J����>!��$�G�C�Hg�W?1���J���]C�	?�50>�6`h�YӔ��>ک�SaM�V��J��h���4nQ���P��fC/0���j��<�Vp]X�5�ﱷ[��Hޣ��:wF�$���@��u^����w�︗^�}m�C���E�r��K'P2��4Teŀ��rѲ��UY�F�����P���Q#'p��Uz�Qw*qE��/,�M&�+:0�
+V����b&?����%3FRk
��
��g�z��������i�F Wj��>�^Tx����9:4�0�_Q�@U�g���K(�mY��!���y�d����h�qq�˦����0s�t��0�	��r�X�Φd����Y��.:�Jm(Qq�����`ӆ���:D�%���1�gͷ���Ne���=���i�P��0p��{��uȽ=743F�o�r0TV�9
+�J�d�����⑀���P���!��(z��Ü��ޜ�մ����H���qq�7��ϋ.�5A"�N�H�8��Ѹ���C���0�^�v:o����o�U��V
\ No newline at end of file
diff -Naur 0.78/control/control 0.81/control/control
--- 0.78/control/control	2020-11-25 07:02:19.000000000 +0000
+++ 0.81/control/control	2021-07-01 14:07:15.000000000 +0000
@@ -1,5 +1,5 @@
 Package: mdevctl
-Version: 0.78-1
+Version: 0.81-1
 Architecture: all
 Maintainer: Christian Ehrhardt <christian.ehrhardt@canonical.com>
 Installed-Size: 51
diff -Naur 0.78/control/md5sums 0.81/control/md5sums
--- 0.78/control/md5sums	2020-11-25 07:02:19.000000000 +0000
+++ 0.81/control/md5sums	2021-07-01 14:07:15.000000000 +0000
@@ -1,6 +1,6 @@
 1f7ce62b01dc5b8a7ec6b865539ca22f  lib/udev/rules.d/60-mdevctl.rules
-7394efec2042d7721b109f514da8c29f  usr/sbin/mdevctl
+4c8f7bdaa5220a6ba266022dbfbcdd5f  usr/sbin/mdevctl
 860256e02224ba45353f6d1cb040bf65  usr/share/doc/mdevctl/README.Debian
-5b8749adf8d0e117579c948a9fe31d1f  usr/share/doc/mdevctl/changelog.Debian.gz
+3c2c54757256d305c72acc827605b1cd  usr/share/doc/mdevctl/changelog.Debian.gz
 6de97be2cb2a70888783535d8602cc78  usr/share/doc/mdevctl/copyright
 7037dcb3694dc9b37fd54cf7ad0e69a8  usr/share/man/man8/mdevctl.8.gz

Attachment: mdevctl-to-0.81.debdiff
Description: Binary data