[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#990905: marked as done (unblock: php-horde-memcache/2.1.1-7)

Your message dated Sun, 11 Jul 2021 18:58:59 +0000
with message-id <E1m2efL-0004Np-Hj@respighi.debian.org>
and subject line unblock php-horde-memcache
has caused the Debian Bug report #990905,
regarding unblock: php-horde-memcache/2.1.1-7
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
990905: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=990905
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package php-horde-memcache

I am unsure if php-horde-memcache 2.1.1-7 will migrate just because
of succeeded autopktests, so filing an unblock bug anyway.

[ Reason ]
Upstream provided a PHP 8.0 compatibility fix. eople have started used
php 8.0 already on buster (from https://packages.sury.org/php/), more
will follow for bullseye, although php7.4 will be the default for
bullseye. So, fixing things for PHP 8.0 is probably nice to have if fixed
by a simple change.

[ Impact ]
php-horde-memcache won't be usable with php8.0.

[ Tests ]
Patch introspection. Not broken on php7.4, autopkgtests succeed.

[ Risks ]
Breakage of php-horde in Debian where php-horde-memcache is in use.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]
None.

unblock php-horde-memcache/2.1.1-7

diff -Nru php-horde-memcache-2.1.1/debian/changelog php-horde-memcache-2.1.1/debian/changelog
--- php-horde-memcache-2.1.1/debian/changelog	2020-07-01 13:48:57.000000000 +0200
+++ php-horde-memcache-2.1.1/debian/changelog	2021-07-05 14:14:04.000000000 +0200
@@ -1,3 +1,10 @@
+php-horde-memcache (2.1.1-7) unstable; urgency=medium
+
+  * d/patches: Add 0001_Reorder-glue-and-array-parameters.patch. Reorder glue
+    and array parameters in implode(). Prepare for PHP 8.x.
+
+ -- Mike Gabriel <sunweaver@debian.org>  Mon, 05 Jul 2021 14:14:04 +0200
+
 php-horde-memcache (2.1.1-6) unstable; urgency=medium
 
   * d/control: Add to Uploaders: Juri Grabowski.
diff -Nru php-horde-memcache-2.1.1/debian/patches/0001_Reorder-glue-and-array-parameters.patch php-horde-memcache-2.1.1/debian/patches/0001_Reorder-glue-and-array-parameters.patch
--- php-horde-memcache-2.1.1/debian/patches/0001_Reorder-glue-and-array-parameters.patch	1970-01-01 01:00:00.000000000 +0100
+++ php-horde-memcache-2.1.1/debian/patches/0001_Reorder-glue-and-array-parameters.patch	2021-07-05 14:14:04.000000000 +0200
@@ -0,0 +1,28 @@
+From ffd585d3be551f6e1a5283779294f2cd241c4cd1 Mon Sep 17 00:00:00 2001
+From: Michael J Rubinsky <mrubinsk@horde.org>
+Date: Mon, 31 May 2021 12:01:18 -0400
+Subject: [PATCH] Reorder glue and array parameters
+
+Deprecated since 7.4 and an error in 8.0
+
+Signed-off-by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
+---
+ Horde_Memcache-2.1.1/lib/Horde/Memcache.php | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Horde_Memcache-2.1.1/lib/Horde/Memcache.php b/Horde_Memcache-2.1.1/lib/Horde/Memcache.php
+index a13ca2c..498d88c 100644
+--- a/Horde_Memcache-2.1.1/lib/Horde/Memcache.php
++++ b/Horde_Memcache-2.1.1/lib/Horde/Memcache.php
+@@ -202,7 +202,7 @@ class Horde_Memcache implements Serializable
+ 
+         if (isset($this->_params['logger'])) {
+             $this->_logger = $this->_params['logger'];
+-            $this->_logger->log('Connected to the following memcache servers:' . implode($this->_servers, ', '), 'DEBUG');
++            $this->_logger->log('Connected to the following memcache servers:' . implode(', ', $this->_servers), 'DEBUG');
+         }
+     }
+ 
+-- 
+2.30.2
+
diff -Nru php-horde-memcache-2.1.1/debian/patches/series php-horde-memcache-2.1.1/debian/patches/series
--- php-horde-memcache-2.1.1/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ php-horde-memcache-2.1.1/debian/patches/series	2021-07-05 14:14:04.000000000 +0200
@@ -0,0 +1 @@
+0001_Reorder-glue-and-array-parameters.patch

--- End Message ---
--- Begin Message --- 
Unblocked.

--- End Message ---
Reply to: