Bug#990491: unblock: darktable/3.4.1-5
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Please unblock package darktable
[ Reason ]
The new version fixes an unclosed comment in the Italian translation
of user.css. If the user triggers the creation of this file (e.g. by
adding a keyboard shortcut in the preferences), then the GUI is
somewhat mangled.
[ Impact ]
Probably further confusion for Italian speaking users of
darktable. There is a fairly simple workaround (fix the comment in
user.css), if the user seeks help and/reports the problem. The fact
that it only happens in Italian locales makes it trickier for users to
figure out the problem. OTOH I guess from a utilitarian point of view
it also affects less users.
[ Tests ]
I've run the new version under it_IT.utf8 and en_CA.utf8 locales. Both
seem OK, and I can define keyboard shortcuts without trashing the GUI.
[ Risks ]
Darktable is a leaf package; the change is one line cherry-picked from
upstream.
[ Checklist ]
[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in testing
[ Other info ]
(Anything else the release team should know.)
unblock darktable/3.4.1-5
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEkiyHYXwaY0SiY6fqA0U5G1WqFSEFAmDcjM0ACgkQA0U5G1Wq
FSGAvw//YjMLahGNm+kbIBBHz4FKC5c8ZnKTNJPt9s8b5lvrM4EsYUEMMuxRkSUA
ARZWKnDlB/IoLgjzcmOiOlCknDTP90W8P3oWDALMIjHzwJVqZBm54rDblKJKAzFI
Egb+5WPMEgxHTLzEg7vA/gyeAiF/k2sliSAOxRJLGdYDAbJfFHmpUYGjqZvcf7S/
owZmz6tFUnjQmTdlnLycg34vzBrfM1e7G2xFONoHKNWq2WDRMjcHVKC7Gxx/ApdX
QYjzC5t3eRqPiC4ZN+50EU+j+5i1qlwGPY1L2K9fOC3miOpFpnoBxSxpsgIQMf2x
Utkt4DzufQ7M2Y3SVr2JAQ7ROce3NsAebN3ywm3P3Ld1kAmpFTndjj2vFBf5b7aP
BgPiyR1f2/ID1UbxWsmahpZolc12oXEYqaaK9tVhCAy4sEon3XktSP9gcOhzoTav
fSHjf/Cq0rrRgQIxaggpFbA9HWzL9RQGBzDi2b+PluwfBAHLhlgHu59QA8ExW8SK
rLxHQwMLNkTcSiq8/ay1Z1Y1RPXjAJAy1ARRZ4CZnaNTRi3HgIrkq6dyfjaTyBFF
NgEZtUjc3zwaurVRyV/WrIVyWzVzGlnC3W5X/XhKUghsFL7cJ61UCI+FfwIBF6tq
f/x+Mw0iBtzqi4OEJbVRx2fkaHr6c/SgJkyriDuuvvmTwX+/o/c=
=7OD0
-----END PGP SIGNATURE-----
diff -Nru darktable-3.4.1/debian/changelog darktable-3.4.1/debian/changelog
--- darktable-3.4.1/debian/changelog 2021-06-05 12:41:39.000000000 -0300
+++ darktable-3.4.1/debian/changelog 2021-06-30 09:37:35.000000000 -0300
@@ -1,3 +1,11 @@
+darktable (3.4.1-5) unstable; urgency=medium
+
+ * Bug fix: "configuring shortcuts breaks filemanager gui at next start
+ filemanager issueVersion: 3.4.1-4", thanks to stef.binde (Closes:
+ #990405). Closed by cherry-picking upstream commit 154e945f.
+
+ -- David Bremner <bremner@debian.org> Wed, 30 Jun 2021 09:37:35 -0300
+
darktable (3.4.1-4) unstable; urgency=medium
* Bug fix: "crashes with 'Floating point exception (core dumped)' after
diff -Nru darktable-3.4.1/debian/patches/0003-it-fix-wrong-translation-breaking-the-CSS.patch darktable-3.4.1/debian/patches/0003-it-fix-wrong-translation-breaking-the-CSS.patch
--- darktable-3.4.1/debian/patches/0003-it-fix-wrong-translation-breaking-the-CSS.patch 1969-12-31 20:00:00.000000000 -0400
+++ darktable-3.4.1/debian/patches/0003-it-fix-wrong-translation-breaking-the-CSS.patch 2021-06-30 09:37:35.000000000 -0300
@@ -0,0 +1,22 @@
+From: Pascal Obry <pascal@obry.net>
+Date: Thu, 7 Jan 2021 09:49:25 +0100
+Subject: it: fix wrong translation breaking the CSS.
+
+(cherry picked from commit 154e945f4bef98de82eff728a6485b1c6c4d79c5)
+---
+ po/it.po | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/po/it.po b/po/it.po
+index 3fb64aa..73be374 100644
+--- a/po/it.po
++++ b/po/it.po
+@@ -7586,7 +7586,7 @@ msgid ""
+ "/* Enter CSS theme tweaks here */\n"
+ "\n"
+ msgstr ""
+-"/* Inserisci le modifiche al CSS qui /*\n"
++"/* Inserisci le modifiche al CSS qui */\n"
+ "\n"
+
+ #: ../src/gui/preferences.c:546
diff -Nru darktable-3.4.1/debian/patches/series darktable-3.4.1/debian/patches/series
--- darktable-3.4.1/debian/patches/series 2021-06-05 12:41:39.000000000 -0300
+++ darktable-3.4.1/debian/patches/series 2021-06-30 09:37:35.000000000 -0300
@@ -1,2 +1,3 @@
0001-add-explicit-dependency-on-generate_conf.patch
0002-Avoid-div-by-zero-in-dt_iop_clip_and_zoom_mosaic_hal.patch
+0003-it-fix-wrong-translation-breaking-the-CSS.patch
Reply to: