Package: release.debian.org Severity: normal User: release.debian.org@packages.debian.org Usertags: unblock This is a pre-approval request before I upload donkey-1.2.0-6 to unstable in order to fix an RC bug. Thanks in advance, and thanks for all your work! [ Reason ] The build of donkey may fail (in fact, will very often fail) due to a problem with the way tmux in control mode sometimes reports a program as finished before actually displaying all of its output. See #990355 for more details. [ Impact ] The donkey source package will most probably FTBFS in unstable and testing. [ Tests ] The change selects a different test driver that, although less sophisticated, is more reliable on systems that support it (which, for Debian, at least judging from the history of building donkey/1.1.0-1, seem to be be linux-*). [ Risks ] Leaf package, very rarely used; the change improves the chances of it building at all, so hopefully very low risk. [ Checklist ] [x] all changes are documented in the d/changelog [x] I reviewed all changes and I approve them [x] attach debdiff against the package in testing unblock donkey/1.2.0-6
diff -Nru donkey-1.2.0/debian/changelog donkey-1.2.0/debian/changelog --- donkey-1.2.0/debian/changelog 2020-05-07 02:51:58.000000000 +0300 +++ donkey-1.2.0/debian/changelog 2021-06-27 01:00:00.000000000 +0300 @@ -1,3 +1,11 @@ +donkey (1.2.0-6) unstable; urgency=medium + + * Use the "pty" test driver to avoid problems with tmux not always + sending us the full output of the command that was run. + Closes: #990355 + + -- Peter Pentchev <roam@debian.org> Sun, 27 Jun 2021 01:00:00 +0300 + donkey (1.2.0-5) unstable; urgency=medium * Disable the "stringop-truncation" GCC warning: our use of strncpy() diff -Nru donkey-1.2.0/debian/rules donkey-1.2.0/debian/rules --- donkey-1.2.0/debian/rules 2020-05-07 02:49:54.000000000 +0300 +++ donkey-1.2.0/debian/rules 2021-06-26 23:24:20.000000000 +0300 @@ -20,7 +20,7 @@ dh_auto_build -D src override_dh_auto_test: - dh_auto_test -D src + dh_auto_test -D src -- TEST_PROCESS_DRIVER=pty override_dh_auto_clean: dh_auto_clean -D src diff -Nru donkey-1.2.0/debian/tests/control donkey-1.2.0/debian/tests/control --- donkey-1.2.0/debian/tests/control 2020-05-07 02:36:51.000000000 +0300 +++ donkey-1.2.0/debian/tests/control 2021-06-26 23:26:32.000000000 +0300 @@ -1,4 +1,4 @@ -Test-Command: env TEST_PROG=/usr/bin/donkey python3 src/test-donkey.py +Test-Command: env TEST_PROCESS_DRIVER=pty TEST_PROG=/usr/bin/donkey python3 src/test-donkey.py Depends: @, python3, python3-ddt, python3-six, tmux Restrictions: allow-stderr Features: test-name=upstream
Attachment:
signature.asc
Description: PGP signature