Control: tags -1 moreinfo On 2021-06-09 20:57:21 +0200, Vincent Bernat wrote: > Package: release.debian.org > Severity: normal > User: release.debian.org@packages.debian.org > Usertags: unblock > X-Debbugs-Cc: Mark Pearson <markpearson@lenovo.com> > > This is a pre-approval for package firmware-sof. > > [ Reason ] > It ships SOF audio firmware signed by Intel and is needed on modern > platforms using SOF. The 1.7 release will be needed to make hardware > that would be released in September work. I have tested the resulting > package on my laptop and it works fine. Mark has tested it on more > laptops and didn't get any problems in the past months with it. We > think it would be better to ship this release with Bullseye to not let > people need to use backports to get a working sound card. > > There are some packaging changes because upstream seems to not have > made its mind with the way firmwares should be installed in > /lib/firmware/intel. Could you also provide us with a binary debdiff to be sure that these changes in d/rules have the desired effect? Cheers > > I am attaching only a debdiff of debian/ since the remaining is mostly > binary files. > > [ Impact ] > No sound out of the box for users with hardware more recent than > September 2021. > > [ Tests ] > Tested on my Thinkpad X1 Carbon Gen7. Tested by Mark on other platforms. > > [ Risks ] > Regression on existing hardware. > > [ Checklist ] > [x] all changes are documented in the d/changelog > [x] I reviewed all changes and I approve them > [x] attach debdiff against the package in testing > > > > diff --git a/debian/changelog b/debian/changelog > index bad2d5f15547..814f5976ef54 100644 > --- a/debian/changelog > +++ b/debian/changelog > @@ -1,3 +1,9 @@ > +firmware-sof (1.7-1) UNRELEASED; urgency=medium > + > + * Update to upstream version 1.7 > + > + -- Mark Pearson <markpearson@lenovo.com> Fri, 09 Apr 2021 21:59:16 -0400 > + > firmware-sof (1.6.1-2) unstable; urgency=medium > > * Remove postinst file as we don't need to add files to initramfs > diff --git a/debian/rules b/debian/rules > index 4012951ae2ad..00e2ae53d553 100755 > --- a/debian/rules > +++ b/debian/rules > @@ -4,11 +4,14 @@ include /usr/share/dpkg/pkg-info.mk > > # Uncomment this to turn on verbose mode. > #export DH_VERBOSE=1 > +export SOF_INSTALL_DIR=$$(pwd)/builddir/usr/lib/firmware/intel > > %: > dh $@ > > override_dh_auto_install: > - mkdir -p $$(pwd)/builddir/usr/lib/firmware > - ROOT=$$(pwd)/builddir/usr SOF_VERSION="v$(DEB_VERSION_UPSTREAM)" ./go.sh > + mkdir -p $(SOF_INSTALL_DIR) > + cp -a sof-v$(DEB_VERSION_UPSTREAM) $(SOF_INSTALL_DIR)/sof > + cp -a sof-tplg-v$(DEB_VERSION_UPSTREAM) $(SOF_INSTALL_DIR) > + ln -s sof-tplg-v$(DEB_VERSION_UPSTREAM) $(SOF_INSTALL_DIR)/sof-tplg > dh_auto_install -- Sebastian Ramacher
Attachment:
signature.asc
Description: PGP signature