[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#989610: unblock: orthanc-webviewer/2.7-4



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package orthanc-webviewer

[ Reason ]
This version fixes issue #989127 (package statically links without using a
Built-Using attribute), that has the "serious" severity.

[ Impact ]
None, as no other package depends on this package.

[ Tests ]
I have run the upstream unit tests, as well as the upstream integration tests.

[ Risks ]
As can be seen in the debdiff, the only modification wrt. the version currently
in testing (orthanc-webviewer/2.7-3) is the addition of the "Built-Using"
attribute on the binary package. So, I see no potential risk.

Many thanks in advance,
Sébastien-

unblock orthanc-webviewer/2.7-4
diff -Nru orthanc-webviewer-2.7/debian/changelog orthanc-webviewer-2.7/debian/changelog
--- orthanc-webviewer-2.7/debian/changelog	2021-02-26 14:41:24.000000000 +0100
+++ orthanc-webviewer-2.7/debian/changelog	2021-06-07 14:21:25.000000000 +0200
@@ -1,3 +1,9 @@
+orthanc-webviewer (2.7-4) unstable; urgency=medium
+
+  * Added missing "Built-Using" attribute. Closes: #989127
+
+ -- Sebastien Jodogne <s.jodogne@gmail.com>  Mon, 07 Jun 2021 14:21:25 +0200
+
 orthanc-webviewer (2.7-3) unstable; urgency=medium
 
   * Statically link against the Orthanc framework
diff -Nru orthanc-webviewer-2.7/debian/control orthanc-webviewer-2.7/debian/control
--- orthanc-webviewer-2.7/debian/control	2021-02-26 14:38:57.000000000 +0100
+++ orthanc-webviewer-2.7/debian/control	2021-06-07 14:21:25.000000000 +0200
@@ -29,6 +29,7 @@
 Depends: ${misc:Depends},
          ${shlibs:Depends},
          orthanc (>= 1.7.1)
+Built-Using: ${orthancframework:Built-Using}
 Description: Web viewer of medical images for Orthanc
  Orthanc Web Viewer is a plugin to Orthanc, a lightweight, RESTful Vendor
  Neutral Archive for medical imaging. It extends Orthanc with an integrated
diff -Nru orthanc-webviewer-2.7/debian/rules orthanc-webviewer-2.7/debian/rules
--- orthanc-webviewer-2.7/debian/rules	2021-02-26 14:41:24.000000000 +0100
+++ orthanc-webviewer-2.7/debian/rules	2021-06-07 14:21:25.000000000 +0200
@@ -26,6 +26,13 @@
 	"-DORTHANC_FRAMEWORK_ADDITIONAL_LIBRARIES=boost_filesystem boost_iostreams boost_locale boost_regex boost_thread jsoncpp pugixml uuid sqlite3" \
 	-DCMAKE_BUILD_TYPE=None   # The build type must be set to None, see #711515
 
+# Automated generation of the "Built-Using" attribute in "d/control"
+# https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=989127
+# Adapted from:
+# https://wiki.debian.org/SIMDEverywhere#Approach (Point 6)
+override_dh_gencontrol:
+	dh_gencontrol -- -Vorthancframework:Built-Using="$(shell dpkg-query -f '$${source:Package} (= $${source:Version}), ' -W liborthancframework-dev)"
+
 override_dh_auto_configure:
         # Place the third-party JavaScript libraries at the location
         # expected by CMake

Reply to: