[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#989198: unblock: webkit2gtk/2.32.1-1



On Fri, May 28, 2021 at 11:18:00AM +0200, Alberto Garcia wrote:

> unblock webkit2gtk/2.32.1-1

This upload introduced a regression (#989332) that should probably be
fixed for bullseye.

WebKitGTK has always used GStreamer internally but the Debian package
only _recommends_ the GStreamer plugins because in theory you can use
the web without them (but forget about audio and video). This has
changed recently and now WebKit assumes that at least the -base and
-good sets of plugins are available, and will abort with an assertion
if e.g there is no audio plugin installed.

In practice I think that the vast majority of users won't hit this
problem because a) those plugins are recommended and apt installs
them by default and b) they are amongst the most common packages on a
desktop environment and required by many other programs.

But it turns out that some people do browse the web with Epiphany and
don't have those plugins installed, so we should probably try to avoid
similar situations.

I would like to move gstreamer1.0-plugins-good from Recommends to
Depends. See the attached patch, in which I also get rid of the
gstreamer1.0-pulseaudio recommendation (now part of plugins-good),
explicity depend on plugins-base (which are implicitly installed
anyway by plugins-good) and recommend plugins-bad (which is needed for
many common video formats).

An alternative would be to patch WebKit (downstream or upstream) to
remove the assertion, or perhaps to use a dummy plugin ('fakesink')
if no other is available. But this change is not necessarily trivial
(WebKit uses many plugins in different places) and I'm not sure that
upstream would be so happy to support that use case (considering that
one can disable several media options at build time).

So if you are ok with the change of dependencies I will upload it to
unstable and request a new unblock.

Regards,

Berto
diff --git a/debian/changelog b/debian/changelog
index 8bc5c0a2183f..7556456f9097 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+webkit2gtk (2.32.1-2) unstable; urgency=high
+
+  * debian/control:
+    + Update the dependencies on GStreamer plugins (Closes: #989332):
+      - WebKitGTK really expects at least the -base and -good sets.
+      - For video playback (e.g YouTube) -bad is also recommended.
+      - The pulseaudio plugin was merged into the -good package.
+
+ -- Alberto Garcia <berto@igalia.com>  Fri, 04 Jun 2021 21:10:02 +0200
+
 webkit2gtk (2.32.1-1) unstable; urgency=medium
 
   * New upstream release.
diff --git a/debian/control b/debian/control
index 7c0b3218f92d..8b1c4197e740 100644
--- a/debian/control
+++ b/debian/control
@@ -138,11 +138,13 @@ Architecture: any
 Multi-Arch: same
 Pre-Depends: ${misc:Pre-Depends}
 Depends: libjavascriptcoregtk-4.0-18 (= ${binary:Version}),
+         gstreamer1.0-plugins-base,
+         gstreamer1.0-plugins-good,
          ${bwrap:Depends},
          ${shlibs:Depends},
          ${misc:Depends}
-Recommends: gstreamer1.0-plugins-good,
-            gstreamer1.0-pulseaudio | gstreamer1.0-alsa,
+Recommends: gstreamer1.0-plugins-bad,
+            gstreamer1.0-alsa,
             gstreamer1.0-gl,
             libgl1-mesa-dri,
             ${bwrap:Recommends},

Reply to: