Package: release.debian.org Severity: normal User: release.debian.org@packages.debian.org Usertags: unblock Please unblock package remmina On May 27, fellow DD Michael Biebl filed #989163 reporting that RDP support under Wayland was badly broken, while perfectly functional under Xorg. [ Reason ] The management of the alpha channel on RDP rendering changed on FreeRDP and it messed up the rendering of output in remmina. [ Impact ] Mainly, unusable desktop remote sessions since the output is so blurry that it becomes hard to manage anything. [ Tests ] Upstream developers and Michael as well provided extensive tests on the patched revision and it works just fine. [ Risks ] The change is trivial (see debdiff for it) and touches only a file in the code. [ Checklist ] [x] all changes are documented in the d/changelog [x] I reviewed all changes and I approve them [x] attach debdiff against the package in testing unblock remmina/1.4.11+dfsg-3 -- Matteo F. Vescovi || Debian Developer GnuPG KeyID: 4096R/0x8062398983B2CF7A
diff -Nru remmina-1.4.11+dfsg/debian/changelog remmina-1.4.11+dfsg/debian/changelog
--- remmina-1.4.11+dfsg/debian/changelog 2021-02-10 22:46:17.000000000 +0100
+++ remmina-1.4.11+dfsg/debian/changelog 2021-06-01 20:40:12.000000000 +0200
@@ -1,3 +1,10 @@
+remmina (1.4.11+dfsg-3) unstable; urgency=medium
+
+ * debian/patches/: patchset updated (Closes: #989163)
+ - 0002-Fix_alpha_channel_issue.patch added
+
+ -- Matteo F. Vescovi <mfv@debian.org> Tue, 01 Jun 2021 20:40:12 +0200
+
remmina (1.4.11+dfsg-2) unstable; urgency=medium
* debian/patches/: patchset updated
diff -Nru remmina-1.4.11+dfsg/debian/patches/0002-Fix_alpha_channel_issue.patch remmina-1.4.11+dfsg/debian/patches/0002-Fix_alpha_channel_issue.patch
--- remmina-1.4.11+dfsg/debian/patches/0002-Fix_alpha_channel_issue.patch 1970-01-01 01:00:00.000000000 +0100
+++ remmina-1.4.11+dfsg/debian/patches/0002-Fix_alpha_channel_issue.patch 2021-06-01 20:30:53.000000000 +0200
@@ -0,0 +1,22 @@
+From: "Matteo F. Vescovi" <mfv@debian.org>
+Date: Tue, 1 Jun 2021 20:30:08 +0200
+Subject: Fix_alpha_channel_issue
+
+Closes: #989163
+---
+ plugins/rdp/rdp_plugin.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/plugins/rdp/rdp_plugin.c b/plugins/rdp/rdp_plugin.c
+index ca937ad..dfad02b 100644
+--- a/plugins/rdp/rdp_plugin.c
++++ b/plugins/rdp/rdp_plugin.c
+@@ -602,7 +602,7 @@ static BOOL remmina_rdp_post_connect(freerdp *instance)
+
+ if (rfi->bpp == 32) {
+ freerdp_local_color_format = PIXEL_FORMAT_BGRA32;
+- rfi->cairo_format = CAIRO_FORMAT_ARGB32;
++ rfi->cairo_format = CAIRO_FORMAT_RGB24;
+ } else if (rfi->bpp == 24) {
+ /* CAIRO_FORMAT_RGB24 is 32bit aligned, so we map it to libfreerdp’s PIXEL_FORMAT_BGRX32 */
+ freerdp_local_color_format = PIXEL_FORMAT_BGRX32;
diff -Nru remmina-1.4.11+dfsg/debian/patches/series remmina-1.4.11+dfsg/debian/patches/series
--- remmina-1.4.11+dfsg/debian/patches/series 2021-02-10 22:44:05.000000000 +0100
+++ remmina-1.4.11+dfsg/debian/patches/series 2021-06-01 20:30:53.000000000 +0200
@@ -1 +1,2 @@
0001-Revert-rdp-event-Fix-wheel-value-for-GDK_SCROLL_DOWN.patch
+0002-Fix_alpha_channel_issue.patch
Attachment:
signature.asc
Description: PGP signature