[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#989275: marked as done (unblock: todo.txt-base/2.4)

Your message dated Mon, 31 May 2021 20:40:04 +0200
with message-id <YLUthEkOOCEwveLY@ramacher.at>
and subject line Re: Bug#989275: unblock: todo.txt-base/2.4
has caused the Debian Bug report #989275,
regarding unblock: todo.txt-base/2.4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
989275: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=989275
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package todo.txt-base

The todo.txt-base package is missing a dependency for
ConfigArgParse/python3-configargparse. This causes failure of the
backuptodo command, and can add an error message to all topydo actions.

[ Reason ]
Add a missing dependency to the todo.txt-base package.

[ Impact ]
Failure of the todo.txt-base package functionality, and an error message
with every action taken in topydo.

[ Tests ]
An autopkgtest has been added which has verified the failure, and verifies the fix. 

[ Risks ]
Minimal risk to the deb itself - it's just an added dependency.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]
No

unblock todo.txt-base/2.4

diff -Nru todo.txt-base-2.3/debian/changelog todo.txt-base-2.4/debian/changelog
--- todo.txt-base-2.3/debian/changelog	2021-02-19 21:58:40.000000000 -0500
+++ todo.txt-base-2.4/debian/changelog	2021-05-29 16:56:23.000000000 -0400
@@ -1,3 +1,9 @@
+todo.txt-base (2.4) unstable; urgency=medium
+
+  * Add dependency to configargparse (Closes: #989156).
+
+ -- David Steele <steele@debian.org>  Sat, 29 May 2021 16:56:23 -0400
+
 todo.txt-base (2.3) unstable; urgency=medium
 
   * Speed-up application launch.
diff -Nru todo.txt-base-2.3/debian/tests/control todo.txt-base-2.4/debian/tests/control
--- todo.txt-base-2.3/debian/tests/control	2021-02-19 21:58:40.000000000 -0500
+++ todo.txt-base-2.4/debian/tests/control	2021-05-29 16:56:23.000000000 -0400
@@ -1,3 +1,3 @@
 
-Tests: test-helper.py, test-todo.py
+Tests: test-helper.py, test-todo.py, test-backup.py
 Depends: @, topydo
diff -Nru todo.txt-base-2.3/debian/tests/test-backup.py todo.txt-base-2.4/debian/tests/test-backup.py
--- todo.txt-base-2.3/debian/tests/test-backup.py	1969-12-31 19:00:00.000000000 -0500
+++ todo.txt-base-2.4/debian/tests/test-backup.py	2021-05-29 16:56:23.000000000 -0400
@@ -0,0 +1,25 @@
+#!/bin/sh
+
+set -e
+
+if [ -z "$AUTOPKGTEST_ARTIFACTS" ] ; then
+  BASEDIR=/tmp
+else
+  BASEDIR=$AUTOPKGTEST_ARTIFACTS
+fi
+
+TESTDIR="$BASEDIR"/backuptest
+rm -rf "$TESTDIR"
+mkdir "$TESTDIR"
+
+TODO="$TESTDIR"/todo.txt
+echo "Foo" > "$TODO"
+
+BACKUPDIR="$TESTDIR/backup"
+mkdir "$BACKUPDIR"
+
+backuptodo -f "$TODO" -b "$BACKUPDIR"
+
+cat "$BACKUPDIR"/* | grep -q "Foo"
+
+echo "Test complete"
diff -Nru todo.txt-base-2.3/setup.py todo.txt-base-2.4/setup.py
--- todo.txt-base-2.3/setup.py	2021-02-19 21:58:40.000000000 -0500
+++ todo.txt-base-2.4/setup.py	2021-05-29 16:56:23.000000000 -0400
@@ -7,7 +7,7 @@
 
 setup(
     name="todo_txt_base",
-    version="1.0",
+    version="2.4",
     description="foo",
     url="https://example.com";,
     author="David Steele",
@@ -26,7 +26,7 @@
             ],
     },
     setup_requires=["pytest-runner"],
-    install_requires=["relatorio"],
+    install_requires=["relatorio", "ConfigArgParse"],
     tests_require=["pytest"],
     classifiers=[
         "Environment :: Console",

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message --- 
On 2021-05-30 18:15:33 -0400, David Steele wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package todo.txt-base
> 
> The todo.txt-base package is missing a dependency for
> ConfigArgParse/python3-configargparse. This causes failure of the
> backuptodo command, and can add an error message to all topydo actions.
> 
> [ Reason ]
> Add a missing dependency to the todo.txt-base package.
> 
> [ Impact ]
> Failure of the todo.txt-base package functionality, and an error message
> with every action taken in topydo.
> 
> [ Tests ]
> An autopkgtest has been added which has verified the failure, and verifies
> the fix.
> 
> [ Risks ]
> Minimal risk to the deb itself - it's just an added dependency.
> 
> [ Checklist ]
>   [x] all changes are documented in the d/changelog
>   [x] I reviewed all changes and I approve them
>   [x] attach debdiff against the package in testing
> 
> [ Other info ]
> No
> 
> unblock todo.txt-base/2.4

The autopkgtest succeeds and the package is not on the list of key
packages. It will migrated without our interaction.

Added a hint reduce the age requirement to 7 days.

Cheers


> diff -Nru todo.txt-base-2.3/debian/changelog todo.txt-base-2.4/debian/changelog
> --- todo.txt-base-2.3/debian/changelog	2021-02-19 21:58:40.000000000 -0500
> +++ todo.txt-base-2.4/debian/changelog	2021-05-29 16:56:23.000000000 -0400
> @@ -1,3 +1,9 @@
> +todo.txt-base (2.4) unstable; urgency=medium
> +
> +  * Add dependency to configargparse (Closes: #989156).
> +
> + -- David Steele <steele@debian.org>  Sat, 29 May 2021 16:56:23 -0400
> +
>  todo.txt-base (2.3) unstable; urgency=medium
>  
>    * Speed-up application launch.
> diff -Nru todo.txt-base-2.3/debian/tests/control todo.txt-base-2.4/debian/tests/control
> --- todo.txt-base-2.3/debian/tests/control	2021-02-19 21:58:40.000000000 -0500
> +++ todo.txt-base-2.4/debian/tests/control	2021-05-29 16:56:23.000000000 -0400
> @@ -1,3 +1,3 @@
>  
> -Tests: test-helper.py, test-todo.py
> +Tests: test-helper.py, test-todo.py, test-backup.py
>  Depends: @, topydo
> diff -Nru todo.txt-base-2.3/debian/tests/test-backup.py todo.txt-base-2.4/debian/tests/test-backup.py
> --- todo.txt-base-2.3/debian/tests/test-backup.py	1969-12-31 19:00:00.000000000 -0500
> +++ todo.txt-base-2.4/debian/tests/test-backup.py	2021-05-29 16:56:23.000000000 -0400
> @@ -0,0 +1,25 @@
> +#!/bin/sh
> +
> +set -e
> +
> +if [ -z "$AUTOPKGTEST_ARTIFACTS" ] ; then
> +  BASEDIR=/tmp
> +else
> +  BASEDIR=$AUTOPKGTEST_ARTIFACTS
> +fi
> +
> +TESTDIR="$BASEDIR"/backuptest
> +rm -rf "$TESTDIR"
> +mkdir "$TESTDIR"
> +
> +TODO="$TESTDIR"/todo.txt
> +echo "Foo" > "$TODO"
> +
> +BACKUPDIR="$TESTDIR/backup"
> +mkdir "$BACKUPDIR"
> +
> +backuptodo -f "$TODO" -b "$BACKUPDIR"
> +
> +cat "$BACKUPDIR"/* | grep -q "Foo"
> +
> +echo "Test complete"
> diff -Nru todo.txt-base-2.3/setup.py todo.txt-base-2.4/setup.py
> --- todo.txt-base-2.3/setup.py	2021-02-19 21:58:40.000000000 -0500
> +++ todo.txt-base-2.4/setup.py	2021-05-29 16:56:23.000000000 -0400
> @@ -7,7 +7,7 @@
>  
>  setup(
>      name="todo_txt_base",
> -    version="1.0",
> +    version="2.4",
>      description="foo",
>      url="https://example.com";,
>      author="David Steele",
> @@ -26,7 +26,7 @@
>              ],
>      },
>      setup_requires=["pytest-runner"],
> -    install_requires=["relatorio"],
> +    install_requires=["relatorio", "ConfigArgParse"],
>      tests_require=["pytest"],
>      classifiers=[
>          "Environment :: Console",





-- 
Sebastian Ramacher

Attachment: signature.asc
Description: PGP signature


--- End Message ---
Reply to: