Control: tags -1 moreinfo confirmed
On 2021-05-26 17:24:24 +0200, Étienne Mollier wrote:
> Control: tags -1 - moreinfo
>
> Hi Sebastian,
>
> Sebastian Ramacher, on 2021-05-25:
> > Something seems to be wrong with the autopkgtests. They are not run.
> > Could you please check what's wrong there? Once fixed, vtk-dicom will be
> > able to migrate without an unblock.
>
> Thanks for you review! It looks like I have been overly
> cautious when doing my checks and got caught by my forceful
> autopkgtest run when building packages. What seems to happen is
> that the d/control file misses a Testsuite field, while
> autodep8(1) manual says it must be present, thus I suspect debci
> is not considering any test in the package.
>
> I prepared another iteration, 0.8.12-4, in which I only add said
> field. Assuming it does the right thing, it will need sponsored
> upload, and since the autodep8 is superficial in the present
> case, it would also need an unblock. To make sure I'm stepping
> in the right direction, may I enquire for a pre-approval?
ACK, please remove the moreinfo tag once the new version is available in
unstable.
Cheers
>
> The debdiff should be in attachment, and the source code
> available on Salsa[1].
>
> [1]: https://salsa.debian.org/med-team/vtk-dicom
>
> Have a nice day, :)
> --
> Étienne Mollier <etienne.mollier@mailoo.org>
> Fingerprint: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da
> Sent from /dev/tty1, please excuse my verbosity.
> diff -Nru vtk-dicom-0.8.12/debian/changelog vtk-dicom-0.8.12/debian/changelog
> --- vtk-dicom-0.8.12/debian/changelog 2019-12-22 14:42:19.000000000 +0100
> +++ vtk-dicom-0.8.12/debian/changelog 2021-05-26 16:50:42.000000000 +0200
> @@ -1,3 +1,27 @@
> +vtk-dicom (0.8.12-4) unstable; urgency=medium
> +
> + * Team upload.
> + * Trigger autodep8 autopkgtest-pkg-python test explicitly, to enable CI, per
> + discussion on unblock request #989006
> +
> + -- Étienne Mollier <etienne.mollier@mailoo.org> Wed, 26 May 2021 16:50:42 +0200
> +
> +vtk-dicom (0.8.12-3) unstable; urgency=medium
> +
> + * Team upload.
> + * d/{python3-vtk-dicom,not-installed}: do not install libvtkDICOMPython*.so
> + Closes: #988643
> +
> + -- Étienne Mollier <etienne.mollier@mailoo.org> Sat, 22 May 2021 15:08:12 +0200
> +
> +vtk-dicom (0.8.12-2) unstable; urgency=medium
> +
> + * Team upload.
> + * Fix autopkgtest. Thanks for the patch to Étienne Mollier.
> + Closes: #988745
> +
> + -- Andreas Tille <tille@debian.org> Wed, 19 May 2021 15:30:05 +0200
> +
> vtk-dicom (0.8.12-1) unstable; urgency=medium
>
> * New upstream version 0.8.12
> diff -Nru vtk-dicom-0.8.12/debian/control vtk-dicom-0.8.12/debian/control
> --- vtk-dicom-0.8.12/debian/control 2019-12-22 14:42:19.000000000 +0100
> +++ vtk-dicom-0.8.12/debian/control 2021-05-25 20:16:03.000000000 +0200
> @@ -19,6 +19,7 @@
> Vcs-Browser: https://salsa.debian.org/med-team/vtk-dicom
> Vcs-Git: https://salsa.debian.org/med-team/vtk-dicom.git
> Homepage: http://github.com/dgobbi/vtk-dicom/
> +Testsuite: autopkgtest-pkg-python
>
> Package: libvtk-dicom-dev
> Architecture: any
> diff -Nru vtk-dicom-0.8.12/debian/not-installed vtk-dicom-0.8.12/debian/not-installed
> --- vtk-dicom-0.8.12/debian/not-installed 1970-01-01 01:00:00.000000000 +0100
> +++ vtk-dicom-0.8.12/debian/not-installed 2021-05-22 14:38:32.000000000 +0200
> @@ -0,0 +1,2 @@
> +# Linker name of Python module primitives probably not needed. See #988643.
> +usr/lib/*/libvtkDICOMPython*.so
> diff -Nru vtk-dicom-0.8.12/debian/python3-vtk-dicom.install vtk-dicom-0.8.12/debian/python3-vtk-dicom.install
> --- vtk-dicom-0.8.12/debian/python3-vtk-dicom.install 2019-12-22 14:42:19.000000000 +0100
> +++ vtk-dicom-0.8.12/debian/python3-vtk-dicom.install 2021-05-22 14:32:04.000000000 +0200
> @@ -1,5 +1,4 @@
> #!/usr/bin/dh-exec
> usr/lib/*/libvtkDICOMPython*.so.*
> -usr/lib/*/libvtkDICOMPython*.so usr/lib/python${PYVER}/dist-packages
> usr/lib/*/vtkDICOMPython*.so usr/lib/python${PYVER}/dist-packages
>
> diff -Nru vtk-dicom-0.8.12/debian/tests/autopkgtest-pkg-python.conf vtk-dicom-0.8.12/debian/tests/autopkgtest-pkg-python.conf
> --- vtk-dicom-0.8.12/debian/tests/autopkgtest-pkg-python.conf 1970-01-01 01:00:00.000000000 +0100
> +++ vtk-dicom-0.8.12/debian/tests/autopkgtest-pkg-python.conf 2021-05-19 22:40:52.000000000 +0200
> @@ -0,0 +1 @@
> +import_name = vtkDICOMPython
--
Sebastian Ramacher
Attachment:
signature.asc
Description: PGP signature