Control: tags -1 moreinfo
On 2021-05-23 09:45:15 +0200, Étienne Mollier wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
>
> Good day,
>
> Please unblock package vtk-dicom
>
> [ Reason ]
> The version in unstable addresses RC bugs #988643 and #988745
> affecting vtk-dicom in bullseye.
>
> [ Impact ]
> If the situation is left as is, then:
> * users of python3-vtk-dicom will see a dangling link in
> dist-packages/, and think this is a broken Python module;
> * users willing to check the integrity of the package through
> autopkgtest will see test failures due to improper module
> being called by autodep8-python3.
>
> [ Tests ]
> Tests I carried on are:
> * the usual package building and autopkgtest on amd64;
> * piuparts --fail-on-broken-symlinks to make sure #988643 is
> resolved;
> * running a test script I found in the source code, in the
> file Testing/TestDICOMPython.py, a wee bit less superficial
> than the autodep8 import.
>
> [ Risks ]
> Almost zero risk of regression, only a dangling link is removed,
> and the test suite is adjusted.
>
> [ Checklist ]
> [*] all changes are documented in the d/changelog
> [*] I reviewed all changes and I approve them
> [*] attach debdiff against the package in testing
>
> unblock vtk-dicom/0.8.12-3
>
> Have a nice day, :)
> --
> Étienne Mollier <etienne.mollier@mailoo.org>
> Fingerprint: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da
> Sent from /dev/pts/3, please excuse my verbosity.
> diff -Nru vtk-dicom-0.8.12/debian/changelog vtk-dicom-0.8.12/debian/changelog
> --- vtk-dicom-0.8.12/debian/changelog 2019-12-22 14:42:19.000000000 +0100
> +++ vtk-dicom-0.8.12/debian/changelog 2021-05-22 15:08:12.000000000 +0200
> @@ -1,3 +1,19 @@
> +vtk-dicom (0.8.12-3) unstable; urgency=medium
> +
> + * Team upload.
> + * d/{python3-vtk-dicom,not-installed}: do not install libvtkDICOMPython*.so
> + Closes: #988643
> +
> + -- Étienne Mollier <etienne.mollier@mailoo.org> Sat, 22 May 2021 15:08:12 +0200
> +
> +vtk-dicom (0.8.12-2) unstable; urgency=medium
> +
> + * Team upload.
> + * Fix autopkgtest. Thanks for the patch to Étienne Mollier.
> + Closes: #988745
Something seems to be wrong with the autopkgtests. They are not run.
Could you please check what's wrong there? Once fixed, vtk-dicom will be
able to migrate without an unblock.
Cheers
> +
> + -- Andreas Tille <tille@debian.org> Wed, 19 May 2021 15:30:05 +0200
> +
> vtk-dicom (0.8.12-1) unstable; urgency=medium
>
> * New upstream version 0.8.12
> diff -Nru vtk-dicom-0.8.12/debian/not-installed vtk-dicom-0.8.12/debian/not-installed
> --- vtk-dicom-0.8.12/debian/not-installed 1970-01-01 01:00:00.000000000 +0100
> +++ vtk-dicom-0.8.12/debian/not-installed 2021-05-22 15:08:12.000000000 +0200
> @@ -0,0 +1,2 @@
> +# Linker name of Python module primitives probably not needed. See #988643.
> +usr/lib/*/libvtkDICOMPython*.so
> diff -Nru vtk-dicom-0.8.12/debian/python3-vtk-dicom.install vtk-dicom-0.8.12/debian/python3-vtk-dicom.install
> --- vtk-dicom-0.8.12/debian/python3-vtk-dicom.install 2019-12-22 14:42:19.000000000 +0100
> +++ vtk-dicom-0.8.12/debian/python3-vtk-dicom.install 2021-05-22 15:08:12.000000000 +0200
> @@ -1,5 +1,4 @@
> #!/usr/bin/dh-exec
> usr/lib/*/libvtkDICOMPython*.so.*
> -usr/lib/*/libvtkDICOMPython*.so usr/lib/python${PYVER}/dist-packages
> usr/lib/*/vtkDICOMPython*.so usr/lib/python${PYVER}/dist-packages
>
> diff -Nru vtk-dicom-0.8.12/debian/tests/autopkgtest-pkg-python.conf vtk-dicom-0.8.12/debian/tests/autopkgtest-pkg-python.conf
> --- vtk-dicom-0.8.12/debian/tests/autopkgtest-pkg-python.conf 1970-01-01 01:00:00.000000000 +0100
> +++ vtk-dicom-0.8.12/debian/tests/autopkgtest-pkg-python.conf 2021-05-22 15:08:12.000000000 +0200
> @@ -0,0 +1 @@
> +import_name = vtkDICOMPython
--
Sebastian Ramacher
Attachment:
signature.asc
Description: PGP signature