[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#988873: unblock: tomboy-ng/0.32-2



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package tomboy-ng


[ Reason ]
a)
My sponsee, the upstream developer and maintainer of tomboy ng,
recently informed me that tomboy-ng in Debian is unintentially built as a
GTK2 app instead of a Qt5 app, a fact that I also missed during my reviews.

Considering the current stage of Bullseye's release I advised him to
simply fix the (Build-)Depends and package description, because changing
to Qt5 now would result in a completely different binary package.

b)
The recent removal of libappindicator3 from Bullseye makes tomboy-ng difficult
to use for Gnome desktop users, this is addressed by a patch updating a help
document.

[ Impact ]
The package pulls in unnecessary Qt5 deps and lacks important documentation for
Gnome desktop users.

[ Tests ]
There are no changes to executable code what so ever. All changes are
to package config (descriptive) and to a single help document.

[ Risks ]
Minimal. This application is not depended on by any other packages, has
a limited user base. Executable and its installed config have not
changed.


[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

[ Other info ]
If you prefer a switch to the Qt5 version of tomboy-ng instead of sticking with
the GTK2 version for Bullseye, just let us know.
That change is currently planned for after the Bullseye release.


unblock tomboy-ng/0.32-2
diff -Nru tomboy-ng-0.32/debian/changelog tomboy-ng-0.32/debian/changelog
--- tomboy-ng-0.32/debian/changelog	2021-02-03 04:22:58.000000000 +0100
+++ tomboy-ng-0.32/debian/changelog	2021-05-19 09:09:18.000000000 +0200
@@ -1,3 +1,10 @@
+tomboy-ng (0.32-2) unstable; urgency=medium
+
+  * debian/control: Correct (Build-)Depends and long package description
+  * debian/patches: Update documentation regarding missing libappindicator3
+
+ -- David Bannon <tomboy-ng@bannons.id.au>  Wed, 19 May 2021 17:09:18 +1000
+
 tomboy-ng (0.32-1) unstable; urgency=medium
 
   * New Version Release
diff -Nru tomboy-ng-0.32/debian/control tomboy-ng-0.32/debian/control
--- tomboy-ng-0.32/debian/control	2021-02-03 04:22:58.000000000 +0100
+++ tomboy-ng-0.32/debian/control	2021-05-19 09:09:18.000000000 +0200
@@ -3,7 +3,7 @@
 Priority: optional
 Maintainer: David Bannon <tomboy-ng@bannons.id.au>
 Rules-Requires-Root: no
-Build-Depends: debhelper-compat (=13), binutils, libx11-dev, libqt5pas-dev, libnotify-dev, fpc (>=3.0.4), lazarus (>=2.0.6), lcl-qt5
+Build-Depends: debhelper-compat (=13), binutils, libgtk2.0-dev, libx11-dev, libnotify-dev, fpc (>=3.0.4), lazarus (>=2.0.6)
 Standards-Version: 4.5.1
 Vcs-Browser: https://github.com/tomboy-notes/tomboy-ng
 Vcs-Git: https://github.com/tomboy-notes/tomboy-ng.git
@@ -13,9 +13,9 @@
 Provides: tomboy-ng
 Architecture: any
 Multi-Arch: foreign
-Depends: libqt5pas1, ${shlibs:Depends}, wmctrl, ${misc:Depends}
+Depends: ${shlibs:Depends}, libcanberra-gtk-module, wmctrl, ${misc:Depends}
 Description: Tomboy Notes rewritten to ease installation and cross platform
  tomboy-ng notes allows easy management of a large or small set of
  notes. Notes can contain a range of font sizes, bold, italic and highlight.
  Available for Linux, Windows amd Mac and easy sync between them.
- This is the Qt5 based version.
+ This is the GTK2 based version.
diff -Nru tomboy-ng-0.32/debian/patches/note-missing-libappindicator3.patch tomboy-ng-0.32/debian/patches/note-missing-libappindicator3.patch
--- tomboy-ng-0.32/debian/patches/note-missing-libappindicator3.patch	1970-01-01 01:00:00.000000000 +0100
+++ tomboy-ng-0.32/debian/patches/note-missing-libappindicator3.patch	2021-05-19 09:09:18.000000000 +0200
@@ -0,0 +1,78 @@
+Description: <note for end user about missing libappindicator>
+ Since tomboy-ng 0.32-1 was released, Debian has dropped
+ libappindicator3-1. This means that an end user using the
+ Gnome Desktop will not see the necessary SysTray Icon.
+ So, change an existing help note to point them in the right direction.
+ IMPORTANT - This patch does not alter any source or executable code.
+ .
+ tomboy-ng (0.32-2) unstable; urgency=medium
+ .
+   * doc libappindicator issues
+ Author: David Bannon <tomboy-ng@bannons.id.au>
+
+ Bug-Debian: https://bugs.debian.org/895037
+
+ Last-Update: 2021-05-19
+
+--- tomboy-ng-0.32.orig/doc/HELP/EN/systray.note
++++ tomboy-ng-0.32/doc/HELP/EN/systray.note
+@@ -3,38 +3,36 @@
+   <title>System Tray on Linux</title>
+   <text xml:space="preserve"><note-content version="0.1"><underline>System Tray on Linux</underline>
+ 
+-Note : the message about not showing the SysTray is usually a false alarm <bold>on Ubuntu</bold>. Sorry.
+ 
+-The normal way that  a user interacts with tomboy-ng is via a small yellow icon that appears on the System Tray, sometimes called the notification area. However, not all Linux Desktop Environments are able to display System Tray Icons, and some that can do not do so by default. 
++The normal way that  a user interacts with tomboy-ng is via a small yellow icon that appears on the System Tray, sometimes called the notification area. However, not all Linux Desktop Environments are able to display System Tray Icons, and some that can may not do so by default. 
+ 
+-If you can see a small, yellow icon, possibly upper right of your screen, you don't have a problem, well done in choosing a user focused Desktop. If you cannot see it, you are probably using a Desktop that may not display the System Tray. Firstly, see if your particular Desktop just needs to configured to display a SysTray, failing that,  you have a number of alternatives -<size:large>
++If you can see a <bold>small, yellow icon</bold>, possibly upper right of your screen, you don't have a problem, well done in choosing a user focused Desktop. If you cannot see it, you are probably using a Desktop that may not display the System Tray, possibly a Gnome Desktop.  Firstly, see if your particular Desktop just needs to configured to display a SysTray, failing that,  read on. 
+ 
+-<bold>tint2</bold></size:large>
+-Install the very useful tint2 panel. It has no trouble displaying a System Tray on all Linux Desktops that I have tested. It seems to be widely available. Typically, you might type one of the following command in your terminal - 
++Here I mention Fedora and Debian, same comments apply to derivative distributions. Ubuntu is not a problem.
+ 
+-<monospace>sudo yum install tint2 </monospace>
+-<monospace>sudo dnf install tint2</monospace>
+-<monospace>sudo apt install tint2</monospace>
++Firstly, both Fedora Gnome and Debian Gnome <bold>can</bold> display the SysTray Icon, they just need the appropriate libappindicator library and the Gnome plugin, gnome-shell-extension-appindicator, installed and enabled. <size:large>
+ 
+-Start tint2 before you start work and if you like that model, add it to your startup applications.<size:large>
++<bold>Debian Gnome</bold></size:large>
++Debian Bullseye is currently in testing and will shortly become the release version. Earlier versions work fine but Bullseye with Gnome has a problem because Debian has dropped libappindicator3-1 and replaced it with libayatana-appindicator3-1. So, if you use Gnome Desktop, please manually install libayatana-appindicator3-1 and gnome-shell-extension-appindicator and log out and back in again.   When you next startup tomboy-ng, it will ask if you want the plugin enabled, answer yes.  Note, you can enable and disable the plugin with the gnome-extensions command.
+ 
+-<bold>Using your dock</bold></size:large>
+-Gnome 3 typically has a 'dock' down the left side, maybe only visible after you click Activities'.  Some other Desktops have similar docks. After starting tomboy-ng (the first time), and before you 'hide' it, find its yellow Icon in your dock. Right click it and choose add to favourites. You can now 'Hide' the tomboy-ng splash screen and activate tomboy-ng at any time directly from the dock. To close tomboy-ng completely, click the tomboy-ng icon in the dock, tomboy-ng's search box opens, click 'Menu' and 'close'. <size:large>
++Versions of tomboy-ng earlier than 0.32f are not aware of ayatana, see suggestions on https://github.com/davidbannon/libappindicator3 <size:large>
+ 
+-<bold>Other Approaches </bold></size:large>
+-Similarly to the above approach, if you start tomboy-ng and hide it, you can activate it at any time from the Menu you normally use to start an application.  In this way, you are not restarting it each time, its always there, the restart attempt just prompts the running instance to pop up its Search Window.
+-  
+-There are some Gnome Extensions that you can install to restore a functioning System Tray but especially if you are using Wayland they may be just too hard. But if you are willing to disable wayland and use xorg instead, that just might work. Search for TopIconsPlus.
++<bold>Fedora Gnome</bold></size:large>
++Install gnome-shell-extension-appindicator (that will also install libappindicator-gtk3), log out and back in, start tomboy-ng and answer 'yes' when asked about enabling the plugin. <size:large>
++
++<bold>OpenSuse</bold></size:large>
++TBD
+ 
+ </note-content></text>
+-  <last-change-date>2021-02-01T18:48:56.2321715+11:00</last-change-date>
+-  <last-metadata-change-date>2021-02-01T18:48:56.2321715+11:00</last-metadata-change-date>
++  <last-change-date>2021-05-19T14:09:05.3138925+10:00</last-change-date>
++  <last-metadata-change-date>2021-05-19T14:09:05.3138925+10:00</last-metadata-change-date>
+   <create-date>2021-01-23T13:48:35.2369237+11:00</create-date>
+   <cursor-position>1</cursor-position>
+   <selection-bound-position>1</selection-bound-position>
+-  <width>912</width>
+-  <height>497</height>
+-  <x>847</x>
+-  <y>292</y>
++  <width>1227</width>
++  <height>610</height>
++  <x>108</x>
++  <y>195</y>
+   <open-on-startup>False</open-on-startup>
+-</note>
+\ No newline at end of file
++</note>
++
diff -Nru tomboy-ng-0.32/debian/patches/series tomboy-ng-0.32/debian/patches/series
--- tomboy-ng-0.32/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ tomboy-ng-0.32/debian/patches/series	2021-05-19 09:09:18.000000000 +0200
@@ -0,0 +1 @@
+note-missing-libappindicator3.patch

Reply to: