[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#987982: marked as done (unblock: etbemon/1.3.5-5)



Your message dated Tue, 04 May 2021 09:20:59 +0000
with message-id <E1ldrEh-0003BV-PU@respighi.debian.org>
and subject line unblock etbemon
has caused the Debian Bug report #987982,
regarding unblock: etbemon/1.3.5-5
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
987982: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=987982
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package etbemon

[ Reason ]
This makes the shared object checks more useful and made the IMAP check
correctly handle mixed case in headers.

[ Impact ]
The shared object checks are much less useful and the IMAP checks
can fail in unexpected ways (falsely reporting errors).

[ Tests ]
I have manually tested this and installed them on my production servers.

[ Risks ]
The code has trivial changes that are easy to inspect.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

[ Other info ]

unblock etbemon/1.3.5-5

Here is the debdiff:

diff -u etbemon-1.3.5/debian/changelog etbemon-1.3.5/debian/changelog
--- etbemon-1.3.5/debian/changelog
+++ etbemon-1.3.5/debian/changelog
@@ -1,3 +1,13 @@
+etbemon (1.3.5-5) unstable; urgency=medium
+
+  * Make the deleted-mapped check avoid perl privsep processes, don't want
+    to force users to logout to pass the check
+  * Made imapnew.monitor give a correct error when a message has no Message-Id
+    also made it do case-insensitive checks on header field names.  Now
+    recommends libhash-case-perl as imapnew.monitor depends on it.
+
+ -- Russell Coker <russell@coker.com.au>  Mon, 05 Apr 2021 18:28:52 +1000
+
 etbemon (1.3.5-4) unstable; urgency=medium
 
   * Make deleted-mapped.monitor skip programs starting with /lib/systemd/system.
diff -u etbemon-1.3.5/mon-local.d/deleted-mapped.monitor.real etbemon-1.3.5/mon-local.d/deleted-mapped.monitor.real
--- etbemon-1.3.5/mon-local.d/deleted-mapped.monitor.real
+++ etbemon-1.3.5/mon-local.d/deleted-mapped.monitor.real
@@ -29,6 +29,16 @@
     next;
   }
 
+  if($proc_name =~ /^\/usr\/sbin\/sshd/ && open(CMD, "</proc/$pid_num/cmdline"))
+  {
+    my $name = <CMD>;
+    close(CMD);
+    if($name =~ /sshd: [a-z][a-z0-9]* .priv/)
+    {
+      next;
+    }
+  }
+
   my ($dev,$ino,$mode,$nlink,$uid,$gid,$rdev,$size,$atime,$mtime,$ctime,$blksize,$blocks)
        = stat("/proc/$pid_num");
   if($uid > $opt_u)
only in patch2:
unchanged:
--- etbemon-1.3.5.orig/debian/control
+++ etbemon-1.3.5/debian/control
@@ -13,7 +13,7 @@
 Package: mon
 Architecture: any
 Depends: mon-client (>= 1.2.0), libtime-period-perl, adduser, ${shlibs:Depends}, ${misc:Depends}
-Recommends: fping, libauthen-pam-perl, libfilesys-df-perl, libnet-perl, libnet-dns-perl, libnet-ldap-perl, libnet-telnet-perl, libsnmp-perl, libstatistics-descriptive-perl, libtime-parsedate-perl, libcrypt-ssleay-perl, libmail-imapclient-perl, libtimedate-perl, swaks, libcgi-pm-perl, bc, libproc-processtable-perl, libsys-filesystem-perl
+Recommends: fping, libauthen-pam-perl, libfilesys-df-perl, libnet-perl, libnet-dns-perl, libnet-ldap-perl, libnet-telnet-perl, libsnmp-perl, libstatistics-descriptive-perl, libtime-parsedate-perl, libcrypt-ssleay-perl, libmail-imapclient-perl, libtimedate-perl, swaks, libcgi-pm-perl, bc, libproc-processtable-perl, libsys-filesystem-perl, libhash-case-perl
 Suggests: mon-contrib
 Conflicts: mon-contrib (<= 1.0+dfsg-3+nmu1)
 Description: monitor hosts/services/whatever and alert about problems
only in patch2:
unchanged:
--- etbemon-1.3.5.orig/mon.d/imapnew.monitor
+++ etbemon-1.3.5/mon.d/imapnew.monitor
@@ -1,5 +1,6 @@
 #!/usr/bin/perl
 use strict;
+use Hash::Case::Preserve;
 
 # needs package libmail-imapclient-perl on Debian
 
@@ -132,7 +133,9 @@
     $newcount++;
   }
 
-  my %headers = %{ $imap->parse_headers( $msg, "ALL" ) };
+  my %headers;
+  tie my(%headers), 'Hash::Case::Preserve';
+  %headers = %{ $imap->parse_headers( $msg, "ALL" ) };
   my @received = @{ $headers{Received} };
   my @rec_date;
   my @rec_host;
@@ -153,6 +156,11 @@
   push(@rec_host, "Sender");
 
   my @subject = @{ $headers{Subject} };
+  if(not $headers{'Message-Id'})
+  {
+    print "message without Message-Id header (subject @subject)\n";
+    exit(1);
+  }
   my @msgid = @{ $headers{'Message-Id'} };
 
 

--- End Message ---
--- Begin Message ---
Unblocked.

--- End Message ---

Reply to: