[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#987556: marked as done (unblock: stopmotion/0.8.5-3)

Your message dated Sun, 25 Apr 2021 19:40:57 +0200
with message-id <881d403a-40a0-7a58-e1bd-3a11a1a1384a@debian.org>
and subject line Re: Bug#987556: unblock: stopmotion/0.8.5-3
has caused the Debian Bug report #987556,
regarding unblock: stopmotion/0.8.5-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
987556: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=987556
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package stopmotion

[ Reason ]

Change '%s' to %s in stopmotion.mime

[ Impact ]

Minor security issue.

[ Tests ]

n/a

[ Risks ]

Leaf package. Changing '%s' to %s is the only substantive change.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

unblock stopmotion/0.8.5-3

----------------------------------------------------------------

$ git diff debian/0.8.5-2..debian/0.8.5-3
diff --git a/debian/changelog b/debian/changelog
index af0fe4a..ecfbbd6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+stopmotion (0.8.5-3) unstable; urgency=medium
+
+  * bump policy, no changes required
+  * bump to debhelper 13
+  * Fix day-of-week for changelog entry 0.pre3.4-1
+  * Add pithy comment to debian/watch
+  * stop quoting %s in mimecap entry (closes: #987415)
+
+ -- Barak A. Pearlmutter <bap@debian.org>  Fri, 23 Apr 2021 20:56:40 +0100
+
 stopmotion (0.8.5-2) unstable; urgency=medium
 
   * hack around integer size mismatch to std::min() on 32-bit systems
@@ -466,7 +476,7 @@ stopmotion (0.pre3.4-1) unstable; urgency=low
 
   * Fixed a bug when removing scenes
 
- -- Bjoern Erik Nilsen <bjoern.nilsen@hig.no>  Tue, 25 Apr 2005 17:12:36 +0200
+ -- Bjoern Erik Nilsen <bjoern.nilsen@hig.no>  Mon, 25 Apr 2005 17:12:36 +0200
 
 stopmotion (0.pre3.3-1) unstable; urgency=low
 
diff --git a/debian/stopmotion.mime b/debian/stopmotion.mime
index 483de5a..dcba5d0 100644
--- a/debian/stopmotion.mime
+++ b/debian/stopmotion.mime
@@ -1 +1 @@
-application/x-stopmotion;  /usr/bin/stopmotion  -caption "Animation Creator" '%s';   nametemplate='%s.sto'; test=test "$DISPLAY" != ""; priority=9
+application/x-stopmotion;  /usr/bin/stopmotion  -caption "Animation Creator" %s;   nametemplate=%s.sto; test=test "$DISPLAY" != ""; priority=9
diff --git a/debian/control b/debian/control
index 3cc21c7..2c4a90c 100644
--- a/debian/control
+++ b/debian/control
@@ -4,14 +4,14 @@ Priority: optional
 Maintainer: Barak A. Pearlmutter <bap@debian.org>
 Uploaders: Mahyuddin Susanto <udienz@ubuntu.com>,
 	   Bjoern Erik Nilsen <bjoern.nilsen@bjoernen.com>
-Build-Depends: debhelper-compat (= 12),
+Build-Depends: debhelper-compat (= 13),
 	pkg-config,
 	qtbase5-dev, qttools5-dev-tools,
 	qtmultimedia5-dev,
 	libtar-dev,
 	libvorbis-dev,
 	libxml2-dev
-Standards-Version: 4.4.1
+Standards-Version: 4.5.1
 Rules-Requires-Root: no
 Homepage: http://linuxstopmotion.sourceforge.net
 Vcs-Git: https://salsa.debian.org/debian/stopmotion.git
diff --git a/debian/watch b/debian/watch
index 1b239b9..0b05a3b 100644
--- a/debian/watch
+++ b/debian/watch
@@ -2,3 +2,7 @@ version=4
 opts="mode=git, pgpmode=none" \
  https://git.code.sf.net/p/linuxstopmotion/code \
  refs/tags/v?([\d\.]+) debian uupdate
+
+## Would use
+##   refs/tags/v?@ANY_VERSION@
+## but that matches things like 0.8.6-RC1.

--- End Message ---
--- Begin Message --- 
Hi Barak,

On 25-04-2021 18:00, Barak A. Pearlmutter wrote:
> The bump to debhelper 13 was in a commit from September, but it had no
> binary consequences so didn't seem worth an upload.
> Can revert it if you want, but if diffoscope is okay: excellent!

Well, it's the first time I offer a diffoscope diff as an option and I'm
slightly disappointed, although in hind sight, that was to be expected
(SOURCE_DATE_EPOCH is taken from the changelog, which has a new entry
and thus a new timestamp).

> I rebuilt -2 and -3 binary packages and ran diffoscope. Attached.
> Aside from the changelog and the mime file, all differences are just
> timestamps in directory metadata or in images rebuilt at build time.
> (Granted, there are a lot of .png files with build-time timestamps. If
> there's a diffoscope option to ignore all timestamp differences, I
> couldn't find it.)

I think for the purpose of this exercise, one would need to fake the new
changelog entries timestamp to match the previous timestamp (or vice
versa). I'll accept this for this time but will not offer it again
without more tweaking :(.

Paul

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


--- End Message ---
Reply to: