[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#987100: marked as done (unblock: gwenview/4:20.12.3-2)

Your message dated Tue, 20 Apr 2021 08:23:43 +0000
with message-id <E1lYlfb-0002a4-MQ@respighi.debian.org>
and subject line unblock gwenview
has caused the Debian Bug report #987100,
regarding unblock: gwenview/4:20.12.3-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
987100: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=987100
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: debian-kde@lists.debian.org

Please unblock package gwenview

[ Reason ]
The current version of gwenview has a serious bug #987063
that images that get rotated are automatically saved with exif metadata
removed.

[ Impact ]
Exif meta data loss. This is serious since many photo application
workflows depend on exif metadata being present.

[ Tests ]
Bug reported confirms that the new version fixes the problem and
exif data isn't dropped anymore.

[ Risks ]
Code has been in the release till 20.12.1 and has already been merged
into the next release of apps 20.12.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]
Upstream pull request: https://invent.kde.org/graphics/gwenview/-/merge_requests/57

unblock gwenview/4:20.12.3-2

Thanks

Norbert

--
PREINING Norbert                              https://www.preining.info
Fujitsu Research  +  IFMGA Guide  +  TU Wien  +  TeX Live  + Debian Dev
GPG: 0x860CDC13   fp: F7D8 A928 26E3 16A1 9FA0 ACF0 6CAC A448 860C DC13

diff -Nru gwenview-20.12.3/debian/changelog gwenview-20.12.3/debian/changelog
--- gwenview-20.12.3/debian/changelog	2021-03-09 05:52:12.000000000 +0900
+++ gwenview-20.12.3/debian/changelog	2021-04-17 12:49:03.000000000 +0900
@@ -1,3 +1,11 @@
+gwenview (4:20.12.3-2) unstable; urgency=medium
+
+  [ Norbert Preining ]
+  * Cherry-pick upstream fix for lost exif data (Closes: #987063)
+  * Add myself to uploaders.
+
+ -- Norbert Preining <norbert@preining.info>  Sat, 17 Apr 2021 12:49:03 +0900
+
 gwenview (4:20.12.3-1) unstable; urgency=medium
 
   [ Aurélien COUDERC ]
diff -Nru gwenview-20.12.3/debian/control gwenview-20.12.3/debian/control
--- gwenview-20.12.3/debian/control	2021-03-09 05:49:58.000000000 +0900
+++ gwenview-20.12.3/debian/control	2021-04-17 12:48:43.000000000 +0900
@@ -4,6 +4,7 @@
 Maintainer: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
 Uploaders: Aurélien COUDERC <coucouf@debian.org>,
            Sune Vuorela <sune@debian.org>,
+           Norbert Preining <norbert@preining.info>,
 Build-Depends: baloo-kf5-dev (>= 5.13),
                cmake (>= 3.0~),
                debhelper-compat (= 13),
diff -Nru gwenview-20.12.3/debian/patches/series gwenview-20.12.3/debian/patches/series
--- gwenview-20.12.3/debian/patches/series	2020-10-27 07:45:28.000000000 +0900
+++ gwenview-20.12.3/debian/patches/series	2021-04-17 12:46:41.000000000 +0900
@@ -1 +1,2 @@
 fix-incorrect-path-for-interpreter
+upstream-7e59f65f-revert-for-exif-data-loss.patch
diff -Nru gwenview-20.12.3/debian/patches/upstream-7e59f65f-revert-for-exif-data-loss.patch gwenview-20.12.3/debian/patches/upstream-7e59f65f-revert-for-exif-data-loss.patch
--- gwenview-20.12.3/debian/patches/upstream-7e59f65f-revert-for-exif-data-loss.patch	1970-01-01 09:00:00.000000000 +0900
+++ gwenview-20.12.3/debian/patches/upstream-7e59f65f-revert-for-exif-data-loss.patch	2021-04-17 12:46:07.000000000 +0900
@@ -0,0 +1,37 @@
+From 7e59f65fb1f14c36fcf12683c6eacb5f658dc3fc Mon Sep 17 00:00:00 2001
+From: Madhav Kanbur <abcdjdj@gmail.com>
+Date: Fri, 2 Apr 2021 16:11:06 +0530
+Subject: [PATCH] Partially revert commit "Use Quality level when saving JPEG
+ images"
+
+* Fixes exif metadata being lost
+
+Signed-off-by: Madhav Kanbur <abcdjdj@gmail.com>
+---
+ lib/jpegcontent.cpp | 10 ++--------
+ 1 file changed, 2 insertions(+), 8 deletions(-)
+
+diff --git a/lib/jpegcontent.cpp b/lib/jpegcontent.cpp
+index 6189cf99..558a3e94 100644
+--- a/lib/jpegcontent.cpp
++++ b/lib/jpegcontent.cpp
+@@ -687,14 +687,8 @@ bool JpegContent::save(QIODevice* device)
+     d->mRawData.resize(io.size());
+     io.read((unsigned char*)d->mRawData.data(), io.size());
+ 
+-    QImage _image;
+-    _image.loadFromData(d->mRawData);
+-    QImageWriter writer(device, "jpeg");
+-    writer.setQuality(GwenviewConfig::jPEGQuality());
+-    if (!writer.write(_image)) {
+-        d->mErrorString = writer.errorString();
+-        return false;
+-    }
++    QDataStream stream(device);
++    stream.writeRawData(d->mRawData.data(), d->mRawData.size());
+ 
+     // Make sure we are up to date
+     loadFromData(d->mRawData);
+-- 
+GitLab
+

--- End Message ---
--- Begin Message --- 
Unblocked.

--- End Message ---
Reply to: