Bug#987006: unblock: openstack-debian-images/1.59
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Please unblock package openstack-debian-images
Background:
openstack-debian-images isn't only used for creating cloud images as
in cdimage.debian.org, it is also used by openstack-cluster-installer
to install servers with a bgp-to-the-host setup. In this setup, there
is no IP address assigned to physical interfaces, the IP is just bound
to the loopback, and advertized through BGP (here, using FRR).
Problem:
The version 1.58 has a wrong FRR setup (wrong directives), leading to
no connectivity of hosts after reboot.
Fix:
The simple fix is attached. It's simply restoring sanity in the frr.conf
which was somehow working in Buster, but not in Bullseye. Maybe FRR
version 7.5 (bullseye) is more strict that 6.0 (buster).
Tests:
I've tested the install under a Bullseye cluster, and it worked well.
Risks:
Not much... :)
Additionally, I've added a small "sleep 5" after the FSCK of the
installed OS, as I noticed that sometimes, the install crashes at
the end of the script. With it, it never happens. Yes, that's a race
condition, and a sleep command isn't ideal, but at this time, I have
no solution, and it's probably a bit too late to investigate. I hope
you're ok with this.
Please unblock openstack-debian-images/1.59,
Cheers,
Thomas Goirand (zigo)
diff -Nru openstack-debian-images-1.58/build-openstack-debian-image openstack-debian-images-1.59/build-openstack-debian-image
--- openstack-debian-images-1.58/build-openstack-debian-image 2021-03-23 16:35:01.000000000 +0100
+++ openstack-debian-images-1.59/build-openstack-debian-image 2021-04-15 11:35:32.000000000 +0200
@@ -1686,26 +1686,27 @@
echo " !
address-family ipv4 unicast
redistribute connected route-map map-redistribute
- neighbor pg-leaf route-map map-leaf-in out
- neighbor pg-leaf route-map map-leaf-out out
neighbor pg-leaf soft-reconfiguration inbound
+ neighbor pg-leaf route-map map-leaf-in in
+ neighbor pg-leaf route-map map-leaf-out out
exit-address-family
!
address-family ipv6 unicast
redistribute connected route-map map-redistribute
- neighbor pg-leaf route-map map-leaf-in out
- neighbor pg-leaf route-map map-leaf-out out
neighbor pg-leaf activate
neighbor pg-leaf soft-reconfiguration inbound
+ neighbor pg-leaf route-map map-leaf-in in
+ neighbor pg-leaf route-map map-leaf-out out
exit-address-family
!
route-map map-redistribute permit 10
match interface lo
-route-map map-map-leaf-in permit 10
!
route-map map-leaf-out permit 10
match interface lo
!
+route-map map-leaf-in permit 10
+!
" >>${MOUNT_DIR}/etc/frr/frr.conf
fi
@@ -2002,6 +2003,8 @@
fi
sync
+sleep 5
+
if [ "${REAL_HARDWARE}" = "no" ] ; then
kpartx -d ${RAW_NAME}
fi
diff -Nru openstack-debian-images-1.58/debian/changelog openstack-debian-images-1.59/debian/changelog
--- openstack-debian-images-1.58/debian/changelog 2021-03-23 16:35:01.000000000 +0100
+++ openstack-debian-images-1.59/debian/changelog 2021-04-15 11:35:32.000000000 +0200
@@ -1,3 +1,14 @@
+openstack-debian-images (1.59) unstable; urgency=medium
+
+ * Wait 5 seconds after fsck before removing the loop device.
+ * Fixed BGP-2-the-host setup:
+ - Remove "route-map map-map-leaf-in permit 10" when writing the frr.conf,
+ as this breaks the return route with FRR >= 7.
+ - Fix s/route-map map-leaf-in out/route-map map-leaf-in in/.
+ - Add a lasting "route-map map-leaf-in permit 10".
+
+ -- Thomas Goirand <zigo@debian.org> Thu, 15 Apr 2021 11:35:32 +0200
+
openstack-debian-images (1.58) unstable; urgency=medium
* Add cgroupv1 compatibility options on the kernel command line:
Reply to: