[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#986896: marked as done (unblock: armadillo/1:10.1.2+dfsg-5)

Your message dated Tue, 13 Apr 2021 20:53:41 +0000
with message-id <E1lWQ2X-0007Q2-Nj@respighi.debian.org>
and subject line unblock armadillo
has caused the Debian Bug report #986896,
regarding unblock: armadillo/1:10.1.2+dfsg-5
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
986896: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=986896
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package armadillo

[ Reason ]
The pinv and rcond functions have bugs that prevent proper
operation. The former had a a potential divide by zero issue, while
the latter had a compilation related issue. The patches are quite
small, and are present in the version in sid. The patches are attached.

[ Impact ]
Not unblocking would result in buggy numerical code being shipped.


[ Risks ]
There are no risks that I foresee.

[ Checklist ]
  [Y] all changes are documented in the d/changelog
  [Y] I reviewed all changes and I approve them
  [Y] attach debdiff against the package in testing

[ Other info ]
(Anything else the release team should know.)

unblock armadillo/1:10.1.2+dfsg-5

diff -Naur armadillo-10.1.2/include/armadillo_bits/op_cond_meat.hpp armadillo-10.1.2-rcond-bugfix/include/armadillo_bits/op_cond_meat.hpp
--- armadillo-10.1.2/include/armadillo_bits/op_cond_meat.hpp	2016-06-17 02:22:12.000000000 +1000
+++ armadillo-10.1.2-rcond-bugfix/include/armadillo_bits/op_cond_meat.hpp	2021-03-09 16:23:18.251117619 +1000
@@ -58,11 +58,13 @@
     {
     const strip_trimat<T1> S(X.get_ref());
     
-    arma_debug_check( (S.M.is_square() == false), "rcond(): matrix must be square sized" );
+    const quasi_unwrap<typename strip_trimat<T1>::stored_type> U(S.M);
+    
+    arma_debug_check( (U.M.is_square() == false), "rcond(): matrix must be square sized" );
     
     const uword layout = (S.do_triu) ? uword(0) : uword(1);
     
-    return auxlib::rcond_trimat(S.M, layout);
+    return auxlib::rcond_trimat(U.M, layout);
     }
   
   Mat<eT> A = X.get_ref();

diff -Naur armadillo-10.1.2/include/armadillo_bits/op_pinv_meat.hpp armadillo-10.1.2-pinv-bugfix/include/armadillo_bits/op_pinv_meat.hpp
--- armadillo-10.1.2/include/armadillo_bits/op_pinv_meat.hpp	2016-06-17 02:22:12.000000000 +1000
+++ armadillo-10.1.2-pinv-bugfix/include/armadillo_bits/op_pinv_meat.hpp	2021-03-09 16:25:49.909112061 +1000
@@ -119,7 +119,7 @@
       {
       const T val = s_mem[i];
       
-      if(val >= tol)  {  s2_mem[count2] = T(1) / val;  ++count2; }
+      if(val >= tol)  { s2_mem[count2] = (val > T(0)) ? T(T(1) / val) : T(0); ++count2; }
       }

--- End Message ---
--- Begin Message --- 
Unblocked.

--- End Message ---
Reply to: