[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#986675: unblock: puppet/5.5.22-2



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Dear release team,

The current version of puppet is very annoyingly displaying
"$SAFE will become a normal global variable" all the time
in the logs (and "puppet-agent -t" output), to a point that it
really makes it irritating and frustrating. Intri every wrote
on IRC "puppet is no useable this way" because he was so much
annoyed by it! :)

The Puppet packaging team picked-up a patch from upstream
fixing the issue. We would really like (as in: at least 5 DDs)
appreciate if the patch could be included in Bullseye, and
probably the DSA team (who's using puppet a lot) will appreciate
it as well.

Debdiff attached (it's a *very* small patch).

Please unblock puppet/5.5.22-2.

Cheers,

Thomas Goirand (zigo)
diff -Nru puppet-5.5.22/debian/changelog puppet-5.5.22/debian/changelog
--- puppet-5.5.22/debian/changelog	2020-10-25 18:04:24.000000000 +0100
+++ puppet-5.5.22/debian/changelog	2021-03-20 20:37:05.000000000 +0100
@@ -1,3 +1,9 @@
+puppet (5.5.22-2) unstable; urgency=medium
+
+  * Add 0013-fix-SAFE-deprecation-warning.patch (Closes: #973248)
+
+ -- Micah Anderson <micah@debian.org>  Sat, 20 Mar 2021 15:37:05 -0400
+
 puppet (5.5.22-1) unstable; urgency=medium
 
   * New upstream bugfix release
diff -Nru puppet-5.5.22/debian/patches/0013-fix-SAFE-deprecation-warning.patch puppet-5.5.22/debian/patches/0013-fix-SAFE-deprecation-warning.patch
--- puppet-5.5.22/debian/patches/0013-fix-SAFE-deprecation-warning.patch	1970-01-01 01:00:00.000000000 +0100
+++ puppet-5.5.22/debian/patches/0013-fix-SAFE-deprecation-warning.patch	2021-03-20 20:37:05.000000000 +0100
@@ -0,0 +1,22 @@
+From: intrigeri <intrigeri@debian.org>
+Date: Mon, 08 Mar 2021 08:50:20 +0100
+Subject: Deprecation warning in Ruby 2.7: $SAFE will become a normal global variable in Ruby 3.0
+
+Last-Updated: 20-03-2021
+Forwarded: no
+Index: puppet/bin/puppet
+===================================================================
+--- puppet.orig/bin/puppet	2021-03-20 15:36:54.000000000 -0400
++++ puppet/bin/puppet	2021-03-20 15:52:49.355574608 -0400
+@@ -1,5 +1,11 @@
+ #!/usr/bin/env ruby
+ 
++def Warning.warn(w)
++  return if w =~ /warning: \$SAFE will become a normal global variable/
++
++  super w
++end
++
+ begin
+   require 'puppet/util/command_line'
+   Puppet::Util::CommandLine.new.execute
diff -Nru puppet-5.5.22/debian/patches/series puppet-5.5.22/debian/patches/series
--- puppet-5.5.22/debian/patches/series	2020-10-21 21:39:08.000000000 +0200
+++ puppet-5.5.22/debian/patches/series	2021-03-20 20:37:05.000000000 +0100
@@ -10,3 +10,5 @@
 0010-maint-Delete-sync-requires.patch
 0011-PUP-10391-Quiet-Ruby-2.7-URI.escape-warning.patch
 0012-fix-ruby27-warning.patch
+0013-fix-SAFE-deprecation-warning.patch
+

Reply to: