Control: tags -1 confirmed moreinfo
On 2021-04-03 17:32:53 -0400, Ryan Kavanagh wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> X-Debbugs-Cc: rak@debian.org
> Control: blocks -1 980427
>
> Please unblock package neomutt
>
> [ Reason ]
>
> Fixes a screen rendering bug:
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=980427
>
> [ Impact ]
>
> Without this patch, neomutt users see garbage on their screen when their
> terminal is resized. To clear the garbage, users currently need to
> manually redraw their screen (^L).
>
> [ Tests ]
>
> I have used the patch for weeks. It has been fixed upstream since
> December and it has appeared in a stable release.
>
> [ Risks ]
>
> Minimal: the patch adds two missing calls to clear the problematic
> message line.
>
> This is an NMU, and I still have not heard back from the maintainer. I
> submitted the patch to the BTS in January and I declared my intention to
> NMU on March 16.
>
> [ Checklist ]
> [x] all changes are documented in the d/changelog
> [x] I reviewed all changes and I approve them
> [x] attach debdiff against the package in testing
>
> [ Other info ]
>
> Please advise if this is likely to be approved, so that I may upload to
> DELAYED/10.
Assuming that the upload hits the archive soon, I'll unblock it. Please
remove the moreinfo tag once the version is available in unstable.
Cheers
>
> Best,
> Ryan
>
> unblock neomutt/20201127+dfsg.1-1.1
>
> --
> |)|/ Ryan Kavanagh | GPG: 4E46 9519 ED67 7734 268F
> |\|\ https://rak.ac | BD95 8F7B F8FC 4A11 C97A
> diff -Nru neomutt-20201127+dfsg.1/debian/changelog neomutt-20201127+dfsg.1/debian/changelog
> --- neomutt-20201127+dfsg.1/debian/changelog 2021-01-30 11:18:27.000000000 -0500
> +++ neomutt-20201127+dfsg.1/debian/changelog 2021-03-16 15:37:31.000000000 -0400
> @@ -1,3 +1,11 @@
> +neomutt (20201127+dfsg.1-1.1) unstable; urgency=medium
> +
> + * Non-maintainer upload.
> + * Clear the message window on SIGWINCH, redraw-on-sigwinch.patch
> + (Closes: #980427)
> +
> + -- Ryan Kavanagh <rak@debian.org> Tue, 16 Mar 2021 15:37:31 -0400
> +
> neomutt (20201127+dfsg.1-1) unstable; urgency=medium
>
> * New upstream release.
> diff -Nru neomutt-20201127+dfsg.1/debian/patches/series neomutt-20201127+dfsg.1/debian/patches/series
> --- neomutt-20201127+dfsg.1/debian/patches/series 2021-01-30 11:18:27.000000000 -0500
> +++ neomutt-20201127+dfsg.1/debian/patches/series 2021-03-16 15:37:31.000000000 -0400
> @@ -3,3 +3,4 @@
> debian-specific/document_debian_defaults.patch
> misc/smime.rc.patch
> upstream/981306-mime-forwarding.patch
> +upstream/redraw-on-sigwinch.patch
> diff -Nru neomutt-20201127+dfsg.1/debian/patches/upstream/redraw-on-sigwinch.patch neomutt-20201127+dfsg.1/debian/patches/upstream/redraw-on-sigwinch.patch
> --- neomutt-20201127+dfsg.1/debian/patches/upstream/redraw-on-sigwinch.patch 1969-12-31 19:00:00.000000000 -0500
> +++ neomutt-20201127+dfsg.1/debian/patches/upstream/redraw-on-sigwinch.patch 2021-03-16 15:37:31.000000000 -0400
> @@ -0,0 +1,43 @@
> +From: Richard Russon <rich@flatcap.org>
> +Date: Mon, 7 Dec 2020 14:21:45 +0000
> +Subject: clear the message window on SIGWINCH (#2756)
> +
> +When the terminal is resized (or the font-size is changed),
> +the screen must be redrawn. This *used* to involve clearing the entire
> +screen. Soon, it will be delegated to individual windows to refresh
> +themselves.
> +
> +In the mean time, forcibly clear the MessageWindow.
> +
> +Fixes: #2749
> +
> +Origin: https://github.com/neomutt/neomutt/commit/88f0b0572da9414550608054e960fd00b8d6b939
> +---
> + index.c | 1 +
> + pager.c | 1 +
> + 2 files changed, 2 insertions(+)
> +
> +diff --git a/index.c b/index.c
> +index c29ba8b..af3a18f 100644
> +--- a/index.c
> ++++ b/index.c
> +@@ -1368,6 +1368,7 @@ int mutt_index_menu(struct MuttWindow *dlg)
> + /* force a real complete redraw. clrtobot() doesn't seem to be able
> + * to handle every case without this. */
> + clearok(stdscr, true);
> ++ mutt_window_clearline(MessageWindow, 0);
> + continue;
> + }
> +
> +diff --git a/pager.c b/pager.c
> +index b08dda2..0e333c0 100644
> +--- a/pager.c
> ++++ b/pager.c
> +@@ -2473,6 +2473,7 @@ int mutt_pager(const char *banner, const char *fname, PagerFlags flags, struct P
> + SigWinch = 0;
> + mutt_resize_screen();
> + clearok(stdscr, true); /* force complete redraw */
> ++ mutt_window_clearline(MessageWindow, 0);
> +
> + if (flags & MUTT_PAGER_RETWINCH)
> + {
--
Sebastian Ramacher
Attachment:
signature.asc
Description: PGP signature