Package: release.debian.org Severity: normal User: release.debian.org@packages.debian.org Usertags: unblock I am preparing a targeted fix for package alien and would like to get reviewed by the Release team first to see if everything is OK before uploading onto unstable. [ Reason ] Current version of package alien in Debian Testing (8.95.3) is affected by several important (including a RC) bugs: * #985835: alien incorrectly replicates filepaths When converting rpm packages to deb packages, files under /usr/ were incorrectly placed under /. * #983492: alien incorrectly generates debian/rules This is a regression caused by one of my previous upload. When hardcoding "dh $@" in generated debian/rules, the symbol "$" and "@" were not escaped so they disappeared in generated debian/rules file, causing all rpm2deb package build to fail (only "dh", no "dh $@"). * #985808: alien: cannot convert aarch64 rpm packages to arm64 deb Previously alien did not include the matching between aarch64 (rpm) to arm64 (deb). [ Impact ] If #985835 is not fixed, all output deb packages will be ususable if there should be any files under /usr/. If #983492 is not fixed, the conversion from rpm to deb will be completely broken. If #985808 is not fixed, conversion of arm64 packages will be unavailable. [ Tests ] I tested locally on my local machines (arm64 and amd64) to verify the correctness of those bugfixes. [ Risks ] The risk of introducing new regression should be limited. I have personally reviewed the coding of all patches as well. [ Checklist ] [Y] all changes are documented in the d/changelog [Y] I reviewed all changes and I approve them [Y] attach debdiff against the package in testing [ Other info ] Package alien has been orphaned for a while. This is actually part of the QA work. Full debdiff in the attachment. unblock alien/8.95.4
diff -Nru alien-8.95.3/Alien/Package/Deb.pm alien-8.95.4/Alien/Package/Deb.pm
--- alien-8.95.3/Alien/Package/Deb.pm 2020-11-01 13:35:34.000000000 -0500
+++ alien-8.95.4/Alien/Package/Deb.pm 2021-04-07 12:15:06.000000000 -0400
@@ -472,7 +472,7 @@
PACKAGE=\$(shell dh_listpackages)
%:
- dh $@
+ dh \$\@
override_dh_clean:
dh_clean -d
@@ -482,9 +482,11 @@
override_dh_auto_build:
override_dh_auto_install:
+ mkdir -p debian/\$(PACKAGE)
# Copy the packages's files.
find . -maxdepth 1 -mindepth 1 -not -name debian -print0 | \\
- xargs -0 -r -i cp -a {} debian/\$(PACKAGE)
+ sed -e s#'./'##g | \\
+ xargs -0 -r -i cp -a ./{} debian/\$(PACKAGE)/{}
#
# If you need to move files around in debian/\$(PACKAGE) or do some
# binary patching, do it here
diff -Nru alien-8.95.3/Alien/Package/Rpm.pm alien-8.95.4/Alien/Package/Rpm.pm
--- alien-8.95.3/Alien/Package/Rpm.pm 2020-11-01 13:35:34.000000000 -0500
+++ alien-8.95.4/Alien/Package/Rpm.pm 2021-04-07 12:13:27.000000000 -0400
@@ -744,6 +744,10 @@
# Treat armv7l as armel.
$arch='armel';
}
+ elsif ($arch eq 'aarch64') {
+ # Treat aarch64 as arm64.
+ $arch='arm64';
+ }
elsif ($arch eq 'parisc') {
$arch='hppa';
}
diff -Nru alien-8.95.3/debian/changelog alien-8.95.4/debian/changelog
--- alien-8.95.3/debian/changelog 2021-02-11 15:02:09.000000000 -0500
+++ alien-8.95.4/debian/changelog 2021-04-07 12:15:06.000000000 -0400
@@ -1,3 +1,19 @@
+alien (8.95.4) unstable; urgency=high
+
+ * QA upload.
+ * Alien/Package/Deb.pm: Fix incorrect debian/rules template by
+ properly escaping special characters (dh \$\@ instead of dh $@).
+ Closes: #983492.
+ * Alien/Package/Deb.pm: Fix incorrect file installation path.
+ This fixes the bug in manual override_dh_auto_install that files
+ are placed under / instead of /usr/ (default prefix).
+ Closes: #985835.
+ * Alien/Package/Rpm.pm: Also map aarch64 in rpm to arm64 in deb.
+ This fixes conversion of aarch64 rpm packages.
+ Closes: #985808.
+
+ -- Boyuan Yang <byang@debian.org> Wed, 07 Apr 2021 12:15:06 -0400
+
alien (8.95.3) unstable; urgency=medium
* QA upload.
Attachment:
signature.asc
Description: This is a digitally signed message part