[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#986559: unblock: pd-purest-json/1.4.3-2



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package pd-purest-json

at the beginning of march 2021, a bug was discovered in the
pd-purest-json package that prevents it from reading JSON-files.

the package itself is mainly used for interacting with RESTful APIs from
within the Pure Data programming language (package "puredata"), for
which the broken functionality does not really matter.
however, the "other task" provided by this package is "working with JSON
data", for which the task of reading JSON-file could be considered
crucial.
for whatever reasons the bug-report has not been escalated to RC yet.

as you can see from the debdiff, the change is rather minimal and
trivial.

due to the nature of the Pure Data ecosystem, virtually no
"applications" are packaged, making the "pd-purest-json" package a leaf
package.
as such, i don't expect any direct impact on any other Debian package
whatsoever.

cheers and thanks for all the good work.


unblock pd-purest-json/1.4.3-2
diff -Nru pd-purest-json-1.4.3/debian/changelog pd-purest-json-1.4.3/debian/changelog
--- pd-purest-json-1.4.3/debian/changelog	2019-12-09 22:47:59.000000000 +0100
+++ pd-purest-json-1.4.3/debian/changelog	2021-03-08 13:14:11.000000000 +0100
@@ -1,3 +1,9 @@
+pd-purest-json (1.4.3-2) unstable; urgency=medium
+
+  * Patch to fix reading of json-data (Closes: #984787)
+
+ -- IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org>  Mon, 08 Mar 2021 13:14:11 +0100
+
 pd-purest-json (1.4.3-1) unstable; urgency=medium
 
   * New upstream version 1.4.3
diff -Nru pd-purest-json-1.4.3/debian/patches/json_encode_read.patch pd-purest-json-1.4.3/debian/patches/json_encode_read.patch
--- pd-purest-json-1.4.3/debian/patches/json_encode_read.patch	1970-01-01 01:00:00.000000000 +0100
+++ pd-purest-json-1.4.3/debian/patches/json_encode_read.patch	2021-03-08 13:14:11.000000000 +0100
@@ -0,0 +1,17 @@
+Description: fix check whether read JSON-data is valid
+Author: IOhannes m zmölnig
+Bug: https://github.com/residuum/PuRestJson/issues/60
+Last-Update: 2021-03-08
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- pd-purest-json.orig/src/json-encode.c
++++ pd-purest-json/src/json-encode.c
+@@ -298,7 +298,7 @@
+ 	}
+ 	jobj = json_tokener_parse(json_string);
+ 	freebytes(json_string, (st.st_size + 1) * sizeof(char));
+-	if (jobj == NULL) {
++	if (jobj != NULL) {
+ 		jenc_load_json_data(jenc, jobj);
+ 		json_object_put(jobj);
+ 	} else {
diff -Nru pd-purest-json-1.4.3/debian/patches/series pd-purest-json-1.4.3/debian/patches/series
--- pd-purest-json-1.4.3/debian/patches/series	2019-12-09 22:47:59.000000000 +0100
+++ pd-purest-json-1.4.3/debian/patches/series	2021-03-08 13:14:11.000000000 +0100
@@ -0,0 +1 @@
+json_encode_read.patch

Reply to: