[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#986345: marked as done (unblock: rxvt-unicode/9.22-10)

Your message dated Mon, 05 Apr 2021 14:07:40 +0000
with message-id <E1lTPtE-0007xk-1B@respighi.debian.org>
and subject line unblock rxvt-unicode
has caused the Debian Bug report #986345,
regarding unblock: rxvt-unicode/9.22-10
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
986345: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=986345
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: rak@debian.org

Please unblock package rxvt-unicode

[ Reason ]

Fixes a segfault on exit

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=981010

[ Tests ]

Patch cherry-picked from upstream. Fixed upstream ~9 months ago.

I cannot reproduce the segfault on exit.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]

Still too young for migration (currently 14/20 days old), so this is
just a proactive unblock request before I forget about it.

unblock rxvt-unicode/9.22-10

-- 
|)|/  Ryan Kavanagh      | GPG: 4E46 9519 ED67 7734 268F
|\|\  https://rak.ac     |      BD95 8F7B F8FC 4A11 C97A

diff -Nru rxvt-unicode-9.22/debian/changelog rxvt-unicode-9.22/debian/changelog
--- rxvt-unicode-9.22/debian/changelog	2020-07-29 11:48:03.000000000 -0400
+++ rxvt-unicode-9.22/debian/changelog	2021-03-20 12:48:03.000000000 -0400
@@ -1,3 +1,16 @@
+rxvt-unicode (9.22-10) unstable; urgency=medium
+
+  * Correct a mistake in 19_sigsegv_perl_environ.diff
+
+ -- Ryan Kavanagh <rak@debian.org>  Sat, 20 Mar 2021 12:48:03 -0400
+
+rxvt-unicode (9.22-9) unstable; urgency=medium
+
+  * Fix segfault at exit, 19_sigsegv_perl_environ.diff (Closes: #981010)
+  * Bump copyright years
+
+ -- Ryan Kavanagh <rak@debian.org>  Sat, 20 Mar 2021 10:18:47 -0400
+
 rxvt-unicode (9.22-8) unstable; urgency=medium
 
   * Fix incorrect manpage output due to 12_hyphen_minus_sign.diff
diff -Nru rxvt-unicode-9.22/debian/copyright rxvt-unicode-9.22/debian/copyright
--- rxvt-unicode-9.22/debian/copyright	2018-01-04 13:46:13.000000000 -0500
+++ rxvt-unicode-9.22/debian/copyright	2021-03-20 10:18:33.000000000 -0400
@@ -40,7 +40,7 @@
 Copyright:
     Copyright (C) 2004-2006  Eduard Bloch <blade@debian.org>
     Copyright (C) 2006-2011  Decklin Foster <decklin@red-bean.com>
-    Copyright (C) 2011-2017  Ryan Kavanagh <rak@debian.org>
+    Copyright (C) 2011-2021  Ryan Kavanagh <rak@debian.org>
 License: GPL-2.0+
 
 Files: debian/extensions/urxvt-font-size/*
diff -Nru rxvt-unicode-9.22/debian/patches/19_sigsegv_perl_environ.diff rxvt-unicode-9.22/debian/patches/19_sigsegv_perl_environ.diff
--- rxvt-unicode-9.22/debian/patches/19_sigsegv_perl_environ.diff	1969-12-31 19:00:00.000000000 -0500
+++ rxvt-unicode-9.22/debian/patches/19_sigsegv_perl_environ.diff	2021-03-20 12:48:03.000000000 -0400
@@ -0,0 +1,41 @@
+Description: Fix segfault on exit
+ Slightly tweaked version of upstream patch listed in Origin:
+Author: Ryan Kavanagh <rak@debian.org>
+Origin: http://cvs.schmorp.de/rxvt-unicode/src/rxvtperl.xs?r1=1.246&r2=1.247
+        http://cvs.schmorp.de/rxvt-unicode/src/rxvtperl.h?r1=1.28&r2=1.29
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=981010
+Last-Update: 2021-03-20
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- rxvt-unicode/src/rxvtperl.xs	2020/01/20 09:35:12	1.246
++++ rxvt-unicode/src/rxvtperl.xs	2020/06/30 07:31:24	1.247
+@@ -372,6 +372,9 @@
+ 
+ static PerlInterpreter *perl;
+ 
++#if 0 /* we are not a library anymore, so doing this is just not worth it */
++/*THINK/TODO: this has the side effect of, of course, not calling destructors. */
++/* but therse are not guaranteed anyway... */
+ rxvt_perl_interp::~rxvt_perl_interp ()
+ {
+   if (perl)
+@@ -381,6 +384,7 @@
+       PERL_SYS_TERM ();
+     }
+ }
++#endif
+ 
+ void
+ rxvt_perl_interp::init ()
+--- rxvt-unicode/src/rxvtperl.h	2012/06/12 10:45:53	1.28
++++ rxvt-unicode/src/rxvtperl.h	2020/06/30 07:31:24	1.29
+@@ -51,7 +51,9 @@
+ {
+   char **perl_environ;
+ 
++  #if 0 // see rxvtperl.xs
+   ~rxvt_perl_interp ();
++  #endif
+ 
+   void init ();
+   void init (rxvt_term *term);
diff -Nru rxvt-unicode-9.22/debian/patches/series rxvt-unicode-9.22/debian/patches/series
--- rxvt-unicode-9.22/debian/patches/series	2020-07-27 16:12:41.000000000 -0400
+++ rxvt-unicode-9.22/debian/patches/series	2021-03-20 12:48:03.000000000 -0400
@@ -8,3 +8,4 @@
 16_no_terminfo.diff
 17_unsafe_man.diff
 18_expand_urxvt-tabbed.1.diff
+19_sigsegv_perl_environ.diff

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Unblocked.

--- End Message ---
Reply to: